Commit graph

527 commits

Author SHA1 Message Date
peterbulmer
d813bd8763 MDL19219 mnet, mitigate arrkey loss in transit
When usernames are numeric, they are lost in mnet transit when used as
keys in the array result of course_enrolments(). As the username is not
sent with the enrolment details, it was not previously recoverable.
This patch adds the information to the enrolment details,
(enrol/mnet/enrol.php), and adds support for recovering the username if
it was numeric (and hence lost) (admin/mnet/enr_course_enrol.php)
2009-05-18 02:42:18 +00:00
tjhunt
1e3d1148a3 Flatfile enrolment: MDL-11418 SQL error. Thanks to Patrick Pollet.
I don't know exactly how this works, but it looks like a good fix to me, so committing.
2008-12-15 02:53:44 +00:00
stronk7
97f4bb9fde Backporting MDL-16715 to 18_STABLE (new transid codes). Credit goes to Ethem Elvice. 2008-09-27 17:35:39 +00:00
jerome
d5e89c7964 MDL-16043: manage case when administrator set enrol_remotecoursefield or enrol_remoteuserfield in UPPERCASE, merged from 19 2008-08-27 07:06:57 +00:00
jerome
224ac0b90f MDL-16043: ensures cross-db: add lowercase conversion for every database fieldname, merged from 19 2008-08-14 11:34:00 +00:00
scyrma
73ef9f11ba MDL-15403: Patch sent by Peter Bulmer, said to have been written by Donal McMullan. Prevents a remotely-triggered mass-unenrolments of users in a
(mnet-enabled) course. (backport from 1.9)
2008-07-09 09:21:53 +00:00
iarenaza
9306b4f5c5 MDL-12783 IMS idon't unenroll students who were enrolled by other plug-ins
Credit goes to Scott Krajewski for the bug report and patch!
2008-06-08 15:28:08 +00:00
iarenaza
913f427e3b MDL-15182 Fix LDAP enrolment course auto-creation at user login 2008-06-07 21:18:12 +00:00
iarenaza
fb8f96c38d MDL-15039 Apostrophes in idnumber prevent users from being unenrolled via LDAP
If any member of a course has an ID number containing an apostrophe (eg.
CN=Paddy O'Brien,OU=Students,DC=etc...), no other members will ever be
unenrolled via LDAP.

Thanks to Michael Woods for the bug report and proposed solution.
2008-06-02 22:33:08 +00:00
stronk7
68abb79baf Prevent excess of unenolments by enrol_database_sync.php. MDL-8550 ; backported from HEAD 2008-05-11 23:56:13 +00:00
stronk7
9922fbf9d6 Not visible courses don't cause unenrolment under LDAP anymore. Credit goes to Iñaki Arenaza. MDL-14097 ; backported from HEAD 2008-03-30 00:47:26 +00:00
ethem
0425032153 Race condition in cron for Scheduled-Capture (very very big sites and order review enabled only).
In one cron, 250-500 orders may be processed (based on 5 minutes).
If an admin sets cron time up smaller than 5 minutes and
250-500> new transactions are made after last cron executed, it can be blocked.
Authorize cron sets up an_lastcron every time when admin/cron.php executes.
This must be set up after blocking check code.

As result, if pending orders aren't accepted with in 30 days at payment management page, they expired and users cannot enrol.
When an admin enabled order review, he is guaranteed 'Payment managers accept/deny transactions manually'.
Scheduled-Capture is designed for forgotten orders only ;)

Backported from HEAD.
2008-03-11 08:33:18 +00:00
ethem
3211d8b265 Merged from MOODLE_17_STABLE 2008-02-11 15:31:10 +00:00
ethem
2b72207cc3 Cron handles all expired unenrolments. It is time to use own enrolment method when calling funcs enrol_into_course, role_assign.
Zend Studio Warning: Assignment in condition (line XX), Solved, one more ()

Merged from MOODLE_17_STABLE
2008-02-07 16:18:48 +00:00
ethem
5580a59ba7 Tidy up 2008-01-15 10:58:24 +00:00
ethem
7bf7c697d3 MDL-12958 In the Authorize enrol plug-in when a credit card expiry date (year) is entered, a validate error is generated blocking credit card usage 2008-01-14 17:58:06 +00:00
skodak
9346aeddae MDL-9744 passwork field for ldap bind pw - patch by Iñaki Arenaza 2008-01-02 22:52:43 +00:00
ethem
80d7317a79 Fixo 2007-11-20 14:25:20 +00:00
ethem
47d75826be Fix for Canadian Postal Code
http://moodle.org/mod/forum/discuss.php?d=81736
2007-11-20 13:41:49 +00:00
iarenaza
d359ac1491 MDL-11099 and MDL-11655 Don't show external db password in clear 2007-11-18 12:43:11 +00:00
mchurch
58e84d7044 MDL-11991 Fixing error on undefined method while using the manual plug-in. 2007-11-13 18:02:28 +00:00
ethem
c5edbc12e8 Fix for refactoring
Fatal error: Call to undefined method enrolment_plugin_authorize::print_enrolmentkeyfrom() in /usr/local/www/data/moodle/enrol/manual/enrol.html on line 7
2007-11-07 15:51:45 +00:00
donal72
9822b38f10 Initialize the $message variable properly this time. 2007-11-01 21:30:25 +00:00
donal72
dc2ea6fb26 Revert: Initialize the $message variable 2007-11-01 21:27:51 +00:00
nicolasconnault
4970ebb19c MDL-11328 added the missing variable 2007-11-01 09:29:12 +00:00
donal72
c5fbfafa62 Initialize the $message variable 2007-11-01 05:02:31 +00:00
donal72
dbd1755a42 MDL-11329: fixed text: "Local courses for external users:" 2007-10-16 09:14:25 +00:00
nicolasconnault
3d6d2b8153 MDL-8605 New user directories implemented 2007-10-11 13:19:53 +00:00
iarenaza
c798b55df4 Remove additional check when dealing with hidden courses in LDAP enrolment.
The check is superfluous and uses an inexistant variable ($type) that
was removed when we switched to role based enrolment.

Fixes MDL-11098 MDL-10282 and MDL-8346. (backported from HEAD)
2007-09-15 21:54:13 +00:00
skodak
e0a8a35867 MDL-11053 Course object not escaped before insert - patch by Aaron C Spike; backported from HEAD 2007-08-29 13:54:09 +00:00
nicolasconnault
d6c42bb205 MDL-10918 Applied Aaron's patch 2007-08-27 14:03:28 +00:00
thepurpleblob
a871e630b2 MDL-10585:
MDL-10584:
Present more factually correct message when a guest attempts to enrol.
Provide a mechanism for specifying which role in a course holds the
enrolment key.
2007-08-01 11:50:00 +00:00
thepurpleblob
14f42baf18 MDL-10396:
Add an option and a check to (optionally) prevent users being enrolled
in hidden courses.
2007-07-20 13:01:24 +00:00
thepurpleblob
0dc4f14a26 MDL-10157:
Turn the diagnostic prints into error_logs. The more normal "course skipped"
message now requires DEBUG_ALL or greater before it is generated at all.
2007-07-20 08:55:44 +00:00
toyomoyo
7936d32cf6 fix for MDL-9937, hidden teachers are visible during course enrol 2007-07-09 07:42:02 +00:00
thepurpleblob
dee89d7ecc Missing a CVS Id tag 2007-06-18 10:27:08 +00:00
ethem
f8128f42a9 MDL-9836
Authorize.net / SSL Config Bug prevents display of options from enrol/authorize/enrol.php
2007-06-15 17:45:28 +00:00
skodak
09048346de MDL-9418 use proper addslashes before each insert 2007-05-16 20:07:15 +00:00
Martin Langhoff
48cc1a0e6a cvsimport fixups - remove obsolete files 2007-05-09 22:01:21 +12:00
nicolasconnault
c30e73badc Fixed many XHTML errors 2007-04-20 07:49:39 +00:00
nicolasconnault
a0eb0c7b14 MDL-9322 Fixed all non-compliant XHTML in mnet files (plus logs and enrol) 2007-04-13 06:33:00 +00:00
martinlanghoff
8632e95b13 Bug fix: 'off by one'month bug in mupltiple locations.
When the system/user time zone was set to GMT-13 months would lag behind by
one month.


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-13 05:05:56 +00:00
nicolasconnault
6907f59129 MDL-9207 2007-04-05 01:53:28 +00:00
skodak
66c8048d55 MDL-9169 Error in function call in ldap/enrol.php; typo found by Svante Agnestig 2007-04-02 13:15:36 +00:00
skodak
daea824d68 MDL-4313 LDAP doesn't properly escape extra quotes in course details + minor role unassign change 2007-03-29 21:39:35 +00:00
danmarsden
9228be2bd2 MDL-9102 incorrect use of unset_config() 2007-03-28 23:35:07 +00:00
toyomoyo
e17732128a applying inaki's patch for MDL-9012, course autocreation doesn't work in enrol/database 2007-03-26 06:49:42 +00:00
nicolasconnault
8d96b8a10a MDL-8963 : The code was using $group->password instead of $group->enrolmentkey. 2007-03-21 06:15:10 +00:00
ethem
f7b1762793 Code cleanup 2007-03-14 13:26:24 +00:00
skodak
011d1af528 MDL-8524 general roles cleanup; MDL-8373 authenticated user role now created during upgrade from 1.7.x, xhtml and CSS cleanup in roles GUI; accesslib inline docs cleanup; risk bitmask fixes - backported from HEAD 2007-03-05 11:37:54 +00:00