Commit graph

270 commits

Author SHA1 Message Date
jerome
600313b982 output MDL-19077 typo bug 2009-07-03 04:08:52 +00:00
tjhunt
db8d89d822 MDL-19077 I just found a way to reduce the coupling between the classes. 2009-07-02 07:06:25 +00:00
tjhunt
b70094743a themes: MDL-19077 change how the theme is initialised and CSS is served.
This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

$THEME is now initialised at the same time as $OUTPUT. Old functions like
theme_setup are deprecated in favour of methods on $PAGE. There is a new
theme_config class in outputlib.php that deals with loading the theme config.php file.

CSS used to be served by themes styles.php files calling a function in weblib.php.
Now it works by each theme's styles.php file doing
$themename = basename(dirname(__FILE__));
require_once(dirname(__FILE__) . '/../../theme/styles.php');
which is less code to be copied into each theme. (Old-style styles.php files still
work thanks to some code in deprecatedlib.php.)

Admin UI for choosing a theme cleaned up.

A couple of theme-specific hard-coded hacks like $THEME->cssconstants and
$THEME->CSSEdit have been replaced by a more generic $THEME->customcssoutputfunction
hook. See examples at the end of outputlib.php

Also:
* Fix setting the theme in the URL, which seems to have been broken since 1.9.
* Fix up errors on a few pages caused by the new initialisation order.
* MDL-19097 moodle_page::set_course should not set $COURSE unless it is $PAGE.
* httpsrequired() from moodlelib.php moved to $PAGE->https_required().
* Move has_started() method to the renderer base class.
* Further fixes to display of early errors.
* Remove print_header/footer_old from weblib. I did not mean to commit them before.
2009-07-01 05:54:26 +00:00
stronk7
fcae2e3ba3 Fixed typo that was breaking badly custom_corner deprecated uses. 2009-06-29 17:11:34 +00:00
tjhunt
a5cb8d6987 MDL-19077 - Finish eliminating customcorners-specific code in core.
The custom-corners-specific code now in theme/customcornser/renderers.php
and lib/deprecatedlib.php.

Also, $CFG->pixpath is now causing more problems than ever. If it is
giving your problems, please call $OUTPUT->initialise_deprecated_cfg_pixpath()
as a temporary fix. As you can imagine, we are thinking about a better
long-term fix, which is why that method as a silly, and easy to grep name.
2009-06-29 08:17:31 +00:00
tjhunt
fd1a792e13 themes: MDL-19640 / MDL-19077 remove other references to _print_normal_error 2009-06-29 00:34:49 +00:00
tjhunt
e29380f3c4 themes: MDL-19077 fix install regression 2009-06-26 09:38:14 +00:00
tjhunt
34a2777ccb themes: MDL-19077 new $OUTPUT->header/footer to replace print_header/footer.
Also, part of the change from weblib.php functions to $OUTPUT-> methods.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

This is a big change, and the result is not perfect yet. Expect some debugging output
on some pages.

The main part of these changes are that $OUTPUT->header now looks for a file
in the theme called layout.php, rather than header.html and footer.html. Also
you can have special templates for certain pages like layout-home.php. There is
fallback code for Moodle 1.9 themes, so they still work.

A few of the old arguments to print_header are no longer supported. (You get an
exception if you try to use them.) Sam H will be cleaning those up.

All the weblib functions that have been replaced with $OUTPUT-> have version in
deprecatedlib, so existing code will go on working for the foreseeable future.
2009-06-26 09:06:16 +00:00
tjhunt
8954245a1b themes: MDL-19077 start implementing moodle_core_renderer
Only a couple of methods implemented. Please review the API and
tell me if you are not happy with the direction I am taking.
2009-06-23 10:41:22 +00:00
tjhunt
5af6ec1b2e MDL-19600 remove remaining traces of docstyles.php.
(Not used since Moodle 1.6.)
Also remove the remaining bits of lang/en_utf8/docs.
2009-06-23 04:39:11 +00:00
tjhunt
cf6155226c ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.
There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)
2009-06-12 12:13:07 +00:00
samhemelryk
c861fe2f83 deprecatedlib MDL-19236 corrected boilerplate tag order and package 2009-05-22 09:10:53 +00:00
stronk7
526fe7d8da MDL-18577 drop enums support - step3: deprecate old change_field_enum() use
by new drop_enum_from_field() available in 2.0
2009-05-02 00:22:20 +00:00
skodak
fe772c2aa7 MDL-18472 fixed missing argument in deprecated function, thanks Gordon Bateson 2009-03-26 20:53:03 +00:00
stronk7
7b837bc375 MDL-18244 sql_length() - deprecate old use of function 2009-02-15 23:18:49 +00:00
skodak
18818abf4c MDL-17458 $CFG->rolesactive cleanup + other cleanup in upgrade code 2009-01-15 22:09:57 +00:00
mchurch
6795800d8b Fixed addslashes_object deprecated message. 2008-12-01 20:05:00 +00:00
stronk7
3ed22f1a25 Fix for deprecated zip_files() function. Packager requires
destination file full path. Non-existing bug in Tracker.
2008-10-16 17:50:13 +00:00
skodak
165a2c9efe fixed typo 2008-09-24 21:04:53 +00:00
skodak
2fd0e9fe58 MDL-16644 removing striplsahses() and friends 2008-09-23 21:09:46 +00:00
skodak
5ca18631bc MDL-16029 removing recently added support for $extralocation from print_error(), thanks TIm for pointing out this is not the recommended way anymore 2008-09-02 06:03:37 +00:00
skodak
c018fde2df MDL-16029 Added $extralocations in the function print_error; merged from MOODLE_19_STABLE 2008-09-01 15:31:09 +00:00
scyrma
88c8d16194 MDL-14741: clean up some old code. This needs to be confirmed backward-compatible. 2008-08-29 09:54:44 +00:00
skodak
0b0bfa9345 MDL-15919, MDL-15920 reworked support for archiving 2008-08-08 10:22:59 +00:00
skodak
ed94cb66c6 MDL-15928 switched to zip PHP extensions 2008-08-04 16:45:08 +00:00
skodak
0c6d2dd41a MDL-15919 deprecated old unzip_files() 2008-08-02 18:59:00 +00:00
skodak
eee5d9bb85 MDL-14956 DDL exceptions 2008-06-22 16:51:55 +00:00
skodak
b1f93b1512 MDL-15246 moving all remaining ddl function to adminlib, keeping old lib/ddllib.php only for BC withexisting code; fixed inline docs related to ddl 2008-06-15 10:32:50 +00:00
skodak
251387d087 MDL-14956 basic exception support in Moodle + other minor related refactoring 2008-06-13 17:51:34 +00:00
skodak
a230012cd8 MDL-14905 towards functional DB tests 2008-06-13 08:35:29 +00:00
skodak
e6b4f00ed7 MDL-14905 towards functional DB tests 2008-06-10 19:54:27 +00:00
skodak
245ac55791 MDL-14679 last forgotten bits of dml conversion 2008-06-09 19:48:24 +00:00
skodak
294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak
9f43d70d24 MDL-15080 char to int cast problem in get_recent_enrolments() 2008-06-01 13:20:02 +00:00
skodak
10df888a1f MDL-14679 deprecated lib converted to new $DB 2008-05-25 14:33:33 +00:00
skodak
45de775fc9 MDL-14978 removed obsoleted make_table() 2008-05-25 14:28:58 +00:00
skodak
3c268f2569 MDL-14978 removed obsoleted get_course_users() 2008-05-25 14:27:33 +00:00
skodak
31372ef93f MDL-14679 deprecated conversion 2008-05-25 11:19:06 +00:00
skodak
79eaec48cd MDL-14978 removed obsoleted get_site_users() 2008-05-25 11:18:12 +00:00
skodak
7cd9fcfe63 MDL-14978 removed obsoleted get_course_teachers() 2008-05-25 11:07:57 +00:00
skodak
e2fc9a8850 MDL-14978 removed obsoleted get_course_students() 2008-05-25 11:06:23 +00:00
skodak
4119bfec09 MDL-14978 removed obsoleted iscreator() 2008-05-25 11:02:58 +00:00
skodak
c4d61f7af0 MDL-14978 removed obsoleted get_group_users() 2008-05-25 11:00:59 +00:00
skodak
c5eb1adbf9 MDL-14978 removed obsoleted get_group_users() 2008-05-25 10:59:41 +00:00
skodak
bc8d118210 MDL-14679 fixed $exceptions regression in first part of datalib conversion 2008-05-25 10:16:53 +00:00
skodak
e3c7f155d8 MDL-14978 removed obsoleted isadmin() 2008-05-25 10:08:05 +00:00
skodak
72f563b91c MDL-14978 replaced deprecated can_use_richtext_editor 2008-05-25 09:57:58 +00:00
skodak
a7544e377a MDL-14974 improved columns caching implementation 2008-05-25 09:31:38 +00:00
nicolasconnault
73f7ad715e MDL-14905 Started on the DDL functional tests. Added an ugly but temporary hack into error() and print_error(), so that they throw an exception instead of dying when UNITTEST is defined. 2008-05-21 14:59:33 +00:00
scyrma
e41b104f67 MDL-11113: re-add function to deprecatedlib.php, and use it in old version of the help file. 2008-05-08 02:38:47 +00:00