Commit graph

2537 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
6e3f19324a Merge branch 'MDL-65397-35-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_35_STABLE 2019-05-01 01:43:11 +02:00
Helen Foster
23bb771193 MDL-65397 lang: Import fixed English strings (en_fix)
Significant string changes:

* direct:view,gradeimport_direct - wording corrected from 'CSV' to
  'spreadsheet'
* limitanswers_help,mod_choice - additional wording added explaining how
  the setting works with groups
2019-04-29 11:50:36 +02:00
Amaia Anabitarte
596aa22c4e MDL-63137 mod_feedback: Pointing TODO tasks to right deprecation issue 2019-04-26 17:32:57 +02:00
David Monllaó
87648029c4 Merge branch 'MDL-29317-35' of git://github.com/junpataleta/moodle into MOODLE_35_STABLE 2019-04-15 07:43:38 +02:00
Jun Pataleta
3304b0728c Merge branch 'MDL-64524-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-04-01 13:46:34 +08:00
Damyon Wiese
d831bfbf04 MDL-64524 gradingform_guide: Marking guide comments
When there are too many comments, scroll the list so they still fit in the dialogue.
2019-04-01 13:03:59 +08:00
Jun Pataleta
b9ceefadf0 MDL-29317 gradeimport_csv: Case-insensitive query for email and username
Query using the following fields for
\gradeimport_csv_load_data::check_user_exists() should be done in a
case-insensitive manner:
* email - As agreed in MDL-29315
* username - Although usernames can only be in lowercase during
  registration, usernames are being handled in a case-insensitive
  fashion when logging in. It makes sense to make check_user_exists()
  consistent with this behaviour.
2019-03-29 13:30:06 +08:00
Jun Pataleta
2ff2274ffc MDL-29317 gradeimport_csv: Tests for case-insensitivity 2019-03-29 13:30:06 +08:00
Jun Pataleta
9820d27a23 MDL-64958 gradeimport_csv: Better unit tests for check_user_exists() 2019-03-11 09:36:00 +08:00
Jun Pataleta
78615db17f MDL-64958 grade_import: Ensure correct user is being fetched
* We need to ensure that we are checking the correct user account.
  Since email and idnumber are not unique fields, there's a chance that
  multiple user records will match when querying for user data using
  these fields. This might lead to a different user's grades being
  inadvertently modified during grade import. In such a case, this
  function needs to return a null userid.
2019-03-11 09:36:00 +08:00
Luca Bösch
960fef4854 MDL-64577 grade: style "Add ID numbers" button. 2019-02-01 07:08:18 +01:00
Damyon Wiese
aa3c3bd353 MDL-64375 gradingform_rubric: Styles for overflow
Allow people to define lots of levels, and make the scroll region just the rubric table,
not the entire content region.
2019-01-04 08:44:41 +08:00
Jake Dallimore
cb14d331fe Merge branch 'MDL-64216-m35' of https://github.com/micaherne/moodle into MOODLE_35_STABLE 2018-12-19 11:08:35 +08:00
Luca Bösch
1188a6e41b MDL-64280 core_outcome: Add/remove outcome buttons style. 2018-12-10 17:56:03 +01:00
Michael Aherne
83c4b6d01e MDL-64216 privacy: Split query to use indexes. 2018-12-04 15:07:40 +00:00
Adrian Greeve
fa2a738f80 MDL-64161 gradereport_singleview: Single updates reported correctly.
If there is an error with the update of individual entries this is
also correctly displayed as not being updated.
2018-11-27 15:04:27 +08:00
Adrian Greeve
b87ad367d9 MDL-64161 gradereport_singleview: Behat test for out of bounds grade. 2018-11-26 11:46:06 +08:00
Adrian Greeve
27cfbf2986 MDL-64161 gradereport_singleview: Stop updating grades with errors. 2018-11-26 11:45:55 +08:00
Jun Pataleta
e92bb861d4 MDL-63571 grade_report_grader: Use correct context for capability check 2018-11-22 16:20:22 +08:00
Jun Pataleta
83a6d7a194 MDL-63571 grade_report_grader: Set correct type for the context variable 2018-11-22 16:20:22 +08:00
Peter
810bb4bef5 MDL-63571 gradebook: Display the name header based on config setting 2018-11-20 14:16:09 +08:00
Luca Bösch
b6f83c07ed MDL-63571 grades: switch firstname/lastname order in title row 2018-11-20 14:16:09 +08:00
Adrian Greeve
841a0bc6e2 MDL-64005 gradebook: Fix to remove debugging message.
The progress bar is being used when there are a large amount
of grades being recalculated. This was throwing a debugging message
about NO_OUTPUT_BUFFERING being unset.
2018-11-14 12:42:30 +08:00
Andrew Nicols
a07e8d7023 MDL-63924 privacy: Add shared user providers to subsytsems 2018-11-08 21:27:22 +08:00
Jun Pataleta
f5cf23270a MDL-63711 core_grade: Use canonicalize for checking userlist IDs 2018-11-06 14:16:57 +08:00
David Monllao
ad6b515ab6 Merge branch 'MDL-63711-35' of git://github.com/abgreeve/moodle into MOODLE_35_STABLE 2018-11-05 16:36:05 +01:00
Adrian Greeve
52efa6a2f0 MDL-63711 core_grades: Delete data for specified users in a context. 2018-11-03 02:59:58 +08:00
Michael Hawkins
a25222e9c4 MDL-63816 privacy: Corrected provider get_users_in_context descriptions 2018-10-31 12:14:43 +08:00
Adrian Greeve
07c7af673b MDL-63622 core_grading: Add support for removal of context users.
Core grading now implements the new core_userlist_provider
interface to allow for deletion of specific users in a context.
2018-10-29 11:22:04 +08:00
Adrian Greeve
5704b265ab MDL-63267 grading methods: Unit test update for fix. 2018-10-26 18:31:31 -04:00
Adrian Greeve
a5915ed4fc MDL-63267 grading methods: Fix for multiple intances.
We were only exporting the one instance per item id.
Instead we should have been exporting all instances for each
item id.
2018-10-26 18:31:11 -04:00
Adrian Greeve
e6d622106c MDL-63267 core_grading: Unit test for new methods. 2018-10-26 18:26:07 -04:00
Adrian Greeve
fa92fcbe15 MDL-63267 core_grading: Update to providers and interface.
The previous interface was inadequate for retrieving user
information stored in the sub-plugins.

A new interface and methods have been added to successfully
deal with user data.
2018-10-26 18:24:49 -04:00
Damyon Wiese
eaf9da10ad MDL-63765 behat: Fix behat tests opening a menu
If javascript is disabled, we don't need to open the menus at all. If it is enabled
we should use the custom step where possible.

In some tests (user profile) we have to use link_or_button because
the element that opens the menu will be a link or a button in different themes.
2018-10-26 16:12:00 +08:00
Luca Bösch
aae67cd6dd MDL-63435 gradebook: let activity icons re-appear. 2018-09-27 18:17:50 +02:00
Jake Dallimore
d01d3d8eef MDL-36255 core_grade: fix to ensure correct context used for filters
Some grade object (outcomes,scales) can be created at site or course
context, so this patch just makes sure we use the respective context
when applying format_string to the name in the get_name() function.
2018-08-22 17:57:24 +08:00
Luca Bösch
1b052996ff MDL-36255 grades: allow multilang filters in grades 2018-08-20 08:33:18 +02:00
Adrian Perez
10dae695ec MDL-63002 core_grade: fixed deletion of overriden letters 2018-07-30 21:00:24 +08:00
Eloy Lafuente (stronk7)
5d8821ae05 MDL-62478 upgrade: add 3.5.0 separation line to all upgrade scripts 2018-05-28 13:16:21 +02:00
Frédéric Massart
554e6a6562 MDL-62147 core_grades: Report contexts and data related to scales 2018-05-16 13:57:26 +08:00
Marina Glancy
372ea5502c MDL-62147 core_grades: Declare metadata of scales and import tables 2018-05-16 13:57:25 +08:00
Eloy Lafuente (stronk7)
4f510bea17 Merge branch 'MDL-62384-master' of git://github.com/andrewnicols/moodle 2018-05-11 18:12:45 +02:00
David Monllao
28e06c2a17 Merge branch 'MDL-61858_master' of git://github.com/markn86/moodle 2018-05-11 18:06:50 +02:00
Mark Nelson
61496b764a MDL-61858 gradingform_guide: added missing metadata implementation 2018-05-11 19:37:48 +08:00
Eloy Lafuente (stronk7)
3d8c0fb776 Merge branch 'MDL-61951-master' of git://github.com/sarjona/moodle 2018-05-11 13:21:58 +02:00
Sara Arjona
5e08a28f9b MDL-61951 core_grading: Review SQL to avoid Oracle errors 2018-05-11 12:59:19 +02:00
Jake Dallimore
b3252ecdc1 MDL-61951 core_grading: SQL improvements for grading_instance join 2018-05-11 10:19:11 +08:00
Jake Dallimore
6f213a2fa2 Merge branch 'MDL-61951-master' of git://github.com/sarjona/moodle 2018-05-11 10:18:58 +08:00
Andrew Nicols
a339908497 MDL-62384 core_grade: Move WHERE clause to JOIN 2018-05-11 09:15:30 +08:00
Jake Dallimore
7feac02414 MDL-61951 core_grading: Several fixes to the privacy implementation
- Fixed legacy polyfill method definitions
- Added unit test for legacy polyfill
- Fixed delete_gradingform_for_userid in gradingform provider
2018-05-10 13:26:47 +02:00