Commit graph

1740 commits

Author SHA1 Message Date
skodak
d52d5a8e85 merged from MOODLE_14_STABLE; updated parameter cleaning, preparation for new file.php SC#5 2004-11-19 21:28:29 +00:00
moodler
75169b06c4 FIxed the call to forum_add_user that was breaking student enrollment 2004-11-18 06:40:11 +00:00
moodler
1734f08ea4 In execute_sql, if feedback is not required then don't even show the
ADOdb feedback.  Makes those careful DROPs look less frightening!  :-)
2004-11-18 03:36:52 +00:00
mjollnir_
275c630a4a Replaced prefix_ with CFG->prefix for DROP of indexes before creation because of being inside execute_sql rather than modify_database - main tables 2004-11-18 02:55:33 +00:00
martinlanghoff
bce7197321 Merged from MOODLE_14_STABLE moodle--eduforge--1.3.3--patch-335 Now memory_limit can be overriden by higher config settings from php.ini, commandline, httpd.conf, .htaccess 2004-11-18 02:55:06 +00:00
martinlanghoff
2b49ae96a6 Merged from MOODLE_14_STABLE moodle--eduforge--1.3.3--patch-305 - Postgres SQL bugfix for instance_is_visible() 2004-11-18 02:37:52 +00:00
martinlanghoff
6315b1c8b6 Merged from MOODLE_14_STABLE moodle--eduforge--1.3.3--patch-222 - SQL improvements\n Better SQL performance for get_courses() and get_courses_page() calls, specially from the categories page. This gives much better performance when browsing existing courses 2004-11-18 02:31:53 +00:00
mjollnir_
ffa5f71b4b Merged from MOODLE_14_STABLE:
Add a unique key to guarantee that course,sortorder is unique. Allows fix_course_sortorder and ordering operations to be much faster. (martinlanghoff)

Plus more indexes for user table (mjollnir_)

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-231
arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-236
2004-11-17 07:47:03 +00:00
mjollnir_
17f3e7d05b Merge from MOODLE_14_STABLE: Indexes on faux foreign keys and often used fields, one more set and version bump to come. 2004-11-17 07:09:08 +00:00
mjollnir_
ba87a4daf5 Merged from MOODLE_14_STABLE:
Fixes to fix_course_sortorder() and course/category.php pages. (martinlanghoff)

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-160
  Minor fix: moodle would crash on high number of courses when doing course creation -- should be more scalable now

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-164
Fix a bug I have introduced in fix_course_sortorder() - v2

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-210
  Fixed nested transaction in fix_course_sortorder()

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-215
  Performance and memory usage fixes for re-sort courses function

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-268
  Major performance and correctness improvements in the functions that move courses up and down, reorder by name, and in fix_course_sortorder(). All now assume course-sortorder is unique (this is enforced at the DB)

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-332
  fix_coursesortorder() bugfixes and logic simplification

arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-333
  courses listing enhancements: bugfix on re-ordering, keep the right page on actions
2004-11-17 06:57:28 +00:00
mjollnir_
1ed5abc877 Merge from MOODLE_14_STABLE: moodle--eduforge--1.3.3--patch-207(partial) + moodle--eduforge--1.3.3--patch-408 - added begin_sql() and commit_sql() (martinlanghoff) 2004-11-17 05:31:21 +00:00
moodler
bb043e3843 Fixing up any references to obsolete language pack ma_nt 2004-11-15 09:34:04 +00:00
defacer
6b853ff4c7 Oops... fix for the fix :-) 2004-11-12 18:47:39 +00:00
defacer
5715e97bce Fixed a warning which appears if you move a block to a
position which doesn't currently have any blocks.
2004-11-12 18:44:54 +00:00
defacer
c8e0b57900 Pages/blocks code updates:
NEW: The code now supports dynamically plugging your own Pages and block position
identifiers into Moodle without messing with the main libraries at all.

UPDATE: Many functions in blocklib now use pass-by-reference for speed.

UPDATE: Class MoodlePage has been made more presentable and robust.
2004-11-12 18:39:25 +00:00
dhawes
e0134f842c added comments and some spacing cleanup 2004-11-10 16:43:57 +00:00
defacer
f032aa7a5f MAJOR CHANGES:
--------------

Brand-new pagelib.php at your disposal! It slices, it dices, it makes your coffee.
It still doesn't understand women... Read the comments in pagelib.php for a first
impression. Feedback highly encouraged!

Blocks code has undergone significant changes to work with Pages. Flexibility is its
middle name, since I think (without having tried it) that adding e.g. a third
placeholder for "center" blocks in courses, with full support for moving around etc,
will now take about 15 lines of new or edited code. If you are not impressed yet, I
suggest watching a documentary on solar physics. :P

MINOR CHANGES:
--------------

Added instance_allow_config() in the blocks class hierarchy to supplement per-instance
configuration options. You can override it to return true and thus get configuration
amenities without allowing multiple instances.

Minor polishing to comments and documentation (whatever caught my eye was game).

Tightened up some code here and there by utilizing all the new features.

BUGFIXES:
---------

A bug in restore_execute.html caused hidden blocks to not be restored at all.
2004-11-08 19:36:07 +00:00
moodler
80711843ef Copied from stable 2004-11-04 16:58:30 +00:00
moodler
379c6084bd Added sesskey to some buttons 2004-11-04 16:58:00 +00:00
moodler
9b74055f4b Merged pathinfo fix from stable 2004-11-04 07:00:12 +00:00
moodler
d491049d2e Merged from stable 2004-11-03 02:02:15 +00:00
gustav_delius
cdef00de3e Merged from STABLE. Fixed a bug that allowed teachers to upload images of arbitrary size 2004-10-30 22:51:12 +00:00
defacer
21fca825f2 Merging Martin's removal of the <style> allowed tag to HEAD. I tagged the
other version as MERGED, too.
2004-10-29 17:17:57 +00:00
defacer
89a5baaba1 Major cleanups (removed things no longer used by the new backup).
Microsoft must surely be jealous (do more with less).

Fixed a bug: if somehow the block weights in a page become discontinuous,
moving things up and down will slowly improve the situation until it's back
to normal again. It would just fail without notice before.

Fixed a bug: you could add multiple instances from a block that didn't
allow it if, after adding the first, you just hit Refresh in your browser.

Fixed a typo: missing / inside filepath
2004-10-29 16:56:59 +00:00
gustav_delius
2f3b54ae54 Put back call to forum_add_student in enrol_student() that Martin took out by mistake in revision 1.355 2004-10-26 19:53:48 +00:00
moodler
20b57d6aac Fixed minor JS bug in printing out editor configuration 2004-10-26 08:43:41 +00:00
moodler
2a003a903c Changes in the way optgroups are handled for XHTML compatibility 2004-10-26 07:42:08 +00:00
moodler
ccc62c6e42 Fixed typo ... bug 2124 2004-10-25 15:25:58 +00:00
dhawes
a9c75a9caf fix to allow instance configuration for blocks that allow multiple but have been set by the local admin to only display one instance per page 2004-10-25 03:20:02 +00:00
dhawes
27ec21a0f6 some quote cleanup and some spacing added 2004-10-24 15:51:25 +00:00
paca70
40869b2ead Prevent errors if lang/$lang/moodle.lib does not exists 2004-10-22 11:14:42 +00:00
defacer
9b4b78fd6a Da monster-commit of blocks version 2!
Code based on the work of Daryl Hawes for the blog module. Thanks, Daryl!

Please test the hell out of it as it's sure to have issues that need to be
ironed out.
2004-10-19 21:04:28 +00:00
moodler
169fc66a15 Merged small speed improvements from STABLE 2004-10-18 06:00:26 +00:00
stronk7
76e2bc3b77 Strip control chars when unzipping.
Merged from MOODLE_14_STABLE
2004-10-17 23:44:16 +00:00
stronk7
261dac37a6 Now Editor's FileManager is using central zip and unzip functions.
NOTE: What is the courseimages.php file, I haven't tested it because
I didn't find how to do it!

Merged from MOODLE_14_STABLE
2004-10-17 23:11:14 +00:00
stronk7
a095707760 Small change in condition...
Merged from MOODLE_14_STABLE
2004-10-17 22:36:03 +00:00
stronk7
1c1520c5bb Included some filename transformations to work like info-zip.
Directory traversal protection added.

Working under Win32, MacOS X and BSD (and rest of Unix, I hope).

Patch file from Petr. Thanks!

Merger from MOODLE_14_STABLE
2004-10-17 22:28:53 +00:00
stronk7
e941292002 Now pclzip generated files are compatible with info-zip
(linux, macos x, win32, bsd...) based extractors. This
include command-line flavours, stuffit and so on...

Thanks to Petr!!

We have to remember to apply this patch when we update the
pclzip in th future (if their authors don't include it).

Merged from MOODLE_14_STABLE
2004-10-17 13:36:13 +00:00
stronk7
8d67a044b7 Added the optional showstatus parameter to unzip_file() to avoid
sending any output if desired.

Merged from MOODLE_14_STABLE
2004-10-16 16:33:40 +00:00
stronk7
7e6b7f8da2 Latest patches from skodak included in param functions.
Simple and double quotes are out now.
Full paths in unzip are now hidden too.

Please test it. It could have some pending changes yet!

And please, don't forget to move the floating tag in STABLE
when changes are done there!! It causes a lot of problems
when trying to merge later from STABLE to HEAD again.

Merged from MOODLE_14_STABLE.
2004-10-16 11:39:52 +00:00
julmis
955dbfaeef Adding hide buttons feature. 2004-10-16 09:11:00 +00:00
moodler
53f39b328c Merged prettier error from stable 2004-10-15 08:47:12 +00:00
paca70
f894a7914a auth_iscreator return now three posible values:
null = not supported (Dont change user status)
false =  user not creator
true = user is creator
2004-10-13 07:16:24 +00:00
skodak
bfce67a179 merged from 14_STABLE, the merging is getting a bit messy :-O
added sesskey to update_module_button(), error reported in moodle forum d=13835;
I made a quick fix - it seemed critical to me
2004-10-12 18:47:39 +00:00
stronk7
76dc1ad2cf Under Win32, we need backslashes in paths. Now it works!!
Merged from MOODLE_14_STABLE
2004-10-10 23:25:57 +00:00
stronk7
6cf2fe0336 Added some needed strings.
Merged from MOODLE_14_STABLE
2004-10-10 22:48:59 +00:00
stronk7
48eeac7963 Delete some debug info.
Merged from MOODLE_14_STABLE
2004-10-10 22:00:30 +00:00
stronk7
b3020784d6 Central unzip_file() function included:
- Supports both internal and external zip execution.
    - Displays the results of the execution.
    - All Petr's patched added.
    - External zip execution in Win32 supported.
Please TEST, TEST, TEST.

Merged from MOODLE_14_STABLE
2004-10-10 21:46:13 +00:00
stronk7
ef1e97c7ec Now the zip_files() function is working better:
- More checks are done
- Non existing files are out
- Both internal an external are supported and protected
- All Petr's patchs applied
- Included support to Win32 external zip.

TODO: Create a paralel unzip_file() function
      Use this functions in all the FileManager scripts

THOUGHT: External zip seems to work always adding files to
      zip file if it exists, where PclZip resets the file.
      Perhaps a rm (or delete) should be included in the
      command chain. Analyse it!!

Merged from MOODLE_14_STABLE
2004-10-10 01:07:47 +00:00
stronk7
5b224948aa course/view.php is using sesskey
(changes in blocks done, please check them)

Merged from MOODLE_14_STABLE
2004-10-09 20:16:05 +00:00