moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
104502 commits 37 branches 540 tags 1.3 GiB
Commit graph

165 commits

Author SHA1 Message Date
Jake Dallimore
1fa04d2e06 Merge branch 'MDL-73180' of git://github.com/paulholden/moodle 2022-01-24 10:37:53 +08:00
Paul Holden
628541b5e1 MDL-73493 reportbuilder: correct handling of empty string in filters. 
This is specifically for Oracle, which treats empty strings and NULL
in an inconsistent manner unless passed as query parameters. Increase
test coverage of the same.

Co-authored-by: Carlos Castillo <carlos.castillo@moodle.com>
 2022-01-21 15:43:01 +00:00
Mikel Martín
eb65298bcd MDL-73166 core_reportbuilder: Fix action links accessibility 2022-01-20 09:48:29 +01:00
Paul Holden
335012580b MDL-73598 reportbuilder: feature switch for custom reports. 2022-01-19 23:20:52 +00:00
Carlos Castillo
3d8620854a MDL-73493 reportbuilder: Consider users without profile field defined 
Include users who haven't defined text/checkbox custom profile field
in filter operators: 'Is not empty', 'Does not contain' and 'Is not equal to'.
 2022-01-19 08:47:26 -05:00
Paul Holden
a844d885b2 MDL-73180 reportbuilder: improve relative date filter definitions. 
Changes since the original implementation in e55abd71 mean that
relative date filtering (by last/next day/week, etc) is now based
on the actual current time, rather than the start or end of the
current time unit.
 2022-01-19 08:22:03 +00:00
Ilya Tregubov
c10cf765d0 Merge branch 'MDL-73495-master' of https://github.com/dravek/moodle 2022-01-17 09:14:48 +02:00
Shamim Rezaie
c4706a93ea Merge branch 'MDL-72757-master' of https://github.com/dravek/moodle 2022-01-13 18:29:28 +11:00
Jun Pataleta
8b73145310 Merge branch 'MDL-73467' of git://github.com/paulholden/moodle 2022-01-13 11:43:32 +08:00
Paul Holden
b625b9ffed MDL-73467 reportbuilder: consistent scheduled report export class. 
Use the same dataformat exporter in scheduled reports as that used
when downloading reports, from 7d753bed.
 2022-01-12 17:41:41 +00:00
Mikel Martín
142277dfcb MDL-73469 reportbuilder: Fix clipped corners 
- Fix clipped corners in toggle cards
- Fix left corners in left sidebar search input
 2022-01-12 15:27:48 +01:00
Paul Holden
ee566b88a8 MDL-72757 reportbuilder: improve model event tests. 
Remove some boilerplate/duplication in the current test methods
using @depends annotation to pass persistents between them.
 2022-01-10 17:21:23 +01:00
David Matamoros
c6bf7d791e MDL-73495 reportbuilder: Fix generation of dynamic tabs 2022-01-05 13:16:13 +01:00
David Matamoros
39b90208e1 MDL-72757 reportbuilder: Events for CRUD operations on report models 2022-01-05 09:55:36 +01:00
Paul Holden
98e7d99720 MDL-73468 reportbuilder: observe configured sorting when editing. 
Users preferred sorting (via clicking on column headers) should only
take effect when pre/viewing the report, not when editing it.
 2021-12-30 11:35:07 +00:00
Jun Pataleta
80c17cd2a0 Merge branch 'MDL-72701-master' of https://github.com/andrewnicols/moodle 2021-12-23 12:10:46 +08:00
Sara Arjona
3946c78c2e Merge branch 'MDL-73275' of https://github.com/paulholden/moodle 2021-12-22 15:40:43 +01:00
Paul Holden
335f608abb MDL-72598 reportbuilder: tasks and API for report schedule delivery. 2021-12-21 09:44:43 +00:00
Paul Holden
a05683d027 MDL-72598 reportbuilder: interface elements for creating schedules. 
Add new tab to the report editor, with system report, external API
and Javascript modules for managing report schedules.
 2021-12-21 08:57:17 +00:00
Andrew Nicols
3a70983d53 MDL-72701 unit tests: Generate default coverage 2021-12-21 09:24:00 +08:00
Paul Holden
d064a93d29 MDL-72598 reportbuilder: elements to allow audiences to be renamed. 
This allows the user to give the audience more context, particularly
when they are used for selection on the forthcoming schedule form
editing.
 2021-12-17 14:33:27 +00:00
Paul Holden
eb460d93aa MDL-72598 reportbuilder: schema and model updates for schedules. 2021-12-17 14:33:27 +00:00
Víctor Déniz
3eafc7a1bc Merge branch 'MDL-73280' of git://github.com/paulholden/moodle 2021-12-13 18:44:10 +00:00
Ilya Tregubov
6f44f008d8 Merge branch 'MDL-73278' of https://github.com/stronk7/moodle 2021-12-10 18:51:40 +02:00
Paul Holden
8bed417833 MDL-73280 reportbuilder: format checkbox profile fields correctly. 2021-12-09 14:09:44 +00:00
Paul Holden
805b9521fc MDL-73280 reportbuilder: remove profile field column alias. 
It's not required, and also could cause issues for fields that
contained differing casing in their shortname.

Co-authored-by: David Matamoros <davidmc@moodle.com>
 2021-12-09 12:42:40 +00:00
Eloy Lafuente (stronk7)
deb0e76eee MDL-73278 phpunit: Rename already namespaced classes to match file name 
These are the only cases 100% safe to apply the renaming of the
testcase class names to match the file names.

All other cases are not safe, because they are missing namespace
and may enter into name conflicts. Adding namespaces is not as
simple as imagined because it implies to, also, add a good number
of modifications to core. See the issue for more details.
 2021-12-07 23:54:29 +01:00
Paul Holden
7d753bed0b MDL-73275 reportbuilder: dataformat exporter for downloading. 
If the current dataformat doesn't support HTML then clean the text
and remove all tags.
 2021-12-06 10:41:29 +00:00
Paul Holden
b103060753 MDL-73103 reportbuilder: use new notification confirmation method. 
Prefetch all language strings used by editor modules.

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
 2021-12-03 13:01:58 +00:00
Jun Pataleta
f95cc84aa5 Merge branch 'MDL-72770' of https://github.com/roland04/moodle 2021-12-02 11:08:50 +08:00
Mikel Martín
6a6ebbac63 MDL-72770 reportbuilder: Display editor in full screen layout 
- use 'popup' layout in editor page and create a custom navbar
- remove 'Settings' toggle button and show settings right sidebar with fixed position
- add 'Edit details' button on navbar that opens a modal to modify report basic settings
 2021-12-01 17:12:45 +01:00
Paul Holden
171c615a1b MDL-73149 reportbuilder: update sorting options after aggregation. 
Aggregation types can disable column sorting, e.g. both the current
group concatenation types. If such a type is selected for a column
we should update the report sorting options, ensuring that only those
columns that can be sorted are available for selection.
 2021-12-01 09:12:07 +00:00
Jun Pataleta
3ae9f4cac3 Merge branch 'MDL-72822' of https://github.com/roland04/moodle 2021-12-01 11:27:06 +08:00
Eloy Lafuente (stronk7)
cee0949109 Merge branch 'MDL-73074' of https://github.com/paulholden/moodle 2021-11-29 23:14:48 +01:00
Mikel Martín
08d31c6657 MDL-72822 core_reportbuilder: Fix focus lost after applying changes 
- Fix focus after adding conditions in the editor
- Fix focus after adding Filters in the editor
- Fix focus after applying sorting settings in editor
- Fix focus after selecting column aggregation in editor
 2021-11-24 13:13:08 +01:00
Mikel Martín
8e25d534b4 MDL-72822 core_reportbuilder: Accessibility improvements 
- Add sr-only headings to tabs
- Change role to 'presentation' in tab <li> elements
- Remove unnecessary aria-labelledby
- Fix heading levels
- Avoid duplicated IDs in audiences
- Replace empty links with buttons
- Fix mustache comments
- Fix mustache contexts
 2021-11-24 10:26:14 +01:00
Andrew Nicols
eab5f3cfb2 Merge branch 'MDL-73069' of https://github.com/paulholden/moodle 2021-11-23 10:52:11 +08:00
Sara Arjona
be78cb02f2 Merge branch 'MDL-73129-master' of https://github.com/dravek/moodle 2021-11-23 10:52:11 +08:00
David Matamoros
6d1a7a8283 MDL-73129 reportbuilder: Remove string with trailing whitespace 2021-11-22 10:30:10 +01:00
Paul Holden
faeecd79ea MDL-73074 reportbuilder: consistent lang strings in course filter. 2021-11-22 09:20:04 +00:00
Paul Holden
881dccaa7d MDL-73069 reportbuilder: filter/condition for selecting user. 
This allows a report creator to create personalised reports
according to the user who is viewing the report.
 2021-11-22 09:17:52 +00:00
Paul Holden
f4bf4dca36 MDL-73112 reportbuilder: improve handling of concatenated columns. 
This change overcomes limitations in certain DB engines (such as
MySQL[1]) which can lead to truncation of data when applying group
concatenation to columns.

Ensure we account for that by validating that we are able to extract
the expected number of fields from each concatenated value.

[1] https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_group_concat_max_len
 2021-11-22 09:14:41 +00:00
Jun Pataleta
357ddcaff6 Merge branch 'MDL-72826' of git://github.com/paulholden/moodle 2021-11-19 11:07:03 +08:00
Paul Holden
80dd297a62 MDL-73090 reportbuilder: confirmation before resetting conditions. 
Also prefetch all lang strings used by conditions editor.
 2021-11-17 16:27:50 +00:00
Paul Holden
be11216d30 MDL-72826 reportbuilder: per-report option to show only unique rows. 
This option allows report creators to avoid duplicate data being
displayed in their report. It is applied only when no columns in the
report currently have aggregation methods applied.
 2021-11-16 13:59:16 +00:00
Paul Holden
c0ceaef772 MDL-73011 reportbuilder: remove workarounds for tab switching. 2021-11-11 23:54:56 +00:00
Mikel Martín
68eb55b8e6 MDL-72565 reportbuilder: Add card view functionality 
Use card view settings to show a 'card view' for custom reports in small devices
 2021-11-11 13:55:32 +01:00
Mikel Martín
aaa7a5a445 MDL-72565 reportbuilder: Add 'Card view' settings to custom reports 
- Create a new 'settings' column in reportbuilder_report table and provide an API to manage it
- Add new card view settings to custom reports
 2021-11-11 13:55:29 +01:00
Mikel Martín
f2582cc823 MDL-72565 reportbuilder: Use same template for system/custom reports 
- rename 'system_report' template to 'report'
- view.php now uses 'report' template

Co-authored-by: Paul Holden <paulh@moodle.com>
 2021-11-11 13:44:23 +01:00
Shamim Rezaie
d038fd822d Merge branch 'MDL-72952' of https://github.com/roland04/moodle 2021-11-11 10:38:26 +11:00