Commit graph

27680 commits

Author SHA1 Message Date
Andrew Nicols
6d5d1935ea MDL-67657 behat: Add wrapper for JS execution 2020-07-16 11:05:32 +08:00
Andrew Nicols
05f23d5a2b MDL-69278 behat: Correct variable name 2020-07-16 08:29:22 +08:00
Andrew Nicols
0d751c196b MDL-69278 behat: Mark tests as failed when unable to start Session 2020-07-16 08:29:22 +08:00
Andrew Nicols
6f5f08a846 MDL-69215 output: Correct use of icon_system::instance 2020-07-16 07:29:22 +08:00
Andrew Nicols
4a4a367251 MDL-69215 output: Correct font awesome for themes 2020-07-16 07:29:22 +08:00
Sara Arjona
23f33d12ca Merge branch 'MDL-57678-master-3' of git://github.com/junpataleta/moodle 2020-07-15 12:56:02 +02:00
Brendan Heywood
ef4145dd1a MDL-68874 dml: Add SQL stacktrace debugging mode 2020-07-15 20:32:43 +10:00
Jun Pataleta
4c44813e9e MDL-57678 admin: Replace usage of make_categories_options()
Replace with core_course_category::make_categories_list() instead.
2020-07-15 18:26:03 +08:00
Jun Pataleta
2c45ad6f18 MDL-57678 core_course: Deprecate make_categories_options()
Padding nested course categories by space to make them render in a tree
structure does not really make a lot of sense as they are already being
rendered as full paths. It's simpler to show them without the
indentation.
Given this, there's not much point keeping make_categories_options().
So it's better to deprecate this function and call
core_course_category::make_categories_list() directly instead.
2020-07-15 18:25:57 +08:00
Sara Arjona
9f9682cfe2 Merge branch 'MDL-69068-master' of git://github.com/andrewnicols/moodle 2020-07-15 12:20:20 +02:00
Andrew Nicols
b49cb92e82 MDL-69068 behat: New step to support singular generators 2020-07-15 15:27:31 +08:00
Andrew Nicols
eb06f92457 MDL-68390 core: Share focusable selector 2020-07-15 15:15:34 +08:00
Andrew Nicols
7cc18dc2ad MDL-68390 js: Update to use Aria mod 2020-07-15 14:40:49 +08:00
Andrew Nicols
4f1c8ce764 MDL-68390 aria: Add new core_aria module 2020-07-15 14:40:49 +08:00
Paul Holden
8acaa4e356 MDL-68715 completion: fix form default value for course prerequisites.
Adds filtering on the completion criteria form to ensure we are only
selecting actual course instances of this type. Prior to this change
we would also get NULL values from unrelated criteria types.
2020-07-14 12:46:02 +01:00
Andrew Nicols
2c37677635 MDL-69160 behat: Add form field setter step 2020-07-13 14:22:31 +08:00
Leon Stringer
69f0ecf605 MDL-69252 templates: Invalid HTML
Invalid HTML generated when the page count exceeded the maximum number
of page links to display: <span>...</a>.  Also added example context.
2020-07-11 12:51:02 +01:00
Jake Dallimore
0ad85f4148 Merge branch 'MDL-69232-master' of git://github.com/andrewnicols/moodle 2020-07-10 15:12:44 +08:00
Andrew Nicols
4df5ee039a MDL-69232 behat: Simplify hooks
The behat hooks were needlessly complicated which made them much harder
to read, and understand, leading to bugs during development.

These have been significantly simplified to favour clarity over
overloading.
2020-07-10 08:40:30 +08:00
Andrew Nicols
5306f2f2b9 MDL-69232 behat: Make selenium start more fault tolerant
The session was previously only started once, but has now been moved to
restart between each test. Because of this the `$session->start()` is
now called more frequently which exposes a pre-existing issue whereby
Selenium will periodically fail to start.

When the session was only started at the beginning of the test, and at
occasional other times, it made sense to always stop the test runner
because it signified an issue with obtaining the session at all.

Since the session is restarted more frequently, and now between every
test, it no longer makes sense to do this. The test should only be
_stopped_ if the first attempt to obtain the Session fails. Once a
Session has been retrieved at least once it no longer makes sense to
assume that the failure was a configuration failure, but a connection
failure. Therefore subsequent tests should be attempted.
2020-07-10 08:40:30 +08:00
Andrew Nicols
5e99058860 MDL-69232 behat: Add debugging information to Selenium fails 2020-07-09 09:30:15 +08:00
Andrew Nicols
41426e0aa4 MDL-69232 behat: Move suite tests to BeforeSuite hook 2020-07-09 09:27:11 +08:00
Jake Dallimore
389744710a Merge branch 'MDL-62982-master' of git://github.com/mihailges/moodle 2020-07-09 09:07:49 +08:00
Jake Dallimore
848f08e126 Merge branch 'MDL-67477-master' of git://github.com/mihailges/moodle 2020-07-09 08:38:18 +08:00
Jake Dallimore
7a40781aeb Merge branch 'MDL-56041-custom-error-pages' of https://github.com/brendanheywood/moodle 2020-07-08 09:33:46 +08:00
Andrew Nicols
145604590f Merge branch 'MDL-69109-master-2' of git://github.com/marinaglancy/moodle 2020-07-08 08:39:32 +08:00
Brendan Heywood
43999a3f2b MDL-56041 error: Enable custom 404 and 500 error pages 2020-07-08 09:36:21 +10:00
Eloy Lafuente (stronk7)
3303daf3bf Merge branch 'm40_MDL-68588_Hide_Backuptempdir_From_Message_And_Debuginfo' of https://github.com/scara/moodle 2020-07-07 19:09:59 +02:00
Jake Dallimore
3d7a8a09ba Merge branch 'MDL-63966' of https://github.com/Chocolate-lightning/moodle 2020-07-07 13:54:27 +08:00
Andrew Nicols
3bf4744303 Merge branch 'MDL-67594-master-2' of git://github.com/mihailges/moodle 2020-07-07 09:32:20 +08:00
Andrew Nicols
a95f458cde MDL-69110 table: Remove commented code 2020-07-06 13:25:31 +08:00
Andrew Nicols
1ffdc39468 Merge branch 'MDL-69110-master' of git://github.com/junpataleta/moodle 2020-07-06 13:16:38 +08:00
Mihail Geshoski
83c18a2dec MDL-67594 core_lock: Modify postgres get_lock() to avoid recursion 2020-07-06 13:04:41 +08:00
Mihail Geshoski
566b73fbfc MDL-67594 core_lock: Deprecate extend() 2020-07-06 13:04:33 +08:00
Mihail Geshoski
80736a93aa MDL-67594 core_lock: Deprecate extend_lock() 2020-07-06 13:03:08 +08:00
Mihail Geshoski
41bc63dbf3 MDL-67594 core_lock: Remove supports_recursion() usages 2020-07-06 13:01:20 +08:00
Mihail Geshoski
4b71cdcd89 MDL-67594 core_lock: Deprecate supports_recursion() 2020-07-06 13:01:16 +08:00
Andrew Nicols
e4faf5fede Merge branch 'MDL-68820-referrer-policy' of https://github.com/Peterburnett/moodle 2020-07-06 12:38:29 +08:00
Jake Dallimore
71bfe91591 Merge branch 'MDL-55192-master' of git://github.com/peterRd/moodle 2020-07-06 12:10:02 +08:00
Jake Dallimore
68e240284c Merge branch 'MDL-63004' of https://github.com/Chocolate-lightning/moodle 2020-07-06 11:55:12 +08:00
John Okely
d464fb43d6 MDL-55192 log: Final deprecation of add_to_log 2020-07-06 11:54:10 +08:00
Mathew May
d0ba284421 MDL-63966 core: Remove tests covering removed functions 2020-07-06 11:44:04 +08:00
Mathew May
b27a27adcd MDL-63966 core: Final deprecations in deprecatedlib 2020-07-06 11:44:01 +08:00
Mathew May
f87f23777f MDL-63004 behat: Final removal of i_navigate_to_node_in 2020-07-06 11:39:13 +08:00
Jake Dallimore
6ceba9e0e8 Merge branch 'MDL-69136-master' of git://github.com/andrewnicols/moodle 2020-07-06 10:44:10 +08:00
Mihail Geshoski
8cdb2fcc0e MDL-62982 core_form: Final deprecation of the htmleditor form element 2020-07-06 10:02:58 +08:00
Mihail Geshoski
8efa87ed6f MDL-67477 lib: Remove renamed classes 2020-07-06 10:00:22 +08:00
Matteo Scaramuccia
82850a0418 MDL-68588 Backup: Hide ->backuptempdir in exception info 2020-07-03 21:17:42 +02:00
Jun Pataleta
b583c46297 MDL-69110 core: Unset the correct sort data element 2020-07-04 00:47:14 +08:00
Andrew Nicols
9eaf7a4c3f MDL-68714 clilib: Check set_process_title exists
The web cron script at /admin/cron.php pretends to be a CLI script which
means that it is not possible to rely upon the CLI_SCRIPT constant.
2020-07-03 09:49:11 +08:00