Commit graph

93685 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
0b9d7d93f8 MDL-65308 core: change a couple of unsafe preg_quote() cases
With PHP 7.3, the hash (#) is being escaped by preg_quote().

While normally that doesnt have much impact and normal operations
continue working perfectly... when the results of the function are
used to match against the same string... they don't match anymore.

Have found a couple of there double-uses in core and this
commit fixes them. Covered with tests.
2019-04-16 01:40:47 +02:00
Eloy Lafuente (stronk7)
f79881b8d0 Merge branch 'MDL-59298-master' of git://github.com/rezaies/moodle 2019-04-15 23:53:58 +02:00
Eloy Lafuente (stronk7)
f7e183e513 Merge branch 'MDL-64777-master-modelsrestore' of git://github.com/mudrd8mz/moodle 2019-04-15 23:37:43 +02:00
Eloy Lafuente (stronk7)
5fd5eaf766 Merge branch 'MDL-64786-master-renamemodels' of git://github.com/mudrd8mz/moodle 2019-04-15 22:53:55 +02:00
Eloy Lafuente (stronk7)
75cd6b9a08 Merge branch 'MDL-65307_master' of git://github.com/dmonllao/moodle 2019-04-15 20:43:13 +02:00
Eloy Lafuente (stronk7)
0c1944cd93 Merge branch 'MDL-60470' of https://github.com/brendanheywood/moodle 2019-04-15 20:26:17 +02:00
Sara Arjona
734b198fd3 MDL-64715 message: add support for self conversations
Added new MESSAGE_CONVERSATION_TYPE_SELF type for self-conversations
and upgraded legacy self-conversations to the new type, removing
repeated members in the message_conversation_members table.
Besides, from now, a self-conversation will be created by default for
all the existing users.

All the self-conversations have been also starred and a default message
will be displayed always to explain how to use them.
2019-04-15 20:17:54 +02:00
Brendan Heywood
bf9f255523 MDL-60470 core: New hook 'after_require_login'
This adds a hook towards the end of the require_login function.
2019-04-16 03:39:20 +10:00
Sara Arjona
fcd7f0f982 MDL-64715 message: add send-self-message button to the user profile
The "Send message" button is now also displayed from the current user
profile to let them access to their self-conversations.
2019-04-15 14:29:10 +02:00
Sara Arjona
2767426111 MDL-64715 message: avoid duplicate entries when searching messages 2019-04-15 14:29:10 +02:00
Sara Arjona
edb1ab3d17 Merge branch 'MDL-65328' of https://github.com/stronk7/moodle 2019-04-15 13:53:15 +02:00
Sara Arjona
8baa12ac38 Merge branch 'MDL-65281' of git://github.com/stronk7/moodle 2019-04-15 13:13:14 +02:00
David Monllaó
e034670fac Merge branch 'MDL-62572-master' of git://github.com/damyon/moodle 2019-04-15 11:04:54 +02:00
David Monllaó
7063b665e0 MDL-65248 core_course: Move analytics targets to course
MOV [coursealreadyfinished, moodle], [coursealreadyfinished, course]
MOV [coursenotyetstarted, moodle], [coursenotyetstarted, course]
MOV [coursenotyetfinished, moodle], [coursenotyetfinished, course]
MOV [nocourseactivity, moodle], [nocourseactivity, course]
MOV [nocourseendtime, moodle], [nocourseendtime, course]
MOV [nocoursesections, moodle], [nocoursesections, course]
MOV [nocoursestudents, moodle], [nocoursestudents, course]
MOV [studentsatriskincourse, moodle], [studentsatriskincourse, course]
MOV [target:coursecompletion, moodle], [target:coursecompletion, course]
MOV [target:coursecompletion_help, moodle], [target:coursecompletion_help, course]
MOV [target:coursecompetencies, moodle], [target:coursecompetencies, course]
MOV [target:coursecompetencies_help, moodle], [target:coursecompetencies_help, course]
MOV [target:coursedropout, moodle], [target:coursedropout, course]
MOV [target:coursedropout_help, moodle], [target:coursedropout_help, course]
MOV [target:coursegradetopass, moodle], [target:coursegradetopass, course]
MOV [target:coursegradetopass_help, moodle], [target:coursegradetopass_help, course]
MOV [target:noteachingactivity, moodle], [target:noteachingactivity, course]
MOV [target:noteachingactivity_help, moodle], [target:noteachingactivity_help, course]
MOV [target:upcomingactivitiesdue, moodle], [target:upcomingactivitiesdue, course]
MOV [target:upcomingactivitiesdue_help, moodle], [target:upcomingactivitiesdue_help, course]
MOV [targetlabelstudentcompletionno, moodle], [targetlabelstudentcompletionno, course]
MOV [targetlabelstudentcompletionyes, moodle], [targetlabelstudentcompletionyes, course]
MOV [targetlabelstudentcompetenciesno, moodle], [targetlabelstudentcompetenciesno, course]
MOV [targetlabelstudentcompetenciesyes, moodle], [targetlabelstudentcompetenciesyes, course]
MOV [targetlabelstudentdropoutyes, moodle], [targetlabelstudentdropoutyes, course]
MOV [targetlabelstudentdropoutno, moodle], [targetlabelstudentdropoutno, course]
MOV [targetlabelstudentgradetopassno, moodle], [targetlabelstudentgradetopassno, course]
MOV [targetlabelstudentgradetopassyes, moodle], [targetlabelstudentgradetopassyes, course]
MOV [targetlabelteachingyes, moodle], [targetlabelteachingyes, course]
MOV [targetlabelteachingno, moodle], [targetlabelteachingno, course]
MOV [coursetoolong, analytics], [coursetoolong, course]
MOV [errorendbeforestart, analytics], [errorendbeforestart, course]
2019-04-15 09:45:50 +02:00
Mihail Geshoski
ee6b5ba343 MDL-65034 forum: Rename identifier to camel case 2019-04-15 14:51:03 +08:00
Ryan Wyllie
e564ae863d MDL-65034 forum: add aria keyboard nav to discussion 2019-04-15 14:51:03 +08:00
Ryan Wyllie
53d743741e MDL-65034 forum: add aria attributes to forum post 2019-04-15 14:51:03 +08:00
David Mudrák
7bd09a69ae MDL-64786 analytics: Make the list of indicators collapsed by default
The list may become very long and it does not help the usability of the
table. Similarly to what we have on the restore models page, we now have
the list of indicators collapsed by default.
2019-04-15 08:22:13 +02:00
David Mudrák
cfb5603e60 MDL-64786 analytics: Fix documentation of models_list template
The list of expected context variables was missing. The example context
was not correct, particularly the help icons are a single object, not a
list.
2019-04-15 08:22:13 +02:00
David Mudrák
066a4d6493 MDL-64786 analytics: Allow renaming models via inplace editable element 2019-04-15 08:22:13 +02:00
David Mudrák
6482734681 MDL-64786 analytics: Add a new name field to the models table 2019-04-15 08:22:13 +02:00
David Mudrák
ed47112e1b MDL-64786 analytics: Add missing parameter to model::export() method
All methods that export an object to be rendered via a template, must
have the instance of a renderer available.
2019-04-15 08:17:45 +02:00
David Mudrák
76ef6610bb MDL-64777 analytics: Add ability to restore missing default models
The patch introduces a new page restoredefault.php that allows the user
to select missing models to be restored.
2019-04-15 08:16:58 +02:00
David Mudrák
7dba0c27ad MDL-64777 analytics: Add method to get target and indicators instances
This will be needed in some other places, too.
2019-04-15 08:16:58 +02:00
David Mudrák
1297fa4156 MDL-64777 analytics: Add method to load all model definitions 2019-04-15 08:16:58 +02:00
David Mudrák
01d620ee67 MDL-64777 analytics: Add method for identifying a model declaration
This is intended to be used to as a declaration identifier in HTML or as
a HTTP parameter value.
2019-04-15 08:16:58 +02:00
David Monllaó
c4beecb66b Merge branch 'wip-MDL-65220-master' of https://github.com/jason-platts/moodle 2019-04-15 07:57:27 +02:00
David Monllaó
ce93b0f997 MDL-64855 version: Bump for the new setting 2019-04-15 07:51:24 +02:00
David Monllaó
a733fce3ac Merge branch 'MDL-64855-37_block_myoverview_course_category_display' of https://github.com/tomdickman/moodle 2019-04-15 07:50:45 +02:00
David Monllaó
f82701acad Merge branch 'MDL-59326' of https://github.com/paulholden/moodle 2019-04-15 07:47:33 +02:00
David Monllaó
72a70e37b5 Merge branch 'MDL-64894-master' of git://github.com/damyon/moodle 2019-04-15 07:45:04 +02:00
David Monllaó
815c070a26 Merge branch 'MDL-29317-master' of git://github.com/junpataleta/moodle 2019-04-15 07:41:10 +02:00
Eloy Lafuente (stronk7)
0163c6e449 Merge branch 'MDL-62907-master' of https://github.com/sammarshallou/moodle 2019-04-14 18:12:56 +02:00
Eloy Lafuente (stronk7)
50fe98de05 Merge branch 'MDL-65321-course-perf' of https://github.com/brendanheywood/moodle 2019-04-14 17:58:04 +02:00
Brendan Heywood
af368c1076 MDL-65321 backups: Only require minimal async backup libs if needed 2019-04-13 23:43:01 +10:00
Eloy Lafuente (stronk7)
c0b02e7118 MDL-65328 phpunit: make test immune to (lack of) ordering 2019-04-13 12:43:31 +02:00
Eloy Lafuente (stronk7)
89a81629a7 MDL-65281 phpunit: Just check for existence if order is not guaranteed
Posible solutions explained in the issue, imply chaging the API
in various, alternative ways. For your consideration if that
should be done for a better API, able to sort under demand when
required (or, at very least guaranteeing a default consistent ordering).
2019-04-13 11:38:39 +02:00
AMOS bot
d78a868216 Automatically generated installer lang files 2019-04-13 00:13:09 +00:00
Eloy Lafuente (stronk7)
bef0fe2000 on-demand release 3.7dev+ 2019-04-12 21:38:18 +02:00
Eloy Lafuente (stronk7)
c1634f3648 NOBUG: Fixed file access permissions 2019-04-12 21:38:18 +02:00
Eloy Lafuente (stronk7)
269789d0b9 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2019-04-12 21:38:15 +02:00
Eloy Lafuente (stronk7)
66b4982135 MDL-64656 phpunit: Compare returned tags without any expected order 2019-04-12 17:28:21 +02:00
Eloy Lafuente (stronk7)
51f8b2dc15 Merge branch 'MDL-39261-master' of https://github.com/sarjona/moodle 2019-04-12 13:28:56 +02:00
Sara Arjona
865d284410 MDL-39261 mod_lesson: get the existing attemptid when reviewing 2019-04-12 13:11:50 +02:00
Eloy Lafuente (stronk7)
3d915f5345 MDL-62907 Logging: remove plugin interdependencies
- Move decode_other() from standard to tool_log\helper\reader trait.
- Change all ocurrences to "use" the trait method. But a unit test.
- Duplicate the admin lang strings in database and use them.
- An incorrect phpdoc @package.
2019-04-12 10:49:19 +01:00
Sara Cenni
d78d97de8c MDL-64851 badge: reviewing badges of invisible courses 2019-04-12 09:50:33 +02:00
Damyon Wiese
04258a5a4e MDL-64894 theme_classic: Compile SCSS for classic 2019-04-12 14:16:28 +08:00
Damyon Wiese
f10c22b691 MDL-62572 backup: Duplicating an activity
Don't apply admin defaults for import when using the duplicate function.
2019-04-12 14:04:40 +08:00
Jake Dallimore
76e35e6bdd Merge branch 'MDL-62974-master' of github.com:abgreeve/moodle 2019-04-12 11:17:26 +08:00
Adrian Greeve
ac76ff1999 MDL-62974 mod_lesson: Minor update to html class. 2019-04-12 11:01:20 +08:00