Commit graph

2529 commits

Author SHA1 Message Date
Jun Pataleta
2685accca8 Merge branch 'MDL-68402' of https://github.com/timhunt/moodle 2020-05-06 17:04:25 +08:00
Tim Hunt
0d3bdb94bc MDL-68402 accesslib: fix get_with_capability_join logic
In fact, rather than fix the old logic, I noticed that the correct
logic was already implemented in get_users_by_capability. So, I
refactored to extract the working version into a function, which it
turns out can have exactly the same API as get_with_capability_join,
which was convenient.
2020-05-06 09:18:02 +01:00
Eloy Lafuente (stronk7)
bb341e4b2f Merge branch 'MDL-68615' of https://github.com/timhunt/moodle 2020-05-06 10:07:28 +02:00
Tim Hunt
bee903193b MDL-68615 questions: more increment idnumber cases found by our tester 2020-05-06 07:46:09 +01:00
Brendan Heywood
529c509f62 MDL-68276 admin: Skip risky tables and columns in db_replace 2020-05-06 15:46:41 +10:00
Andrew Nicols
d86dfdd51e Merge branch 'MDL-67800-master-3' of git://github.com/aanabit/moodle 2020-05-06 11:06:11 +08:00
Eloy Lafuente (stronk7)
95430af3f1 Merge branch 'MDL-68615' of https://github.com/timhunt/moodle 2020-05-06 00:58:26 +02:00
Tim Hunt
1d47cb2168 MDL-68615 questions: fix fiendish default idnumber edge case 2020-05-05 16:19:54 +01:00
Amaia Anabitarte
f2e02ea9f0 MDL-67800 core_contentbank: Testing contentbank events 2020-05-05 10:20:20 +02:00
Andrew Nicols
37f48d2547 Merge branch 'MDL-68500' of https://github.com/paulholden/moodle 2020-05-05 09:48:24 +08:00
Paul Holden
8844cb8286 MDL-68500 dataformat: re-factor download/export methods into new class. 2020-05-04 16:01:12 +01:00
Paul Holden
1de3b81983 MDL-68500 dataformat: allow instances to export to local file. 2020-05-04 09:32:44 +01:00
Jun Pataleta
9d65860430 MDL-52904 completion: Unit tests for daily completion task 2020-05-04 09:57:30 +08:00
Andrew Nicols
3076dfe55d Merge branch 'MDL-68492-master' of https://github.com/sammarshallou/moodle 2020-05-01 12:07:00 +08:00
Davo Smith
9da975fe21 MDL-43156 core_form: fix handling of fixture form
Also moving it from behat_forms to behat_navigation
2020-04-30 20:39:24 +02:00
Davo Smith
5079271b39 MDL-43156 formslib: newly-created repeat elements get the default values 2020-04-30 20:16:07 +02:00
Julien Boulen
7d918bc693 MDL-68137 core_files: replace consecutive dots in filename by single dot 2020-04-28 11:29:35 +02:00
Eloy Lafuente (stronk7)
b1c4bd23d0 Merge branch 'MDL-68477-master' of git://github.com/lameze/moodle 2020-04-27 23:30:09 +02:00
Eloy Lafuente (stronk7)
20860a339e Merge branch 'master' of https://github.com/DrCuriosity/moodle 2020-04-27 23:08:26 +02:00
sam marshall
111cf93b71 MDL-68492 Behat: Use faster direct link steps in lib/tests/behat 2020-04-24 12:09:15 +01:00
sam marshall
be32dc800d MDL-68492 Behat: Direct URL links for courses, activities 2020-04-24 12:09:14 +01:00
Mark Johnson
f77212a051 MDL-68503 user profile: Make sortorders relative to existing records 2020-04-23 15:55:03 +01:00
Eloy Lafuente (stronk7)
d56c7547d6 Merge branch 'MDL-58018_master-arraycomparison' of git://github.com/mdjnelson/moodle 2020-04-23 15:00:57 +08:00
Simey Lameze
8bb8c2852d MDL-68477 libraries: add legend option examples to test page 2020-04-23 09:23:21 +08:00
Mark Nelson
39770792ca MDL-58018 core: add support to redis for read-only sessions 2020-04-21 19:29:12 +02:00
Mark Nelson
4400ed3e1c MDL-58018 core: finish dev to support open sessions without a lock 2020-04-21 19:29:12 +02:00
David Thompson
ab0d409991 MDL-68386 libraries: Enhancement for Area Charts support with chart.js. 2020-04-17 09:12:41 +12:00
Eloy Lafuente (stronk7)
98f56e6f4b MDL-67317 behat: Ensure that on every scenario we have a session.
Before Mink 1.8.0, any call to getSession() used to auto-start
the session if it was not avaliable there. That always has been
an unsupported detail.

With https://github.com/minkphp/Mink/pull/705 new sessions aren't
auto-created anymore.

And we were relying on that.

So this is, simply about to explicitly create the new session
in our before_scenario stuff, to guarantee that it's always there.
2020-04-16 20:28:49 +02:00
Eloy Lafuente (stronk7)
d26a13b407 Merge branch 'MDL-66849-master' of https://github.com/ised-isde-canada/moodle 2020-04-16 01:01:32 +02:00
Eloy Lafuente (stronk7)
8467cbf226 Merge branch 'MDL-67786-master' of git://github.com/aanabit/moodle 2020-04-15 23:45:48 +02:00
Amaia Anabitarte
33b8ca26f9 MDL-67786 core_contentbank: New content bank contenttype plugin type
Co-authored by: Ferran Recio <ferran@moodle.com>
2020-04-15 23:45:08 +02:00
Eloy Lafuente (stronk7)
d9776bc02a Merge branch 'MDL-67499' of git://github.com/paulholden/moodle 2020-04-15 12:49:14 +02:00
Michael Milette
8056397b7e MDL-66849 output: Remove custom menu title when not specified 2020-04-14 22:27:06 -04:00
Eloy Lafuente (stronk7)
2c50e08a3b Merge branch 'MDL-68286-master' of git://github.com/andrewnicols/moodle 2020-04-08 00:37:02 +02:00
Sara Arjona
b3f562176c Merge branch 'MDL-40081' of https://github.com/paulholden/moodle 2020-04-07 15:09:56 +02:00
Paul Holden
abde761cb6 MDL-40081 completion: clean up criteria records for deleted courses. 2020-04-06 12:22:51 +01:00
Paul Holden
343380d9c8 MDL-67499 user: truncate long username/email during user deletion. 2020-04-06 11:48:27 +01:00
Brendan Heywood
00c2153be1 MDL-67818 check: Added Check API and refactored security checks
AMOS BEGIN
 MOV [check_noauth_details,report_security],[check_noauth_details,auth_none]
 MOV [check_noauth_error,report_security],[check_noauth_error,auth_none]
 MOV [check_noauth_name,report_security],[check_noauth_name,auth_none]
 MOV [check_noauth_ok,report_security],[check_noauth_ok,auth_none]
AMOS END
2020-04-06 12:28:37 +10:00
Andrew Nicols
c540a575db MDL-68286 table: Support initials bar for dynamic tables 2020-04-03 16:54:13 +08:00
Andrew Nicols
17f429ed57 Merge branch 'MDL-67734-andrewapocalipse' of git://github.com/ferranrecio/moodle 2020-04-02 09:30:54 +08:00
Eloy Lafuente (stronk7)
1172cd028d Merge branch 'MDL-68193_master' of git://github.com/mdjnelson/moodle 2020-04-01 23:22:25 +02:00
Mark Nelson
52f993651c MDL-68193 core: added new database_text_field_content_replaced event 2020-04-01 20:44:10 +02:00
Ferran Recio
1d4c6f5355 MDL-67734 core_xapi: add xAPI statement support webservice 2020-04-01 14:14:39 +02:00
Eloy Lafuente (stronk7)
1ee1ce36d6 MDL-68281 unit test: Include required class
Also, add missing line break, that I did not see 1 week ago.
2020-03-28 16:23:34 +01:00
Eloy Lafuente (stronk7)
70598a90ca Merge branch 'MDL-68183-master-mysqlpwdresetsql' of git://github.com/mudrd8mz/moodle 2020-03-26 01:08:04 +01:00
Jake Dallimore
9b8fc9be6d Merge branch 'MDL-67934' of https://github.com/timhunt/moodle 2020-03-25 08:28:27 +08:00
David Mudrák
3621b497d2 MDL-68183 auth: Fix the performance of signup_validate_data search query
When searching for other users with the same email address, we perform
the case-insensitive and accent-sensitive search. That may be expensive
as some DBs such as MySQL cannot use the index in that case. Instead,
sequential scan of all the user records is performed and the comparison
uses the LOWER function to filter the matching records. This leads to
significant performance heavy queries which in turn represent a surface
for DoS attacks.

For that reason, we first perform accent-insensitive search for
potential candidates in a subselect, which can use the index. Only then
we perform the additional accent-sensitive search on this limited set or
records.
2020-03-17 14:52:32 +01:00
Adrian Greeve
082153573c Merge branch 'MDL-67981' of https://github.com/timhunt/moodle 2020-03-17 11:30:33 +08:00
Tim Hunt
f2393804bf MDL-67934 questions: give a sensible default idnumber when duplicating 2020-03-12 18:07:11 +00:00
Andrew Nicols
63e821fb41 Merge branch 'MDL-67063-master' of git://github.com/sarjona/moodle 2020-03-11 16:06:00 +08:00