Commit graph

181 commits

Author SHA1 Message Date
Paul Holden
d0d749289d MDL-74477 reportbuilder: sortable custom user profile field columns. 2022-04-11 14:58:30 +01:00
Paul Holden
c00a97c527 MDL-74341 reportbuilder: re-factor audience form permission checks. 2022-04-01 18:13:19 +01:00
Ilya Tregubov
14dcfbaf75 Merge branch 'MDL-74353' of https://github.com/paulholden/moodle 2022-04-01 10:12:56 +08:00
Andrew Nicols
465a300e47 Merge branch 'MDL-74370' of https://github.com/paulholden/moodle 2022-03-31 09:30:28 +08:00
Paul Holden
e5434fac25 MDL-74353 reportbuilder: improvements to report sidebar searching.
* Filter on item textContent instead of dataset, which isn't always
  present;
* Fix hiding of cards when they have no matching items
2022-03-30 21:17:45 +01:00
Paul Holden
7ca314023a MDL-74370 reportbuilder: fix permission check to edit own reports. 2022-03-30 16:26:33 +01:00
Ilya Tregubov
337f727d39 Merge branch 'MDL-74342' of https://github.com/paulholden/moodle 2022-03-30 12:31:23 +06:00
Paul Holden
dcda9c08e2 MDL-74342 reportbuilder: remove unnecessary template/dataset values. 2022-03-29 09:46:55 +01:00
Jun Pataleta
a646e7999e Merge branch 'MDL-74243-master' of https://github.com/dravek/moodle 2022-03-29 11:33:28 +08:00
Paul Holden
a896ea6473 MDL-74342 reportbuilder: allow audiences to be immediately renamed.
Return rendered editable component in response to form submission
so that the audience card can be updated straight away.
2022-03-28 22:28:03 +01:00
David Matamoros
d3bc3ec0c9 MDL-74243 reportbuilder: Fixed double encoding in report/filter name 2022-03-24 11:46:55 +01:00
Paul Holden
652242f618 MDL-74280 reportbuilder: ensure calendar panel zIndex calculated.
Since 29c00fc1 it is calculated dynamically. Ensure all elements
that would otherwise overlap the panel add appropriate class so
they are accounted for during this calculation.
2022-03-21 09:51:59 +00:00
Sara Arjona
d51c17a2ca Merge branch 'MDL-74076' of https://github.com/paulholden/moodle 2022-03-17 16:58:00 +01:00
Sara Arjona
1ccea2c9ff Merge branch 'MDL-74132' of https://github.com/roland04/moodle 2022-03-17 15:42:34 +01:00
Eloy Lafuente (stronk7)
cee098f8bf Merge branch 'MDL-74175' of https://github.com/paulholden/moodle 2022-03-16 22:03:25 +01:00
Mikel Martín
9e329ab152 MDL-74132 reportbuilder: Fix horizontal scrolling regression in editor
MDL-73902 caused a regression in reportbuilder editor horizontal scrolling because of the 'no-overflow' class removal
in the table container wrapper. This patch add styles to allow horizontal scroll in reportbuilder editor table.
2022-03-16 10:21:57 +01:00
Paul Holden
b73a69b920 MDL-74175 cohort: correct type/callback of entity category column. 2022-03-15 15:28:54 +00:00
Sara Arjona
877a882253 Merge branch 'MDL-74173-master' of https://github.com/junpataleta/moodle 2022-03-15 14:27:55 +01:00
Jun Pataleta
6e528ca463 MDL-74173 reportbuilder: Convert action links to action menu links 2022-03-11 18:35:16 +08:00
Mikel Martín
d2acd08934 MDL-74030 navigation: Add reports link
Add report builder 'Reports' link to the user menu

AMOS BEGIN
 CPY [reports,moodle],[reports,core_reportbuilder]
AMOS END
2022-03-10 15:46:44 +01:00
Jun Pataleta
ecfc31191c Merge branch 'MDL-74106' of https://github.com/paulholden/moodle 2022-03-08 09:46:29 +08:00
Paul Holden
2916f89d12 MDL-74106 reportbuilder: handle non-recurring schedules properly.
When a schedule is created with "No recurrence", it should only be
sent when both conditions are true: it's start time is after the
current time; and the time it was last sent is before it's start
time (either 0/never sent; or a time it was manually sent).
2022-03-07 15:47:33 +00:00
Paul Holden
ad7583cd33 MDL-74076 reportbuilder: deterministic ordering of schedule users.
Now that we have consistent ordering we can also revert 898f3d0a.
2022-03-04 15:25:22 +00:00
Jun Pataleta
1aa65fbdfe Merge branch 'MDL-73902-master' of https://github.com/bmbrands/moodle 2022-03-04 18:28:18 +08:00
Bas Brands
729ae8f096 MDL-73902 theme_boost: prevent dropdowns being cut off 2022-03-03 09:44:33 +01:00
Jun Pataleta
898f3d0a82 MDL-73996 reportbuilder: Assert task log contains expected strings
* Ordering issues from \core_reportbuilder\local\helpers\schedule's
get_schedule_report_users() method won't guarantee that the expected
task log output will always be the same as user two can be fetched first
before user one which will cause the message to be sent to user two
first. So just get the task log's output string and make sure it
contains the expected log strings.
2022-03-03 11:09:59 +08:00
Eloy Lafuente (stronk7)
8d362e7249 Merge branch 'MDL-73996' of https://github.com/paulholden/moodle 2022-03-02 23:15:11 +01:00
Eloy Lafuente (stronk7)
fba1593893 Merge branch 'MDL-73941' of https://github.com/paulholden/moodle 2022-03-01 16:10:37 +01:00
Jun Pataleta
37e6306cda Merge branch 'MDL-73983-master' of https://github.com/dravek/moodle 2022-03-01 09:48:18 +08:00
Paul Holden
0ead4cefd2 MDL-73983 reportbuilder: fix pre-defined action title attribute.
Since switching to report actions being displayed via action menus
in 48a6e927, pre-defined action titles weren't displayed.
2022-02-28 13:37:43 +01:00
David Matamoros
8cc2a86b1b MDL-73983 reportbuilder: Don't add empty report action links 2022-02-28 13:36:08 +01:00
Eloy Lafuente (stronk7)
fa2121e333 Merge branch 'MDL-73745' of https://github.com/paulholden/moodle 2022-02-28 11:29:03 +01:00
Paul Holden
425f372044 MDL-73996 reportbuilder: sort caught messages prior to assertions. 2022-02-25 09:58:21 +00:00
Paul Holden
600cd22b0f MDL-73745 reportbuilder: check for presence of active column headers. 2022-02-24 16:26:56 +00:00
Andrew Nicols
e1b9d5f3cd MDL-73915 js: Drop support for IE and android
Moodle announced that support for IE would be dropped back in August
2020 with Moodle 3.9 but not active steps were taken at that time. That
decision was made in MDLSITE-6109 and this particular step was meant to
be taken in Moodle 3.10.

This is the first step taken to actively drop support for IE.

This commit also bumps the browser support pattern from 0.25% to 0.3%.
The percentage here includes any browser where at least this percentage
of users worldwide may be using a browser. In this case it causes
support for Android 4.3-4.4 to be dropped, which relate to Android
KitKat (released 2013).

This combination of changes means that all of the supported browsers in
our compatibility list support modern features including async,
for...of, classes, native Promises, and more which has a huge impact on
the ease of debugging code, and drastically reduces the minified file
size because a number of native Polyfills included by Babel are no
longer included.
2022-02-23 08:55:20 +08:00
Andrew Nicols
0a4047ab31 MDL-73915 js: Switch amd minification to terser
Unfortunately the babel minify-mangle plugin seems to be abandoned and
in certain circumstances can be very buggy. The only safe options are to
disable it, or to switch to a different minification library.

Not minifying our javascript is not ideal, so this commit updates the
javascript tasks to use a rollup, combined with babel, and terser.

Babel still converts code from ES/UMD/AMD to AMD modules with the
relevant browser support, whilst terser minifies the code.

The rollup bundler handles tracking and creation of sourcemaps, and
supports better parallelisation of the tasks.

Since the upgrade to Node LTS/Gallium requires an upgrade to @babel/core
and eslint, which change the built files anyway, this seems like the
ideal time to make this change.
2022-02-23 08:55:09 +08:00
Andrew Nicols
aa7f7957ea MDL-73915 js: Upgrade babel and eslint 2022-02-23 08:53:54 +08:00
Sara Arjona
9d1b516807 Merge branch 'MDL-72061-master' of https://github.com/dravek/moodle 2022-02-21 16:00:44 +01:00
Paul Holden
b95a655a33 MDL-73941 reportbuilder: return localised floats when aggregating.
As the 'average' and 'percentage' aggregation types both return
float values, we should ensure they are output with localised
formatting (e.g. decimal separator).
2022-02-20 07:43:32 +00:00
Sara Arjona
944bebb35c Merge branch 'MDL-73887' of git://github.com/paulholden/moodle 2022-02-17 10:48:58 +01:00
Jun Pataleta
5f8718e35c Merge branch 'MDL-73835' of git://github.com/paulholden/moodle 2022-02-16 22:01:00 +08:00
Ilya Tregubov
249bf250fd Merge branch 'MDL-73837' of git://github.com/paulholden/moodle 2022-02-16 13:52:47 +02:00
Paul Holden
be54872a2c MDL-73887 reportbuilder: make the select filter easier to extend.
Allow custom filters to extend the filter, and override/set the
operators/values fields internally.
2022-02-15 11:21:11 +00:00
Paul Holden
d8158c4532 MDL-73835 reportbuilder: ensure same report instance is exported.
The exported system report should be re-created using all properties
of the persistent, as well as any passed parameters.
2022-02-14 11:51:57 +00:00
David Matamoros
af84b168b6 MDL-73869 reportbuilder: Fix casting to string in report actions 2022-02-14 12:02:22 +01:00
Eloy Lafuente (stronk7)
057a21e381 Merge branch 'MDL-73836' of https://github.com/paulholden/moodle 2022-02-10 21:12:19 +01:00
Jun Pataleta
9dd8909360 Merge branch 'MDL-73811' of https://github.com/paulholden/moodle 2022-02-10 22:41:47 +08:00
Paul Holden
b393248400 MDL-73837 reportbuilder: use column attributes in system reports. 2022-02-10 13:17:01 +00:00
Paul Holden
14b6334133 MDL-73836 reportbuilder: allow pre-defined action title attribute. 2022-02-10 12:38:25 +00:00
David Matamoros
ad35d520c8 MDL-72061 reportbuilder: Fix lost focus on action menu items 2022-02-09 17:19:48 +01:00