Classes attribute was not being honoured by all form element templates.
Formchangechecker was only looking for the ignoredirty class on the element,
in boost it is on the container.
Assign had specific styles to hide the submit buttons that were not matching in boost.
This is for when the autocomplete is used outside of an mform - the drop down arrow was misaligned because
of conflicts with the bootstrap form-control class.
The initial approach I took was to provide a noscript area containing the
standard input element, and to move it to a hidden input element as part of
the passwordunmask setup.
This allowed behat tests to pass both with and without JS enabled (i.e.
with Goutte and real browsers), and also ensured that the real input did
not appear on screen.
However, the standard formslib validation occurs before other page JS is
run and hooks into the elements on page during its setup.
Since noscript elements are not accessible to scripts as standard elements,
the form validation would fail for _client_ side validation and work for
server-side validation.
This change creates creates the hidden input element in the template
instead, as well as the password element in the noscript tag.
Doing this means that when JS is disabled, the form has two elements of the
same name - one hidden, and the second a visible password field.
Since the latter element will always override the former one on form
submission, and the noscript variant is last, the noscript variant wins
when JS is disabled and tests continue to pass.
When JS is enabled, the noscript variant is not a valid part of the DOM
(the browser sees it as a hidden text field essentially). The password is
not automatically entered into the hidden field, so the autocomplete
prevention continues to work as expected.
This is for user-created texts (e.g. the people have used the generico filter to inject BS2 markup into user tests).
It is also for existing old HTML that we have not had time to upgrade yet.
- Removed the border overlapping a user's avatar. This only affected
course profiles and the default preset.
- Do not break the sections when they wrap from one column to another
- Sneaked in a change to remove left/right padding on .box. I've been
wanting to change that since I added it. The padding on top and bottom
is sometimes useful to separate boxes, but the left/right padding
should be applied by the general structure.
Raj was seeing some fails with phantomjs because the action menus were not open after clicking
on the link to open them. Make sure we look for the open menu before continuing.
This version:
* should work with the Behat Goutte driver
* should not suffer from password autofill anxiety
* should allow unmasking (and masking) of a password
* should allow editing of passwords in either masked, or unmasked form
AMOS BEGIN
MOV [revealpassword,core_form],[passwordunmaskrevealhint,core_form]
AMOS END
