Commit graph

242 commits

Author SHA1 Message Date
sam_marshall
4e781c7b50 MDL-15498: Completion system 2008-07-28 12:31:29 +00:00
tjhunt
1aab356193 MDL-15539 - Rework review.php to use attemptlib.php - clean up how review options are calculated, fix up some comments, and make some requires more robust. 2008-07-08 17:46:59 +00:00
tjhunt
78e7a3dd5d MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase - quite a lot of progress, sorry I am committing this as a big lump, but it took me a while to get the code back to a working state.
MDL-15537 - create oo attemptlib.php to hold shared code between attempt, summary and review.php
MDL-15541 - Refactor starting a new attempt into a new file startattempt.php
MDL-15538 - Rework attempt.php to use attemptlib.php
2008-07-08 16:33:47 +00:00
dongsheng
550f965438 "MDL-14129, fix print_error" 2008-06-10 06:27:38 +00:00
nicolasconnault
9cf4a18b41 MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
tjhunt
9c22b42ef7 MDL-14857 - Clean up summary table generation code at the top of the quiz review page - This is basically a merge of improvements we made at the OU. 2008-05-15 15:32:43 +00:00
tjhunt
44847eb868 MDL-14363 - Fix a broken redirect from mod/quiz/ attempt.php to edit.php when the quiz has not questions.
Also, when the quiz has no questions, disable the Info, Reports and Preview tabs, which, in this case, just redirect back to the Edit tab anyway.

Finally, change a redirect in quiz view.php, which used a relative URL, to a full url starting $CFG->wwwroot.
2008-04-22 15:19:50 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt
c52c62d1b1 MDL-13806 - Refactor all the code that implements the rules for whether students can attempt the quiz now into some classes.
Resource page now done as well. That should be everything.
2008-03-07 12:33:07 +00:00
jamiesensei
c56590192a whitespace clean up, removed all indentation with tabs and trailing white space 2008-01-13 08:30:39 +00:00
jamiesensei
6923c5546a MDL-12695 Symantec Norton internet security pop up blocker seems to be stopping user starting a quiz attempt - fixed this by using print_single_button which uses an onclick event to trigger a confirm dialogue, should work better even with popup blockers. 2008-01-12 08:50:32 +00:00
tjhunt
2a13e454f9 MDL-9459 - Provide information relating to groups in the summary message "Attemts: 123". Now, depending on the situation, you see one of three messages: "Attempts: 123", "Attemtps 123 (45 from your groups)" or "Attemtps 123 (45 from this group)".
I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.

Merged from MOODLE_19_STABLE.
2007-12-12 17:23:55 +00:00
tjhunt
99731878ff MDL-12362 - Don't show scores for incomplete attempts on the quiz view page. Merged from MOODLE_19_STABLE. 2007-11-27 19:18:36 +00:00
skodak
9f7f1a74a0 MDL-12221 custom themes revisited - implemented container concept; merged from MOODLE_19_STABLE 2007-11-23 16:49:51 +00:00
tjhunt
8289cdf33a MDL-10284 - wrong language string used on the quiz view page to inform students of the quiz deadline. I took the opportunity to strip out an unnecessary HTML table, and reviewing uses of the string /quiz(open|close)s?/ found one other inconsistency on the quiz editing form. Merged from MOODLE_18_STABLE. 2007-10-31 17:08:47 +00:00
tjhunt
6c58e1985b MDL-6376 - fix minor errors in the previous commit.
More significantly, this patch changes the '1 Students have made 1 attempts' string.

To start with, this code was being produced in five different places, so I made a function to do the work!. Next, as you can see, it is not gramatical. Also, some people find it confusing, as in MDL-6376.

Therefore, it now just says 'Attempts: 1'.

Merged from MOODLE_19_STABLE.
2007-10-30 19:29:45 +00:00
tjhunt
3bdca85298 MDL-11870 - Notices on the quiz view page if the corresponding grade item was deleted. Merged from MOODLE_18_STABLE. 2007-10-23 07:48:03 +00:00
tjhunt
76c619ea16 MDL-11791 - Custom corners broken on the quiz view page because I missed a global declaration, and PHP empty was hiding the problem. Merged from MOODLE_19_STABLE. 2007-10-16 20:29:20 +00:00
tjhunt
14e66f3beb MDL-9542 - Show final grades from new gradebook in Quiz UI - with help from Petr. Merged from MOODLE_19_STABLE. 2007-10-11 11:42:49 +00:00
tjhunt
e63faf2b50 MDL-10376 - since roles and capabilities came along, the quiz was not very gracious if you were logged in as guest, or really logged in on the server, but using guest access to look a a particular course, or were enrolled in a course, but in a role that did not let you preview or attempt quizzes. This patch should clean up the logic for all these cases. 2007-09-20 15:14:24 +00:00
tjhunt
0675e5eb8f MDL-9519 - incorrectuse of language strings in quiz. Merged from MOODLE_18_STABLE. 2007-08-06 13:22:59 +00:00
tjhunt
e584e7c84e Improve display of preview attemtp summary on quiz view page. 2007-07-19 10:27:54 +00:00
tjhunt
ed8bebce5a MDL-10452 - start quiz UI is confusing if you have quiz:preview capability. Change the 'start/continue attempt button' to say 'start/continue preview' in this case. Merged from MOODLE_17_STABLE. 2007-07-13 15:58:42 +00:00
tjhunt
99a1bf3d9c MDL-10374 - Quiz layout improvements, selectively merged from OU-moodle. 2007-07-06 16:37:06 +00:00
tjhunt
11d7a2ab81 Fix minor JavaScript error in the quiz. 2007-06-21 15:28:42 +00:00
tjhunt
c746ce0d03 Fix whitespace. 2007-06-15 10:42:11 +00:00
pichetp
dca29e98dc eliminate this nasty JavaScript that prints the button. 2007-06-05 15:28:03 +00:00
urs_hunkler
f145c2482d added/changed custom corners lib and calls to add the necessary divs 2007-05-09 15:03:01 +00:00
tjhunt
5a56d93857 Clean up whitespace. 2007-04-25 15:37:01 +00:00
tjhunt
dc6c8ca1ac Minor cleanups to the quiz code. 2007-04-10 13:02:09 +00:00
pichetp
37236c3581 adding </p> line 112,114 2007-03-16 20:14:22 +00:00
moodler
d293521a90 Merged notice fix from stable 2007-03-05 05:58:28 +00:00
tjhunt
645dff1cf7 Correct logic for stopping people using guest access from doing quizzes. Merged from MOODLE_18_STABLE. 2007-02-28 11:34:50 +00:00
moodler
c1afef8059 FIxed up the intro boxes XHTML Strict 2007-01-11 08:06:15 +00:00
vyshane
0927589412 Xhtml fixes for MDL-7861. 2007-01-09 09:07:16 +00:00
moodler
f4ba7e1a54 Bend over for XHTML 1.0 Strict ... MDL-8049
Removed Javascript language attribute tags and added CDATA
2007-01-03 14:44:17 +00:00
skodak
4702be4ef7 MDL-8028 Add separate addslashes_js function for javascript quoting 2007-01-01 13:26:20 +00:00
tjhunt
77ed3ba5fd MDL-8002 - Don't show overall feedback for incomplete quiz attempts.
Also, cleanup of mod/quiz/index.php
2006-12-22 12:52:13 +00:00
tjhunt
f725489c9a Typo. Merged from MOODLE_17_STABLE. 2006-12-04 11:54:48 +00:00
tjhunt
2962ad61e4 Put back spaces in code that Martin Dougiamass stripped out of the lang strings without thinking about the consequences. Merged from MOODLE_17_STABLE. 2006-11-28 18:42:18 +00:00
stronk7
d0e35419c5 Typo causing continue button in closed quizzes to fail. MDL-7685
Merged from MOODLE_17_STABLE
2006-11-25 17:13:19 +00:00
tjhunt
f2603dcc89 MDL-7576 - review link does not work after attempt is closed. Thanks to Chad Badiyan for the fix. Merged from MOODLE_17_STABLE. 2006-11-16 12:43:10 +00:00
tjhunt
ec467c6929 MDL-6837 - move warning about pupup blockers into the lang file. Merged from MOODLE_16_STABLE. 2006-10-05 15:58:08 +00:00
moodler
847a041fb7 Better use of mod/quiz:view to hide quiz information (they already have the
name from the course page etc)
2006-09-24 13:54:22 +00:00
tjhunt
f0a7247d0e Fix typo. 2006-08-28 18:50:42 +00:00
tjhunt
cd06115fa7 Convert mod/quiz/view.php to roles, and further tidy up the code flow in there. This touches other files because I had to change a function in locallib that had an $isteacher parameter.
I have not converted the rest of the quiz, and I don't intend to. I am hoping Moodle.com will do it.

I hope this does not introduce any bugs, but view.php is so complicate (at least it is less complicated than it was) and the quiz has so many options, that it is hard to be sure. This needs lots of testing before 1.7 is released.
2006-08-25 16:03:54 +00:00
tjhunt
212b7b8cd9 MDL-5270 - give students a feeback comment for their performance in the entire quiz.
Also, along the way I noticed and fixed MDL-6290 student grades not rescaled when quiz maximum grade changed.
2006-08-22 17:31:26 +00:00
tjhunt
1751eebc69 Reverting toyomoyo's conversion of mod/quiz/view.php to roles because his changes made no sense.
Admittedly, this file is pretty incomprehensible and it is not clear at first what it is trying to do. (Even though it is more comprehensible now than it was a week ago.) I'll to a proper conversion of this file to RnP once I have checked in my other changes there - assuming I can actually get Moodle to work so I can test my changes.
2006-08-22 13:53:39 +00:00
toyomoyo
5cf38a57cd some quiz capabilities 2006-08-22 09:04:23 +00:00
skodak
f9d5371b28 new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283 2006-08-08 22:09:55 +00:00