Commit graph

2606 commits

Author SHA1 Message Date
Shamim Rezaie
d380bec38e Merge branch 'MDL-74812-master' of https://github.com/junpataleta/moodle 2022-06-30 13:34:17 +10:00
Jun Pataleta
b2bc76e0f7 Merge branch 'MDL-74929-master' of https://github.com/bmbrands/moodle 2022-06-28 11:07:48 +08:00
Shamim Rezaie
1296d39194 Merge branch 'master-MDL-71468-v4' of https://github.com/golenkovm/moodle 2022-06-22 14:54:01 +10:00
Jun Pataleta
4ff4ce32e2 MDL-74812 mod_assign: Remove duplicate ID intro 2022-06-20 22:53:30 +08:00
Jun Pataleta
a966a04e3b MDL-74812 gradingform_rubric: Fix contrast issues in rubric table
* Darken the score value using the green theme colour
* Use a light green theme colour for selection backgrounds
* Unify rubric styles related to background and text colour within the
  criteria.
2022-06-18 00:56:44 +08:00
Mikhail Golenkov
e4784db136 MDL-71468 assignfeedback_editpdf: Convert submissions via adhoc tasks 2022-06-17 18:04:17 +10:00
Bas Brands
dde7d102e9 MDL-74929 mod_assign: remove incorrect closing </div> 2022-06-15 09:00:31 +02:00
Jun Pataleta
9343c046bd Merge branch 'MDL-74573-master' of https://github.com/aya-saad1/moodle 2022-06-14 22:37:08 +08:00
Mikhail Golenkov
6684ca3da7 MDL-74234 assign: Fix grading page for filtered out users 2022-06-14 19:04:06 +10:00
sam marshall
96e2caeaa2 MDL-74733 core_navigation: Secondary nav in plugins, change namespace
Secondary nav previously had to be in my_plugin\local\views\secondary; this
location continues to work but is deprecated. The new location is
my_plugin\navigation\views\secondary.
2022-06-08 15:40:44 +01:00
aya.saad
fd79cbe849 MDL-74573 mod_assign: convert view other attempt link to a button 2022-06-05 09:22:21 +02:00
Eloy Lafuente (stronk7)
caf55abf17 MDL-74413 phpunit: Move more tests to use correct names and namespaces
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- Moved to the level2 "privacy" namespace:
  - \mod_assign\privacy\feedback_legacy_polyfill_test
  - \mod_assign\privacy\submission_legacy_polyfill_test

- Moved to the level2 "task" namespace:
  - \core_message\task\migrate_message_data_test
  - \ltiservice_gradebookservices\task\cleanup_test
  - \message_email\task\send_email_test
  - \mod_lti\task\clean_access_tokens_test
  - \mod_workshop\task\cron_task_test

- Moved to the level2 "event" namespace:
  - \core_h5p\event\deleted_test
  - \core_h5p\event\viewed_test

- Renamed to a better name:
  - backup_forum_activity_task_test.php (missing "task")
2022-05-07 20:32:30 +02:00
Jake Dallimore
d84738eb08 MDL-74602 mod_assign: fix js error with assign grader on classic 2022-05-06 16:46:58 +08:00
Ilya Tregubov
93e96e0aa2 Merge branch 'MDL-74602-master' of https://github.com/snake/moodle 2022-05-05 07:46:33 +06:00
Paul Holden
6abe964bba MDL-74204 mod_assign: escape identity fields in allocate marker form. 2022-05-04 04:04:15 +02:00
Jake Dallimore
0402dfdc95 MDL-74602 mod_assign: disable activity header on embedded grader page 2022-05-03 09:55:22 +08:00
Eloy Lafuente (stronk7)
76f5445451 MDL-74510 upgrade: add the 4.0.0 separation line to all upgrade scripts 2022-04-22 18:45:10 +02:00
Ilya Tregubov
5c3563e3a2 Merge branch 'MDL-74064-master' of https://github.com/HuongNV13/moodle 2022-04-14 13:35:11 +06:00
Huong Nguyen
3956dd856b MDL-74064 mod_assign: Behat test for Assignment with time limit 2022-04-14 12:49:55 +07:00
Shamim Rezaie
7252fef24b MDL-74064 mod_assign: Notify submission removal does not reset timelimit 2022-04-14 10:48:45 +07:00
Shamim Rezaie
6ac1477e98 MDL-74064 mod_assign: Use core_user::get_user instead of querying DB 2022-04-14 10:48:37 +07:00
Shamim Rezaie
76c0d3d6bc MDL-74064 mod_assign: Late submission recognition depends on timestarted 2022-04-14 10:48:29 +07:00
Jun Pataleta
70f6b1605b MDL-74471 versions: bump all versions and requires near release 2022-04-13 10:37:36 +08:00
Ilya Tregubov
29da0c7f2a Merge branch 'MDL-74235-master-2' of https://github.com/andrewnicols/moodle 2022-04-07 12:06:38 +06:00
Andrew Nicols
4b388fc239 MDL-74235 core: Update core uses of activity icons to monologo 2022-04-07 12:56:14 +08:00
Andrew Nicols
eb0a95956f MDL-74235 mod: Rename activity icons to new monologo naming 2022-04-07 12:56:14 +08:00
Ilya Tregubov
e2a8a3cbf9 Merge branch 'MDL-74381-master' of https://github.com/aanabit/moodle 2022-04-06 15:37:42 +06:00
Amaia Anabitarte
8d8b8d9066 MDL-74381 core_themes: Resizing svg mod icons to 24px 2022-04-06 11:19:10 +02:00
Eloy Lafuente (stronk7)
70e29b77f0 Merge branch 'MDL-74330-master-enfix' of https://github.com/vmdef/moodle 2022-04-05 18:39:23 +02:00
Mihail Geshoski
c1ab472180 MDL-74383 assignfeedback_editpdf: Fix comment issues in the pdf editor 2022-04-04 10:55:46 +08:00
Mihail Geshoski
2202c71a76 MDL-74383 assignfeedback_editpdf: 'Annotated PDF' link style update 2022-04-04 10:55:46 +08:00
Helen Foster
3719878cbf MDL-74330 lang: Import fixed English strings (en_fix) 2022-04-01 13:17:08 +01:00
Eloy Lafuente (stronk7)
ad2d361db1 Merge branch 'MDL-74306' of https://github.com/paulholden/moodle 2022-03-27 16:04:14 +02:00
Ilya Tregubov
84fbc7b31b Merge branch 'MDL-74193' of https://github.com/paulholden/moodle 2022-03-24 13:08:13 +06:00
Paul Holden
e420fbe303 MDL-74306 mod_assign: fix undefined property in override cache key. 2022-03-23 18:55:03 +00:00
Jun Pataleta
76edf78668 Merge branch 'MDL-74031-master' of https://github.com/bmbrands/moodle 2022-03-21 17:38:54 +08:00
Bas Brands
40357a1976 MDl-74031 mod_assign: limited pagewidth for view action 2022-03-17 10:23:32 +01:00
Simey Lameze
4fe474fad4 MDL-74088 assign: backup and restore support for time limit fields 2022-03-15 17:39:04 +08:00
Paul Holden
ef1be5935f MDL-74193 mod_assign: specify itemid in external attachment filearea. 2022-03-14 22:54:54 +00:00
Sara Arjona
a27c19b73a Merge branch 'MDL-74142-master' of https://github.com/aanabit/moodle 2022-03-10 11:58:21 +01:00
Ilya Tregubov
cb8778c2f1 Merge branch 'MDL-73073-master_assign_timing_web_services' of https://github.com/andrewmadden/moodle 2022-03-10 15:01:06 +06:00
Andrew Madden
4ae22703c6 MDL-73073 mod_assign: Add new time limit fields to external functions
* Add activity, activityformat, timelimit and submissionattachments to mod_assign_get_assignments
* Add timestarted to mod_assign_get_submissions and mod_assign_get_submission_status
* Add assignmentdata to mod_assign_get_submission_status
* Move mod_assign external helper methods to an external_api child class to be used with modern external classes
* Add start_submission external function
* Create mod_assign child class of externallib_advanced_testcase for shared helper functions
* Add extra logic to get_assignments on whether to provide intro
attachments.
2022-03-10 18:31:37 +11:00
Sara Arjona
d1eb8aef66 Merge branch 'MDL-71807' of https://github.com/stronk7/moodle 2022-03-09 16:22:02 +01:00
Amaia Anabitarte
6c1adeec74 MDL-74142 mod_assign: Show time limit information to teachers 2022-03-09 11:08:14 +01:00
Sara Arjona
68a5612ec2 Merge branch 'MDL-73846-master' of https://github.com/golenkovm/moodle 2022-03-08 16:34:40 +01:00
Eloy Lafuente (stronk7)
a5c91474ee MDL-71807 cleanup: Replace deprecated codingStandardsIgnore annotations
The PHP_CodeSniffer @codingStandardsIgnore annotations are deprecated
and, since version 3.x, the new // phpcs:ignore comments should be used
instead.

This commits just reviews all the uses in core, replacing them for
the better new candidate, or removing when no longer needed.
2022-03-08 10:48:53 +01:00
Mikhail Golenkov
ae80480ebe MDL-73846 assignfeedback_editpdf: Add limit for convert_submissions task 2022-03-08 12:36:13 +11:00
Eloy Lafuente (stronk7)
4003e31983 MDL-73785 phpunit: Move more tests to use correct names and namespaces
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- When belonging to other components and being valid api:
  - analytics related tests have been moved to tests/analytics subdir.
  - backup & restore related tests have been moved to tests/backup subdir.
  - events related tests have been moved to tests/event subdir.
  - privacy related tests have been moved to tests/privacy.
  - task related tests have been moved to tests/task subdir.
- Some simple renames, not including the component part anymore (not
  needed now that they are namespaced):
  - some xxxlib_test.php have been renamed lib_test.php
    (when they where testing the corresponding lib.php).
  - cache stores tests have been all renamed store_test, originally
    each one had its own name (file_test, apcu_test, redis_test...)
  - assign feedback tests have been all renamed feedback_test, originally
    each one had its own name (file_test, editpdf_test...)
2022-03-03 12:19:30 +01:00
Shamim Rezaie
6a1078da7c Merge branch 'MDL-73990-master' of https://github.com/sharidas/moodle 2022-03-02 12:55:34 +11:00
Sujith Haridasan
a2b003a917 MDL-73990 mod_assign: Show the activity info and attachments
Show the activity information in the view page and add/edit submission
page.
- Removed the line change to disable activity header. This should help
    - When any additional files are attached to the assignment by the
      teacher/admin they should be displayed in the view and add/edit
      submission page (in the default settings)
- Added more padding to the "Add submission" button.
- Changed the string 'Activity' to 'Activity instructions'.
2022-03-02 07:07:19 +05:30