Commit graph

2467 commits

Author SHA1 Message Date
Adrian Greeve
d602189874 Merge branch 'MDL-63812' of https://github.com/timhunt/moodle 2020-05-25 14:40:14 +08:00
Jun Pataleta
20a660f864 MDL-68367 qtype_multichoice: Decrease minimum expected export file size
* Exporting via Oracle trims trailing zeroes in floating numbers which
results to a smaller file size for the exported file. Better to reduce
the minimum expected export file size from 4000 bytes to 3900 bytes.
2020-05-22 14:45:05 +08:00
Andrew Nicols
a15175eab4 Merge branch 'MDL-68446' of https://github.com/timhunt/moodle 2020-05-22 11:32:01 +08:00
Jake Dallimore
77dddebdb9 Merge branch 'MDL-58645-master' of https://github.com/HuongNV13/moodle 2020-05-22 10:35:27 +08:00
Andrew Nicols
f2d33fcc11 Merge branch 'MDL-68439-master' of https://github.com/HuongNV13/moodle 2020-05-21 20:30:13 +08:00
Huong Nguyen
51de017235 MDL-68439 qtype_ddwtos: UI issues
- Fixed cursor for dropped ddwtos
 - Fixed the animation of "flying back to the home position" starts off at the right end of the previous line"
2020-05-21 17:19:40 +07:00
Jun Pataleta
7750dd55e8 Merge branch 'MDL-68367' of https://github.com/mkassaei/moodle 2020-05-21 17:10:16 +08:00
Mahmoud Kassaei
00055ef6ab MDL-68367 Question: Multi-choice Option to hide systemtext 2020-05-21 09:47:15 +01:00
Adrian Greeve
aa1dcabf4c Merge branch 'MDL-68733' of https://github.com/timhunt/moodle 2020-05-21 08:37:52 +08:00
Tim Hunt
64207dab65 MDL-67183 questions: get_question & get_behaviour only init if required
This reviews all the code code, and sets $requirequestioninitialised
whenever possible in these calls, which should improve performance.
2020-05-19 20:52:07 +01:00
Tim Hunt
89c8a076b2 MDL-68733 quiz editing: behat test for altering random question tags 2020-05-18 23:20:10 +01:00
Tim Hunt
c689726d3f MDL-68733 question behat: question tag generator and use in quiz test 2020-05-18 22:56:33 +01:00
Andrew Nicols
1152df3ec4 MDL-66109 css: Drop use of filter:alpha(opacity)
This CSS statement was an MS-only rule which was never accepted, and
which was abonded some time before IE 10. It has no effect in supported
browsers and can be safely replace with `opacity: [0.0-1.0]`.
2020-05-11 10:55:57 +08:00
Andrew Nicols
f879cc518e MDL-66109 js: Build changes for NodeJS upgrade
This change includes a build to fix all minified file changes in Moodle
as a result of upgrades to our build process.
2020-05-11 10:55:54 +08:00
Jake Dallimore
cd98a57b9f Merge branch 'MDL-68382-master' of https://github.com/HuongNV13/moodle 2020-05-04 10:37:50 +08:00
Huong Nguyen
d0311165a7 MDL-68446 drag to image qtypes: remove hard-coded image size limits 2020-04-29 22:59:53 +01:00
Huong Nguyen
a05ef1307e MDL-58645 Drag and drop onto image questions: responsive support 2020-04-30 00:43:45 +07:00
Helen Foster
1fce3f52ac MDL-68434 lang: Import fixed English strings (en_fix)
Significant string changes:

* pluginnamesummary,qtype_ddimageortext and
  pluginnamesummary,qtype_ddmarker - Note about the question type not
  being accessible to visually impaired users

* addresourceoractivity,core - Removing 'resource' as the new activity
  chooser doesn't have resource types separated
2020-04-28 14:01:20 +02:00
Huong Nguyen
d2fa9e7981 MDL-68382 Drag and drop marker questions: responsive support
These changes also make it possible to print these questions.
2020-04-28 13:52:14 +07:00
Tim Hunt
a196cf5ac1 MDL-66259 qtypes: Add missing comment on get_random_guess_score
A bit off-topic for this issue number, but I noticed it while
working on this, and though it was not worth creating a
separate MDL for.
2020-04-24 15:56:23 +02:00
Tim Hunt
82df13aead MDL-66259 qtype_numerical: remove no-longer relevant todo I noticed 2020-04-24 15:56:23 +02:00
Eloy Lafuente (stronk7)
bb930b7d5b MDL-66259 qtypes: get_question_options() always call parent::
To get the question->options initialised, children must
call parent::get_question_options() always. Also, it is
just general good practice. Subclasses are meant to be
adaptations of the base class, not something completely
different.

Note, there are some changes in the data structure
produced (see changes in the tests) but these changes
are not wrong.
2020-04-24 15:56:23 +02:00
Eloy Lafuente (stronk7)
0447277904 MDL-66259 qtype: add tests to all remaining involved qtypes
That way we get the load_question_data() method covered
and all the main data, options, hints checked.
2020-04-24 15:56:23 +02:00
Tim Hunt
9874e7cdd0 MDL-66259 qtype_truefalse: unit test of loading questions from the DB
This is about to be changes, so we need a test first to catch regressions.
2020-04-24 15:56:23 +02:00
Tim Hunt
2bfb8d4a3d MDL-63812 qtype_gapselect: fix questions with non-consecutive gap nos 2020-04-23 14:39:52 +01:00
Tim Hunt
fdbff6cecb MDL-63812 qtype_gapselect: test data generator to standard qtype pattern 2020-04-23 14:39:52 +01:00
Jun Pataleta
477ef861a0 Merge branch 'MDL-68113-master' of https://github.com/HuongNV13/moodle 2020-04-16 11:46:50 +08:00
Sara Arjona
43cda51ea1 Merge branch 'MDL-68233' of https://github.com/timhunt/moodle 2020-04-06 12:51:22 +02:00
Huong Nguyen
f389e916f2 MDL-68113 Drag and drop into text questions: better responsive design
These changes also make it possible to print these questions.
2020-04-06 14:28:29 +07:00
Tim Hunt
1dcd0d3499 MDL-68233 renderers/block: remove illegal uses of $PAGE and $OUTPUT 2020-03-29 15:34:26 +01:00
Tim Hunt
dbf72bb40f MDL-68277 qtype_essay: answer area in reviews should be right size
The answer box size is set by teachers and provides a useful
visual cue how long a response was expected. Therefore, it is
useful to keep the space at least that size in quiz reviews, etc.
2020-03-27 14:11:16 +00:00
Jun Pataleta
67077ae5aa Merge branch 'MDL-68149' of https://github.com/timhunt/moodle 2020-03-26 00:10:01 +08:00
Tim Hunt
9440b54f8a MDL-68149 qtype_match: correctly distinguish 0 and 0.0 answers
Also added a test for backup & restore (which was working).
2020-03-11 13:43:21 +00:00
Tim Hunt
b060e7495c MDL-68149 qtype_match: Updatey tests to follow make_question() pattern 2020-03-11 13:41:13 +00:00
Bas Brands
e06b302ed5 MDL-67901 type_multichoice: clear my choice accessibility
Improve the accessibility for the clear my choice option. The
extra radio input controlling the reset feature was removed and
resetting the choice is now controlled by JavaScript.
This fixes the missing label reported in Accessibility audit and W3C
validation of the reset link

By this change this issue also fixes MDL-67280
2020-02-27 10:24:12 +01:00
Sara Arjona
a7cd3a17fc Merge branch 'MDL-66834-master' of https://github.com/kepeter/moodle 2020-02-11 11:54:12 +01:00
Peter Eliyahu Kornfeld
3ab494b154
MDL-66834 Questions: add transaction, move trigger 2020-02-03 12:29:43 +02:00
Tim Hunt
2569fb5d2c MDL-67842 questions: Cannot remove the idnumber from a question 2020-01-30 17:24:59 +00:00
Sara Arjona
a26cfe71d3 MDL-65809 upgrade: clean < 3.5.0 upgrade steps
This just deletes all the upgrade steps previous to 3.5.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2018051700 (v3.5.0) as anti-cheating measure.

Previous commits have removed/deprecated all the upgradelib functions
not used anymore in codebase. Deletion has been documented in corresponding
upgrade.txt files:

- upgrade_fix_block_instance_configuration()
- upgrade_theme_is_from_family(), upgrade_find_theme_location()
and linkcoursesectionsupgradescriptwasrun setting
- upgrade_block_positions
- upgrade_fix_config_auth_plugin_names()
 and upgrade_fix_config_auth_plugin_defaults()
- format_xxx_upgrade_remove_numsections(), format_xxx_upgrade_hide_extra_sections()
and format_xxx_upgrade_add_empty_sections()
- filter_mathjaxloader_upgrade_cdn_cloudflare()
and filter_mathjaxloader_upgrade_mathjaxconfig_equal()
- get_assignments_with_rescaled_null_grades()

These have been kept because continue being used by restore:

- \core\task\refresh_mod_calendar_events_task
2019-12-20 12:20:43 +01:00
Shamim Rezaie
6d1eb00445 MDL-67151 qtype_numerical: convert the tolerance to string before saving
Fix the sqlserver issue when saving a number into a text field
2019-12-20 01:11:59 +11:00
Shamim Rezaie
9173b83e58 MDL-67151 qtype_calculatedsimple: Support for the scientific format 2019-12-03 16:52:22 +11:00
Shamim Rezaie
a1f10c5ec5 MDL-67151 qtype_calculated: Support for the scientific format 2019-12-03 16:52:22 +11:00
Shamim Rezaie
bb8d19b885 MDL-67151 qtype_numerical: Support for the scientific format 2019-12-03 16:52:22 +11:00
Eloy Lafuente (stronk7)
492d047d11 MDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts 2019-11-17 11:40:19 +01:00
Eloy Lafuente (stronk7)
d5be859063 MDL-67199 versions: bump all versions and requires near release
version = 2019111800 release version
requires= 2019111200 current beta (week7roll1) version
2019-11-12 17:57:08 +01:00
Tim Hunt
c9491626ab MDL-67153 question bank: let qtype add actions to the edit menu 2019-11-06 19:32:15 +00:00
Tim Hunt
9c14b28d0b MDL-66821 question behat: new step for acting on questions in the bank
There is a proposed change MDL-66816 which will change the question
bank UI. This will break any Behat tests which uses low-level steps
like

    When I click on "Duplicate" "link" in the "Test question" "table_row"

to perform an action on a question in the question bank. This commit
introduces a new step:

    When I choose "Duplicate" action for "Test question" in the question bank

This commit also converts all core Behat tests to use the new step.
2019-10-14 11:36:12 +01:00
Mahmoud.Kassaei
1d89daf329 MDL-66563 Questions: Drag and Drop qtypes in high-contrast 2019-09-04 15:32:16 +01:00
Ryan Wyllie
195ea4480b MDL-62497 javascript: build AMD modules with new transpiler 2019-07-19 14:12:49 +08:00
David Castro
39260e3ead MDL-66115 qtype_ddimageortext: Fixing choice deletion.
Summarising responses fails when question choices have been removed.

AMOS BEGIN
CPY [deletedchoice,qtype_match],[deletedchoice,qtype_ddimageortext]
AMOS END

(cherry picked from commit f0265e6db16caa6d13f8bce291e7da91b0eabb53)
2019-07-12 14:36:32 -05:00