Commit graph

28528 commits

Author SHA1 Message Date
Shamim Rezaie
a7c9576c20 MDL-71672 atto_emojipicker: Focus the search bar initially 2021-07-19 16:41:51 +10:00
Shamim Rezaie
321c443838 MDL-71672 atto_recordrtc: focus Atto button after hide 2021-07-19 16:41:51 +10:00
Shamim Rezaie
c34bd1aa46 MDL-71672 javascript: Fix the issue of focusOnShowSelector being ignored
When focusOnShowSelector is not present, as a fallback, focus the first
focusable element in YUI dialogues
Ref:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
2021-07-19 16:41:51 +10:00
Andrew Nicols
e6e1b50c31 MDL-72163 admin: Plugins overview page should link to categories 2021-07-16 13:49:43 +08:00
Andrew Nicols
2fe23b9295 MDL-72125 behat: Add get_activity_id() behat generators helper 2021-07-16 12:33:56 +08:00
Andrew Nicols
c9a309ed6a MDL-72125 testing: Set a default idnumber when creating activities
The activity generator currently requires an idnumber when creating
activities, but this is not a requirement when creating the same
activity through the UI. The requirement comes because we want to
provide a way to refer to activities in subsequent steps.

This commit modifies the behaviour such that the generator uses the name
of the activity as the default idnumber.

This has two  main benefits:
1. it simplfies generation of activities; and
2. it makes the language used when writing behat tests much more natural.

With this change, steps will refer to the activity by its idnumber/title
in all cases, rather than sometimes by an idnumber which bears no
relevance to the title.
2021-07-16 12:33:56 +08:00
Andrew Nicols
a247fd8d93 MDL-72125 testing: Add helper to run generators as a user 2021-07-16 12:33:56 +08:00
sam marshall
cfb22b5591 MDL-72152 Behat: No way to test key shortcuts with letter keys
Extends the existing step 'And I press the Shift Left key' so that
it supports letter/other keys: 'And I press the Ctrl C key'.
2021-07-15 10:46:45 +01:00
Jun Pataleta
2cde9d6aff Merge branch 'MDL-63770-311' of /home/jun/moodles/stable_311/moodle into MOODLE_311_STABLE 2021-07-15 16:15:39 +08:00
Matteo Scaramuccia
15d50814c6 MDL-63770 core: 'port' should be an integer like in parse_url()
Plus trivial comment cleanup.
2021-07-15 11:39:33 +08:00
Dmitri Pisarev
aa59c122df MDL-63770 core: Fix a false-positive in reverseproxyabused check
A `reverseproxyabused` error is wrongly triggered when external port number doesn't equal internal.
2021-07-15 11:39:33 +08:00
Eloy Lafuente (stronk7)
0443be1bca Merge branch 'MDL-67338-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-07-15 00:34:42 +02:00
Paul Holden
de589ca25d MDL-67338 message: re-implement block page type patterns.
The `page_type_list` method for the message component was deprecated
in 5b0769db as part of MDL-54744. However it is still required when
trying to configure blocks on any messaging pages.
2021-07-14 19:32:24 +01:00
Eloy Lafuente (stronk7)
13a902faea Merge branch 'MDL-71874-311' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE 2021-07-13 20:38:10 +02:00
Sara Arjona
f008960321 MDL-72036 atto_h5p: Random error with external URL
After a major upgrade was done in h5p.com, some random errors appeared
in the "H5P options are ignored for H5P URLs" scenario.
They have been fixed replacing the URL for different (which should
load quicker). As we're checking external content, no other improvement
can be done on the Moodle site.
2021-07-13 08:37:42 +02:00
Huong Nguyen
f53dd9c5d2 MDL-71656 atto: Add meaningful labels to colour items
Colour chooser supported:
 - atto_fontcolor
 - atto_backcolor
2021-07-13 13:07:06 +07:00
Paul Holden
e6a4dde54b MDL-70427 task: correct missing component when queuing adhoc task.
If the task belongs to a component, and doesn't have it's own
component property set then we can lazy-load it based on class
namespace.
2021-07-12 20:47:00 +01:00
Paul Holden
2a2fd7ad38 MDL-70427 admin: remove plugin adhoc tasks during uninstall. 2021-07-12 20:45:07 +01:00
cescobedo
386b1ad8a6 MDL-71919 core_message: Fix tests in message_send 2021-07-08 23:32:19 +02:00
cescobedo
1f45155354 MDL-71919 core_message: Fix unclosed html tags in email notification 2021-07-08 23:32:19 +02:00
Mihail Geshoski
ee4a1fb8d4 MDL-58393 core: Remove firstname argument from emailconfirmation string 2021-07-08 23:32:19 +02:00
Sujith Haridasan
c750bd273b MDL-71241 course: Validate and sanitize sort arguments
Signed-off-by: Sujith Haridasan <sujith@moodle.com>
2021-07-08 23:32:10 +02:00
Andrew Nicols
d2cd91224f MDL-72108 js: Fix incorrect jsdoc examples for core/ajax 2021-07-08 10:39:44 +08:00
Michael Hawkins
15264e5d9a MDL-71916 lib: Check cURL redirects for blocked URLs before following 2021-07-06 23:45:41 +02:00
Eloy Lafuente (stronk7)
01a23b30ca Merge branch 'MDL-70638-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-07-06 20:21:25 +02:00
Paul Holden
9ed376448f MDL-70638 user: correct access checks when serving profile files.
Requests for files from a users profile file area should follow
the same access checks as for the profile itself.
2021-07-06 10:28:22 +01:00
Paul Holden
fb18ed8256 MDL-71981 dataformat: indicate HTML support in writer callback. 2021-07-06 09:28:01 +08:00
Andrew Nicols
b18f066ff2 Merge branch 'MDL-68003_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-07-01 09:53:53 +08:00
Sara Arjona
5bd645d3b3 Merge branch 'MDL-71991_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-06-30 16:09:35 +02:00
Leon Stringer
3236bae2ed MDL-72035 csvlib: Write BOM for Excel
Add option to class csv_export_writer to prefix CSV file with UTF-8 byte
order mark (BOM).  This helps Microsoft Excel detect the file's character
encoding.
2021-06-30 15:01:11 +01:00
Tim Hunt
46ba8d9e70 MDL-68003 session timeout warning: don't show in iframes 2021-06-29 16:58:51 +01:00
Eloy Lafuente (stronk7)
bd83bb57cb Merge branch 'MDL-71947-311' of https://github.com/bmbrands/moodle into MOODLE_311_STABLE 2021-06-29 11:39:34 +02:00
Fred Woolard
80f368e8aa MDL-71777 antivirus: Use hash_from_path (sha1_file) 2021-06-25 09:50:39 -04:00
Eloy Lafuente (stronk7)
cb2132a69e NOBUG: Fixed SVG browser compatibility 2021-06-24 23:03:09 +02:00
Bas Brands
64fb0a9587 MDL-71947 theme_boost: fix styles for vertical forms 2021-06-24 12:32:05 +02:00
Andrew Nicols
4e9bef0197 Merge branch 'MDL-55243-311' of git://github.com/HuongNV13/moodle into MOODLE_311_STABLE 2021-06-24 10:56:11 +08:00
Huong Nguyen
29f384fd91 MDL-55243 files: Make is_valid_image support SVG files 2021-06-24 09:03:23 +07:00
Eloy Lafuente (stronk7)
2f07a9416b Merge branch 'MDL-71593-311' of git://github.com/ilyatregubov/moodle into MOODLE_311_STABLE 2021-06-23 23:35:15 +02:00
Andrew Nicols
a0e267c9a5 MDL-71669 editor_atto: Rebuild editor_atto/events 2021-06-23 14:48:33 +08:00
Andrew Nicols
e57e76096f Merge branch 'MDL-71669-311' of git://github.com/junpataleta/moodle into MOODLE_311_STABLE 2021-06-23 14:07:13 +08:00
Jun Pataleta
335e628e27 MDL-71669 atto_table: Set appropriate ARIA roles for table button
The table button can become a menu button when the cursor's position
in the editor is within a table. So we'd need to update the button with
ARIA attributes appropriate for a menu button.
This is best done when the button's highlight gets toggled, so we're
adding an event listener for when this happens and add/remove the ARIA
attributes accordingly.
2021-06-23 13:10:16 +08:00
Jun Pataleta
2874db9bd5 MDL-71669 editor_atto: Fire custom event when toggling button highlight 2021-06-23 13:10:16 +08:00
Jun Pataleta
408a698eef MDL-71669 editor_atto: Create an events module for the atto editor 2021-06-23 13:10:16 +08:00
Tim Hunt
54197c12d2 MDL-71991 files: check return value of rename when writing files 2021-06-22 19:37:28 +01:00
Sara Arjona
ae9c02762e Merge branch 'MDL-70750-311' of git://github.com/ilyatregubov/moodle into MOODLE_311_STABLE 2021-06-22 10:21:05 +02:00
Ilya Tregubov
69b3669a64 MDL-71593 oauth2: Remove methods that were readded by mistake. 2021-06-21 10:12:45 +02:00
Ilya Tregubov
b818405c99 MDL-70750 mod_survey: Fix warning for undefined offset. 2021-06-21 08:42:28 +02:00
Jun Pataleta
c4b00efba1 MDL-71669 editor_atto: Set proper roles to toolbar menus
* Menu button fix
  - Added aria-haspopup, aria-controls, and aria-expanded attributes.
* Menu fixes
  - Added aria-labelledby that points to the menu button label.
  - Removed the dialog role in the menu's container.
  - The ul tag needs the "menu" role.
  - The li tag needs the role "none" instead of the "presentation" role

Reference:
https://www.w3.org/TR/wai-aria-practices-1.1/#menubutton
2021-06-18 15:20:52 +08:00
Andrew Nicols
613cd69cbd MDL-71113 javascript: Improve basic JS Documentation 2021-06-18 09:38:05 +08:00
Andrew Nicols
e214af5720 MDL-71113 js: Fix all jsdoc warnings 2021-06-18 09:38:05 +08:00