Commit graph

19026 commits

Author SHA1 Message Date
Damyon Wiese
26f8822d5c MDL-43867 Atto: Accessibility improvements.
1/ Set the aria-labelledby attribute on the contenteditable div (find the label from
original textarea)

2/ Store/restore the selection for the contenteditable div when it is focused. This allows
you to select some text, then go to the toolbar and click a button, and the selection
will be restored before the button effect is applied.

3/ Add an accessibility helper plugin.

From testing in all screenreaders, I found that all of their support for contenteditable is not great.
They treat it like a textbox - which means you can type and edit text, but it tells you nothing about
the styles, links or images in the editor. So I added a button to the toolbar, that is only accessible
when navigating via keyboard, that opens an accesssibility helper dialogue. The dialogue shows the list
of current styles, a global list of all links, and a global list of all images. Choosing an image or link
from here, will focus on the editable region, and select the link/image.

4/ Add an accessibility checker plugin to Atto.

Checks for images with no alt, images and links with filenames as alternate text/link text, and contrast ratios
less than WCAG 2.0 AA.
2014-03-26 09:59:37 +08:00
Frederic Massart
dad09216bc MDL-43953 editor_atto: Trigger form change when editing content 2014-03-26 09:59:37 +08:00
Frederic Massart
60a051d471 MDL-44064 editor_atto: Do not die when a plugin is missing 2014-03-26 09:59:36 +08:00
Damyon Wiese
34f5867a11 MDL-43990 Atto: Add a function for changing the formatting of the selected block. 2014-03-26 09:59:36 +08:00
Damyon Wiese
0fa78b80b4 MDL-43861 Atto: Fix for toolbar menu repaint bug in chrome. 2014-03-26 09:59:36 +08:00
Rossiani Wijaya
534cf7b730 MDL-43861: Atto Plugins: create new plugin for font and background colors 2014-03-26 09:59:36 +08:00
Damyon Wiese
0012a94601 MDL-44003 Atto: Set type="button" on atto toolbar buttons.
To prevent them accidentally becoming the default submit buttons for the form.
2014-03-26 09:59:36 +08:00
Frederic Massart
d19cf39edb MDL-44003 editor_atto: Identify the submit buttons in plugins 2014-03-26 09:59:36 +08:00
Frederic Massart
6e3220c053 MDL-43862 atto_managefiles: New plugin to manage files
AMOS BEGIN
 CPY [hasmissingfiles,tinymce_managefiles],[hasmissingfiles,atto_managefiles]
 CPY [deleteselected,tinymce_managefiles],[deleteselected,atto_managefiles]
 CPY [unusedfilesdesc,tinymce_managefiles],[unusedfilesdesc,atto_managefiles]
 CPY [unusedfilesheader,tinymce_managefiles],[unusedfilesheader,atto_managefiles]
AMOS END
2014-03-26 09:59:35 +08:00
Frederic Massart
224a9a51ad MDL-43859 atto_smiley: New plugin to insert smileys 2014-03-26 09:59:35 +08:00
Damyon Wiese
0ec6a46ad1 MDL-43869 Atto: Fix broken repositories.
The previous change on this issue accidentally fixed a selector,
so the repository API was recieving a valid node instead of null.
This means that it calls it's undocumented and dodgy callbacks on the node,
which are really calls directly to the TinyMCE API (just well buried).

But - by not setting the editor_target property, the api will not do
the secret handshakes.
2014-03-26 09:59:35 +08:00
Frederic Massart
c7829b26e1 MDL-43858 atto_charmap: New plugin to insert special characters 2014-03-26 09:59:35 +08:00
Damyon Wiese
48bdf86f31 MDL-43869 Atto: Add functions to get the nodes from the elementids.
If plugins try and do this themselves with Y.one, they will fall foul of the
qtype essay page bug which uses : in the id for form elements.

This is an alternative solution, to escaping the ids, which seemed unreliable for older
version of ie.
2014-03-26 09:59:35 +08:00
Frederic Massart
45698f7714 MDL-43950 editor_atto: Add arguments to plugin callback params_for_js 2014-03-26 09:59:35 +08:00
Damyon Wiese
d088a835d1 MDL-43857: Auto clean tag bloat from word/openoffice/googledocs
The cleanup rules are pulled from both testing of live docs, and the
jquery clean plugin. I tested with googledocs, libreoffice, word 2003
and word 2013.
2014-03-26 09:59:35 +08:00
Damyon Wiese
b269f635f6 MDL-43869 Atto: id escaping so Atto works with when there is : in the id.
(Quiz)
Also includes fixes for Atto when the repositories should not be displayed.
2014-03-26 09:59:34 +08:00
Damyon Wiese
55c0403c6c MDL-43853 Atto: Performance. Turbocharge the loader.
Rewrite the atto plugin loader so that:

A) We have a real settings.php page and can edit the toolbar.
B) All plugins are loaded at the same time (not serially)
C) All plugins share the YUI sandbox (more performance boost).

I had to change the loading API for this - but there are not non-core uses yet,
this is the best time to break it.
2014-03-26 09:59:34 +08:00
Damyon Wiese
f1e6953b36 MDL-43842 Atto: Remove licence and README.txt 2014-03-26 09:59:34 +08:00
Damyon Wiese
3df7cfc59a MDL-43842 Atto: Move pix-icons into core pix folder. 2014-03-26 09:59:34 +08:00
Damyon Wiese
adca7326d8 MDL-43842: Import atto back into core 2014-03-26 09:59:34 +08:00
Ankit Agarwal
f0a0f3c2bd MDL-44596 logging: Improve management interfaces for reports and stores
This patch methods to the manager that uses callbacks from reports to determine how reports and stores are compatible with each other. This information is then displayed in the management pages.
2014-03-26 09:12:42 +08:00
Sam Hemelryk
bfb6e97eae Merge branch 'MDL-43784-master' of git://github.com/FMCorz/moodle
Conflicts:
	lib/classes/plugin_manager.php
	lib/db/upgrade.php
2014-03-26 11:33:47 +13:00
Dan Poltawski
1696ee8050 Merge branch 'wip-MDL-44686-master' of git://github.com/marinaglancy/moodle 2014-03-26 05:15:50 +08:00
Eloy Lafuente (stronk7)
c56e0192ef Merge branch 'w13_MDL-44510_m27_phpunit4' of https://github.com/skodak/moodle 2014-03-25 21:03:44 +01:00
Marina Glancy
daf7b64ef7 Merge branch 'w13_MDL-44107_m27_canview' of git://github.com/skodak/moodle 2014-03-25 17:10:27 +08:00
Andrew Nicols
1f777e5c6c MDL-41987 Javascript: Tidy up YUI documentation 2014-03-25 17:01:37 +08:00
Marina Glancy
da1a0bc3a9 Merge branch 'MDL-44597-master' of git://github.com/andrewnicols/moodle 2014-03-25 16:49:01 +08:00
Marina Glancy
e9e3431ad9 Merge branch 'MDL-40915-master' of git://github.com/ankitagarwal/moodle 2014-03-25 16:18:28 +08:00
Petr Škoda
9e00d46b9c MDL-44510 add extra PEAR PHPUnit info to upgrade.txt 2014-03-25 15:22:22 +08:00
Petr Škoda
15f009e1a2 MDL-44107 add debugging to deprecated event::can_view() 2014-03-25 14:53:17 +08:00
Marina Glancy
3f4a4daa03 Merge branch 'MDL-44704_master' of git://github.com/markn86/moodle 2014-03-25 14:28:10 +08:00
Marina Glancy
390f3c6ade Merge branch 'MDL-44682' of git://github.com/timhunt/moodle 2014-03-25 14:27:42 +08:00
Marina Glancy
dd043de942 Merge branch 'w13_MDL-44106_m27_requestorig' of git://github.com/skodak/moodle 2014-03-25 14:15:19 +08:00
Marina Glancy
19b4e34941 Merge branch 'w13_MDL-41284_m27_stats' of git://github.com/skodak/moodle 2014-03-25 14:06:41 +08:00
Marina Glancy
81e50a3661 Merge branch 'MDL-44316_master' of git://github.com/markn86/moodle 2014-03-25 14:03:06 +08:00
Frederic Massart
6538153bbd MDL-44719 libraries: Invalid call to ajaxenabled()
A bad conflict resolution in 7eaca5a810
wiped this function from the deprecatedlib file. This patch
restores it.

But as we should not call any deprecated function in core we
also remove the its usage.
2014-03-25 11:44:08 +08:00
Sam Hemelryk
a4604e1e97 MDL-43839 unit test fixes 2014-03-25 15:06:32 +13:00
Sam Hemelryk
a468750723 Merge branch 'w13_MDL-44511_m27_jquery' of https://github.com/skodak/moodle 2014-03-25 12:26:53 +13:00
Sam Hemelryk
fe24226063 Merge branch 'MDL-44357-master-noplugin' of git://github.com/FMCorz/moodle 2014-03-25 08:56:49 +13:00
Andrew Nicols
6d402310a4 MDL-34353 Javascript: Allow chooser dialogues to fall back to non-JS version
In order for a chooser dialogue to be able to fall back to it's non-JS
equivalent, we need to use a different set of styles.

This change makes the chooser dialogue preparation function add a new class
to the body which is utilised in the CSS to accomplish this. When the class
is not present, the dialogue content is displayed inline.
2014-03-25 00:51:09 +08:00
Andrew Nicols
6bf267776c MDL-28261 Javascript: Check for a working connection in SCORM activities 2014-03-24 23:48:32 +08:00
Marina Glancy
66cb56ade6 Merge branch 'w13_MDL-44639_m27_taskdocs' of git://github.com/skodak/moodle 2014-03-24 17:02:10 +08:00
Marina Glancy
0b536b368c Merge branch 'w13_MDL-44661_m27_anon' of git://github.com/skodak/moodle 2014-03-24 15:38:58 +08:00
Andrew Nicols
5d504395f7 MDL-44597 lessphp: Add sourceMap support in theme designer mode 2014-03-24 15:19:49 +08:00
Frederic Massart
379924a6a5 MDL-44357 libraries: Remove import_file method from core_lessc
This is not used any more, and would not work if the file to be
imported is located in a theme when $CFG->themedir is not set
to the default value.
2014-03-24 15:15:04 +08:00
Frederic Massart
833511a005 MDL-44357 theme_more: New customizable theme
AMOS BEGIN
 CPY [choosereadme,theme_clean],[choosereadme,theme_more]
 CPY [configtitle,theme_clean],[configtitle,theme_more]
 CPY [customcss,theme_clean],[customcss,theme_more]
 CPY [customcssdesc,theme_clean],[customcssdesc,theme_more]
 CPY [footnote,theme_clean],[footnote,theme_more]
 CPY [footnotedesc,theme_clean],[footnotedesc,theme_more]
 CPY [invert,theme_clean],[invert,theme_more]
 CPY [invertdesc,theme_clean],[invertdesc,theme_more]
 CPY [logo,theme_clean],[logo,theme_more]
 CPY [logodesc,theme_clean],[logodesc,theme_more]
 CPY [pluginname,theme_clean],[pluginname,theme_more]
 CPY [region-side-post,theme_clean],[region-side-post,theme_more]
 CPY [region-side-pre,theme_clean],[region-side-pre,theme_more]
AMOS END
2014-03-24 15:15:04 +08:00
Frederic Massart
08823e5f03 MDL-44357 theme: Do not include plugins LESS or CSS when compiling 2014-03-24 15:15:04 +08:00
Frederic Massart
29d73d2751 MDL-44357 theme: Chunk content in styles_debug for IE 2014-03-24 15:15:03 +08:00
Frederic Massart
d433cf37cd MDL-44357 theme: Allow core to compile LESS in PHP 2014-03-24 15:15:03 +08:00
Sam Hemelryk
7911effdcb MDL-43839 fixed clean as default phpunit bugs 2014-03-24 17:10:54 +13:00