moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-09 10:56:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
99419 commits 37 branches 544 tags 1.3 GiB
Commit graph

25 commits

Author SHA1 Message Date
Vitaly
12d4c82f98 MDL-56653 enrol_meta: a single DB query in edit_instance_validation 
The 'edit_instance_validation()' method checks for existing meta enrolment instances.
The fix replaces DB queries in a loop for each course with a single query for all courses.
Also, a new testing method 'test_edit_instance_validation_with_existing_courses()'
was added to /enrol/meta/tests/plugin_test.php to test if the new implementation
returns an error in case of trying to save the already linked courses in the 'customint1' field.
 2020-11-18 15:05:31 +08:00
Eloy Lafuente (stronk7)
4621917c62 MDL-67114 core: php74 fix. Fix use of scalar as array in core 
There are various places where it's not guaranteed that the
variable being used is array, and instead, can be null, bool, int...

We need to check that because php74 warns about it.

Where possible we have used the coalesce operator as
replacement for isset() ternary operations.
 2020-01-03 11:33:15 +01:00
Farhan Karmali
fe5b5be1dd MDL-61208 enrol: Standard enrol plugins should use tasks instead of cron 2018-04-10 09:16:17 +05:30
Jun Pataleta
4047fccba7 MDL-59811 enrol: Move get_user_enrolment_actions logic to parent class 
* These duplicated implementations can be simplified where the logic
  can be moved to enrol_plugin::get_user_enrolment_actions() method
  itself.
 2017-10-09 10:29:02 +08:00
Luca Bösch
da15576180 MDL-58928 enrol: delete and edit icon alt attribute 2017-07-31 17:31:07 +02:00
Jun Pataleta
fd0a43be1b MDL-59369 enrol: Introduce data-action attribute for enrol action links 2017-07-26 09:44:33 +08:00
Frédéric Massart
77bec234e0 MDL-56282 enrol_meta: Fix error when editing existing instances 
We had a few problems here.

1/ The auto complete element was displaying the picker though the
   field was frozen.
2/ Checking for existing enrolment including the courses chosen was
   not checking if the courses found were in the instance we edit.
3/ Upon creation we support multiple courses but when editing we
   should not expect more than the course in the instance being edited.
 2016-10-31 12:15:02 +08:00
Damyon Wiese
6b04655573 MDL-27628 enrol_meta: Set options to exclude existing courses, and the current course 
When adding a new meta enrolment, you should not be able to select the current course,
or any courses with an existing meta link.
 2016-03-10 13:17:10 +01:00
Damyon Wiese
6f326bd204 MDL-27628 enrol_meta: Use new multi-course selector 
Allows adding multiple instances of the meta enrol plugin at once.

I had to add support to the autocomplete element for filling the field from behat
when it was not using tags. I also had to make the shortnames more easily searchable
and unique in the behat feature file.
 2016-03-09 13:32:08 +08:00
Damyon Wiese
51c736f037 MDL-48362 enrol: Auto generate the edit action icons when using the new ui 2016-02-29 14:00:31 +08:00
Damyon Wiese
60010fd614 MDL-48362 enrol: Use a standard UI and validation for enrolment plugins 
Convert core enrolment plugins to use standard editing ui.
 2016-02-29 12:31:41 +08:00
Marina Glancy
bacb7b1f6e MDL-17929 enrol_meta: allow to edit instance 2015-04-22 14:36:38 +08:00
Marina Glancy
e284e1792c MDL-17929 enrol_meta: create new group if selected 
AMOS BEGIN
  CPY [creategroup,enrol_cohort],[creategroup,enrol_meta]
AMOS END
 2015-04-22 14:36:38 +08:00
Marina Glancy
9e37d365d8 MDL-17929 enrol_meta: synchronise with groups 2015-04-22 14:36:34 +08:00
Daniel Neis Araujo
b5a289c4e8 MDL-46509 enrol: Require 'enrol/PLUGIN:config' capabilities to show/hide enrollment instances 2014-08-21 19:01:57 -03:00
Daniel Neis
ee9e079ddd MDL-35864 Require 'enrol/PLUGIN:config' capabilities to delete enrol instances 2014-06-20 13:08:18 -03:00
Petr Škoda
fa151f7a13 MDL-42206 improve course edit performance when use meta courses 2013-10-18 15:17:02 +02:00
Rajesh Taneja
b7a5eb1ed8 MDL-41590 Enrolments: If course is deleted, then use courseid for reference 2013-09-04 17:32:19 +08:00
Tim Hunt
70f4ac5aea MDL-40527 enrol meta: respect $CFG->courselistshortnames 
Thanks to James Henestofel for working this out in MDL-37558. That issue
got complex, so I am just submitting this simple part of it for
integration.
 2013-07-05 15:30:17 +01:00
Petr Škoda
31ac2aef26 MDL-39386 fix phpdocs packages in enrol 2013-04-27 13:41:32 +02:00
Frederic Massart
55bcef2954 MDL-34461 Librairies: Replaced deprecated get_context_instance() 2012-07-23 17:42:05 +08:00
Petr Skoda
ad68ed7402 MDL-29684 improve enrol_meta plugin 
List of changes:
* configurable unenrol action
* new setting for synchronisation of all enrolled users or users with at least one role
* cron period increased to 1 hour in order to lower server load, courses should not get out of sync often
* CLI sync script for debugging or manual sync
* phpdocs fixes
* when plugin is disabled all roles are removed, enrollments are kept
* uninstall script
* other bugfixing
 2012-01-08 15:07:49 +01:00
Petr Skoda
e2382027e2 MDL-23502 fixed php docs in enrol/meta + adding config cap 2010-07-31 20:28:32 +00:00
Petr Skoda
e25f24669b MDL-23502 improved new instance function name 2010-07-31 20:02:56 +00:00
Petr Skoda
df997f841f MDL-21782 reworked enrolment framework, the core infrastructure is in place, the basic plugins are all implemented; see the tracker issue for list of unfinished bits, expect more changes and improvements during the next week 
AMOS START
    MOV [sendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage,enrol_self]
    MOV [configsendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage_desc,enrol_self]
    MOV [enrolstartdate,core],[enrolstartdate,enrol_self]
    MOV [enrolenddate,core],[enrolenddate,enrol_self]
    CPY [welcometocourse,core],[welcometocourse,enrol_self]
    CPY [welcometocoursetext,core],[welcometocoursetext,enrol_self]
    MOV [notenrollable,core],[notenrollable,core_enrol]
    MOV [enrolenddaterror,core],[enrolenddaterror,enrol_self]
    MOV [enrolmentkeyhint,core],[passwordinvalidhint,enrol_self]
    MOV [coursemanager,core_admin],[coursecontact,core_admin]
    MOV [configcoursemanager,core_admin],[coursecontact_desc,core_admin]
    MOV [enrolledincourserole,core],[enrolledincourserole,enrol_manual]
    MOV [enrolme,core],[enrolme,core_enrol]
    MOV [unenrol,core],[unenrol,core_enrol]
    MOV [unenrolme,core],[unenrolme,core_enrol]
    MOV [enrolmentnew,core],[enrolmentnew,core_enrol]
    MOV [enrolmentnewuser,core],[enrolmentnewuser,core_enrol]
    MOV [enrolments,core],[enrolments,core_enrol]
    MOV [enrolperiod,core],[enrolperiod,core_enrol]
    MOV [unenrolroleusers,core],[unenrolroleusers,core_enrol]
AMOS END
 2010-06-21 15:30:49 +00:00