Commit graph

29679 commits

Author SHA1 Message Date
Sara Arjona
c4e6ac585d MDL-73868 oauth2: Remove multiple slashes in image URL
There is an issue with the current Badgr manifest because the image
URL contains double slash which is causing an error when storing it
in the database (https://api.test.badgr.com/static//images/logo.png).
This issue parses image URL and removes multiple slashes in URL.
2022-02-14 11:30:19 +01:00
Mihail Geshoski
bf27303955 MDL-73532 navigation: Update unit tests
Updates the existing unit tests related to the secondary navigation
class and includes cases where the given course uses single activity
format.
2022-02-14 09:35:04 +08:00
Mihail Geshoski
98c89410f9 MDL-73532 navigation: Secondary navigation for single activity course
Creates secondary navigation dedicated for the single activity course
format. To accomodate these chanages a new property
'showchildreninsubmenu' is introduced in navigation_node which can be
used to define whether the node's children should be displayed in a
submenu when applicable. Also, new method get_page() is added in
settings_navigation which can be used to get the $page class property.
2022-02-14 09:35:03 +08:00
Eloy Lafuente (stronk7)
d66a5316ae MDL-73826 phpunit: Allow curl mock responses to handle empty strings
Before this commit, is_empty() was being applied before returning
the mock response. But we want to be able to mock the empty response
for some tests, hence moving the condition to null/isset, that is
the value that array_pop() returns where there aren't more elements
in the array.

With that change performed, we can test lti_load_cartridge() with
empty responses, hence adding a new test for that.
2022-02-11 23:50:05 +01:00
Sara Arjona
ee289b4286 Merge branch 'MDL-69542-master-fixes-historyfix' of https://github.com/snake/moodle 2022-02-11 17:07:43 +01:00
Sara Arjona
256232ad46 MDL-73248 adminpresets: Improvements to the Starter preset
This is the list of changes applied to the Starter preset, following
the community suggestions and the latest features included in 4.0:

- Hide Online users, Recently accessed courses and Starred courses.
- Re-enable Description and Essay question types.
- Disable guest enrolment and hide guest login button.
- Reduce the information displayed in the activity chooser.

Apart from that, the User menu items has been removed because it had
the same value in both presets (so it makes no sense having there).
2022-02-11 16:41:06 +01:00
Jun Pataleta
9af545659c Merge branch 'MDL-72928-rebase' of https://github.com/Chocolate-lightning/moodle 2022-02-11 22:28:11 +11:00
Jun Pataleta
ae14ff321b MDL-72928 core: Remove Remember username 2022-02-11 12:01:26 +08:00
Mathew May
ecb92c7ed9 MDL-72928 login: Update styling and functionality 2022-02-11 12:01:26 +08:00
Jake Dallimore
66b76c4545 MDL-69542 enrol_lti: remaining changes for dynamic registration support
- Allow the tool to generate secure, one time, dynamic registration
URLs for use in supporting platforms.
- Registration endpoint, which validates the one time URL, makes
the registration requqest to the platform and adds the approriate
tool registration changes in the tool on success.
- Admin settings pages make use of the 'copy to clipboard' module
which is now in core.
2022-02-11 11:06:05 +08:00
Jake Dallimore
c9636d261b MDL-69542 core_lib: make lti tool generator default to legacy version
This means existing tests won't need to change.
2022-02-11 11:01:26 +08:00
Jake Dallimore
6c0ffde138 MDL-69542 libraries: Add the LTI 1.3 library 2022-02-11 10:07:39 +08:00
Limekiller
3c60f8a0ce MDL-73450 installation: Support Aurora MySQL >= 8.0.0 2022-02-10 15:14:35 -05:00
Eloy Lafuente (stronk7)
83497580cb Merge branch 'MDL-73669-master' of https://github.com/marinaglancy/moodle 2022-02-10 16:39:06 +01:00
Ilya Tregubov
8685968870 Merge branch 'MDL-73764' of https://github.com/stronk7/moodle 2022-02-10 14:18:34 +02:00
Sara Arjona
3daeecd3d2 MDL-73827 lib: Fix URL blocked error for userinfo endpoint
When the oAuth2 issuer hasn't any userinfo endpoint, a call to
$this->get(false) was done, which was returning "The URL is
blocked".
This is a regression from MDL-70649, which added some cURL security
checks.
2022-02-10 10:43:38 +01:00
Paul Holden
ff6e5cc71d MDL-73797 output: swap order of buttons in save/cancel dialogs.
The primary button should swap position with the secondary button,
so that it's displayed on the right hand side of the dialog.
2022-02-10 08:34:04 +00:00
Shamim Rezaie
e30493108d Merge branch 'MDL-73722' of https://github.com/paulholden/moodle 2022-02-10 17:21:10 +11:00
Bas Brands
d9cefeba09 MDL-73795 theme_boost: align header actions on mobile 2022-02-09 15:06:04 +01:00
Ilya Tregubov
7e34d42298 Merge branch 'MDL-73773' of https://github.com/paulholden/moodle 2022-02-09 13:28:43 +02:00
Jun Pataleta
7d743b255d Merge branch 'MDL-73633-master' of git://github.com/mihailges/moodle 2022-02-09 17:45:54 +08:00
Eloy Lafuente (stronk7)
3bb4a4009c MDL-73764 tool_xmldb: Regenerate all the files detected by the report
Note that, instead of going one by one to them from the XMLDB Editor
(load, makes some tiny change, save, revert the change, save), the
report includes a commented line that, once uncommented, does regenerate
the file while reporting.

I've left it there as a commodity for the developer.
2022-02-08 19:25:03 +01:00
Jun Pataleta
939cb7a90f Merge branch 'MDL-72246-master-2' of https://github.com/andrewnicols/moodle 2022-02-08 11:36:59 +08:00
Andrew Nicols
70cc41eec8 MDL-72246 core_completion: Only fetch other completion data on requested
Prior to this patch, the code was fetching all completion data for all
activities in a course, even when the activity was not requested. This
leads to recursion issues as the data has not been added to the cache
before this operation occurs.

To handle this situation, only the requested CM is fetched in full, and
a boolean flag is used to store whether the full data has been fetched.

When returning a partially fetched value from the cache, the flag is
used to determine whether more data must be fetched, and the cache
updated.

The flag is filtered out before the value is returned.

Note: Many of the tests were updated as these were inspecting private
features of the API which should not really be tested.
2022-02-08 11:35:23 +08:00
Andrew Nicols
adc61dddc3 MDL-72246 core_completion: Test coverage improvements for completion 2022-02-08 11:22:14 +08:00
Andrew Nicols
a999b12e02 MDL-72246 core_completion: Stop testing the inner workings of get_data() 2022-02-08 11:22:14 +08:00
Andrew Nicols
95c6d3c8d9 Merge branch 'MDL-73716' of https://github.com/stronk7/moodle 2022-02-08 10:59:34 +08:00
Andrew Nicols
df154ecb72 Merge branch 'MDL-73116' of https://github.com/roland04/moodle 2022-02-08 10:57:40 +08:00
Andrew Nicols
b710e57ebd Merge branch 'MDL-73766-master' of https://github.com/lucaboesch/moodle 2022-02-08 10:54:44 +08:00
Peter Dias
81492f900f MDL-73373 roles: Enable tertiary navigation in module context 2022-02-08 09:04:04 +08:00
Eloy Lafuente (stronk7)
c5e2a4ded0 Merge branch 'MDL-73601-master' of https://github.com/aanabit/moodle 2022-02-07 12:01:19 +01:00
Mikel Martín
8b535c297b MDL-73116 core: Add triggerElement parameter to saveCancel dialogue
triggerElement parameter is used to return the focus after modal is hidden
2022-02-07 11:33:35 +01:00
Eloy Lafuente (stronk7)
43280530b6 MDL-73716 phpunit: remove old simpletest static members
And replace them by phpunit @covers annotations including
all the classes declared or extended in the removed members.

It's not awesome coverage, but better than nothing.
2022-02-07 10:42:17 +01:00
Luca Bösch
c5df2d0c58 MDL-73766 theme_boost: have login page use loginto string 2022-02-07 07:54:31 +01:00
Andrew Nicols
bb20aefc8d Merge branch 'MDL-71712-master' of https://github.com/aanabit/moodle 2022-02-07 09:53:09 +08:00
David Mudrák
38e05ba09f MDL-73748 admin: Check for available updates daily on random time
It's been a mistake to make every Moodle site out there to check for
available update every two hours, on the hour. We are experiencing
server load peaks that are harder and harder to deal with.

The patch addresses this by (1) checking for available updates just once
a day and (2) distributing the checking times randomly around the clock.
2022-02-06 22:02:34 +01:00
Paul Holden
b8f9f6635c MDL-73669 behat: correctly deprecate step for using flat navigation. 2022-02-04 17:18:43 +01:00
Marina Glancy
15eb402228 MDL-73669 core_enrol: move deprecated behat steps to own file
Steps were initially deprecated in MDL-72090
2022-02-04 17:17:08 +01:00
Marina Glancy
c5c33d8eba MDL-73669 core_calendar: move deprecated behat steps to own file
Steps were initially deprecated in  MDL-72810
2022-02-04 17:17:08 +01:00
Marina Glancy
31751c2f32 MDL-73669 behat: allow multiple files with deprecated steps 2022-02-04 17:17:08 +01:00
Paul Holden
2e8a9623e5 MDL-73773 behat: correctly deprecate step for using flat navigation. 2022-02-04 11:59:36 +00:00
Eloy Lafuente (stronk7)
549cfc5efb Merge branch 'MDL-73765-master-twenty-three-minutes' of https://github.com/mudrd8mz/moodle 2022-02-03 22:27:02 +01:00
David Mudrák
296f714916 MDL-73765 task: Fix calculation of random minute in the task schedule
The random minute was incorrectly set to a random value from the range
0 - 23 instead of 0 - 59 due to this copy & paste mistake.
2022-02-03 19:22:58 +01:00
Sara Arjona
1d0609bbdd MDL-71696 question: Align new tables with install/upgrade
Amended because, in all cases, install.xml wins and we
have make upgrade.php to match it...

But in the question_versions->status case, that needs to
be NOT_NULL, so upgrade was correct and install.xml has
been changed for it.

Note this has been changed without using the editor because
it has been detected that there are other changes in the xml
file that have been added manually, we'll create a "reconcile"
issue to fix that (mainly whitespace).

So, yes, please, always use the editor.
2022-02-03 16:32:04 +01:00
Ilya Tregubov
aafeca8f75 Merge branch 'MDL-73664-master' of https://github.com/aanabit/moodle 2022-02-03 16:37:55 +02:00
Eloy Lafuente (stronk7)
a2e4be3620 Merge branch 'MDL-73728-master' of https://github.com/andrewnicols/moodle 2022-02-03 14:59:00 +01:00
Amaia Anabitarte
0023f63772 MDL-73664 lib: Set Moodle files after ADODB upgrade 2022-02-03 13:56:02 +01:00
Sara Arjona
b841a811be Merge branch 'master_MDL-71696-versioning-integration' of https://github.com/catalyst/moodle-MDL-70329 2022-02-03 13:25:27 +01:00
Safat Shahin
bf55e5a481 MDL-71696 core_question: class autoload changes
This commit implements some class autoloading
fixes to align with core question structure.
2022-02-03 22:22:50 +11:00
Safat Shahin
3008edd366 MDL-71696 core_question: Implement question status change
This commit implements the status change pop up for a question
in the base view. This feature update will allow the change of
status of a question without creating a new version.
This commit also implements the status as a char rather than
an int value.
2022-02-03 22:22:50 +11:00