Commit graph

63666 commits

Author SHA1 Message Date
Frederic Massart
861b0510e5 MDL-39959: Replace Legacy events - Groups
This combines the following changes:

* Event for group member added
* Event for group member removed
* Event for group created
* Event for grouping created
* Event for group updated
* Event for grouping updated
* Event for group deleted
* Event for grouping deleted
* Adding tests for deleting functions
* Bulk remove of members uses low-level API

    The reason for this is that a bulk event has no value from a logging
    perspective as it is not granular. So now, the API is a bit slower,
    but the information the events contain makes sense, beside this is
    not (and should not be) used very often.

    The reason why the events_trigger_legacy() is kept is because we
    cannot create a new event for this, as we don't encourage developers
    to created bulk events, for the reasons mentioned above.

    I removed the call that gets the user record from the function
    groups_remove_member() as it was not required and only appeared
    to check if the user existed. It appears to be safe not to do
    this check as nothing would fail down the line.

* Bulk unassign of groupings uses low-level API

    As the previous commit, we keep the legacy event for now as it would
    be wrong to create a new event to replace it.

    Also, the code has been changed to call the low-level API to unassign
    groups from groupins, even though at the moment there are no
    events for that function.

* Bulk deletion of groups uses low-level API

    Again, we keep the legacy event because replacing it would force
    us to create a new event that does not make sense. See MDL-41312.

* Bulk deleting of groupings uses low-level API
* Asserting legacy event name in unit tests
* Minor SQL query and code improvements
2013-08-26 15:03:17 +08:00
Dan Poltawski
11b80a6044 Merge branch 'MDL-35930' of git://github.com/rwijaya/moodle 2013-08-26 14:55:54 +08:00
Dan Poltawski
8f9e51417e Merge branch '40249-26' of git://github.com/samhemelryk/moodle 2013-08-26 14:33:06 +08:00
Rossiani Wijaya
3f0d3a7ea0 MDL-35930 filepicker filemanaer: make announcement on page change when selecting view files options 2013-08-26 14:30:35 +08:00
Dan Poltawski
ba59a28305 Merge branch 'MDL-36126_master' of https://github.com/markn86/moodle 2013-08-26 14:25:20 +08:00
Frederic Massart
725dfe6a54 MDL-40055 mod_assign: Wrong namespace when throwing exception 2013-08-26 14:21:34 +08:00
Frederic Massart
959a328472 MDL-40055 mod_assign: Setting level according to new event constants 2013-08-26 14:17:18 +08:00
Frederic Massart
5e8eb969e0 MDL-40055 mod_assign: get_name() uses get_string() not lang_string 2013-08-26 14:17:18 +08:00
Frederic Massart
bd2e982998 MDL-40055 mod_assign: Replace add_to_log 'grade submission' 2013-08-26 14:17:18 +08:00
Frederic Massart
9a289c3da5 MDL-40055 mod_assign: Replace add_to_log 'unlock submission' 2013-08-26 14:17:18 +08:00
Frederic Massart
6332ff7a35 MDL-40055 mod_assign: Replace add_to_log 'submit' 2013-08-26 14:17:18 +08:00
Frederic Massart
b1e52860ea MDL-40055 mod_assign: Replace add_to_log 'submission statement accepted' 2013-08-26 14:17:18 +08:00
Frederic Massart
89fbc20263 MDL-40055 mod_assign: Replace add_to_log 'submissioncopied' 2013-08-26 14:17:18 +08:00
Frederic Massart
8bb213eb60 MDL-40055 mod_assign: Replace add_to_log 'set marking workflow state' 2013-08-26 14:17:18 +08:00
Frederic Massart
e59a85ba61 MDL-40055 mod_assign: Replace add_to_log 'set marking allocation' 2013-08-26 14:17:17 +08:00
Frederic Massart
159b7f4024 MDL-40055 mod_assign: Replace add_to_log 'revert submission to draft' 2013-08-26 14:17:17 +08:00
Frederic Massart
ad10ad1415 MDL-40055 mod_assign: Replace add_to_log 'reveal identities' 2013-08-26 14:17:17 +08:00
Frederic Massart
3d1331be34 MDL-40055 mod_assign: Replace add_to_log 'lock submission' 2013-08-26 14:17:17 +08:00
Frederic Massart
76e77b05eb MDL-40055 mod_assign: Replace add_to_log 'grant extension' 2013-08-26 14:17:17 +08:00
Frederic Massart
a65b53036e MDL-40055 mod_assign: Replace add_to_log 'download all submissions' 2013-08-26 14:17:17 +08:00
Damyon Wiese
5db088a3cb Merge branch 'w35_MDL-41245_m26_pluginuninstall' of https://github.com/skodak/moodle 2013-08-26 13:59:51 +08:00
Petr Škoda
a3cbc19830 MDL-41245 prevent notices during plugin uninstall 2013-08-26 07:53:55 +02:00
Damyon Wiese
1b9db0af41 Merge branch 'mdl26_MDL-29004_wiki-fix-images-in-printer-friendly-view' of https://github.com/brki/moodle 2013-08-26 13:50:20 +08:00
Marina Glancy
46ecaa5827 MDL-41127 Remove the quick category move dropdowns if page is too big 2013-08-26 15:40:24 +10:00
Petr Škoda
835f58eb7e MDL-41245 fix new addon redirect regression 2013-08-26 07:31:40 +02:00
Dan Poltawski
8ba9df5862 Merge branch 'MDL-41249-master' of git://github.com/damyon/moodle 2013-08-26 13:11:04 +08:00
Damyon Wiese
97c91725d1 Merge branch 'MDL-41380-master' of https://github.com/mr-russ/moodle 2013-08-26 12:42:15 +08:00
Dan Poltawski
6c416558da Merge branch 'w35_MDL-41022_m26_unittests3' of https://github.com/skodak/moodle 2013-08-26 12:23:16 +08:00
Sam Hemelryk
c3d2fbf9cd MDL-40931 useragent: separated user agent functionality into a lib
This commit moves user agent related functionality out of several
core libraries and combines it into a more manageable class.
All core uses are converted and functions deprecated in favor
of the new class.
2013-08-26 13:59:19 +12:00
Damyon Wiese
2d55bee191 Merge branch 'wip-MDL-41106-m26' of git://github.com/samhemelryk/moodle 2013-08-26 09:43:06 +08:00
Damyon Wiese
3cb75dd1fb MDL-36803 tinymce: Version bump for js changes 2013-08-26 09:29:06 +08:00
Damyon Wiese
8920b2e288 Merge branch 'MDL-36803-m' of https://github.com/andrewnicols/moodle 2013-08-26 09:27:57 +08:00
Dan Marsden
c7e6fb6c8d MDL-35380 SCORM: improve check for imsmanifest file and consolidate into a single function. 2013-08-26 13:06:59 +12:00
Sam Hemelryk
85008bedd5 MDL-41106 cache: several fixes for the session cache.
This issue makes several fixes for the session loader and the session store.
 * maxsize argument now works for session caches.
 * fixed performance hole when interation occurs frequently.
 * fixed cache purge bug occuring when multiple caches are defined before being used.
 * improved lastaccess handling.

Big thanks to Marina who contributed the following commits:
 * Always make sure the elements in cache are sorted so we need to remove only elements in the beginning of array
 * Remove expired elements from session store to free memory
 * Minor bug fixes
2013-08-26 09:15:57 +12:00
Sam Hemelryk
4d5c7cb0d8 MDL-41081 navigation: added unit tests for navbar::prepend 2013-08-26 08:52:35 +12:00
Sam Hemelryk
c16b882bcd MDL-41081 navigation: added means to prepend to the navbar. 2013-08-26 08:52:35 +12:00
Sam Hemelryk
141d7a3f0c MDL-41213 bootstrap: fixed sizing of filepicker selected file licence selector 2013-08-26 08:40:26 +12:00
Sam Hemelryk
22c943b33b MDL-41213 filepicker: corrected outline of selected file dialogue 2013-08-26 08:40:11 +12:00
Sam Hemelryk
4c51269061 MDL-40249 bootstrap: activity chooser now enabled for bootstrap based themes 2013-08-26 08:33:26 +12:00
Mary Evans
f021743ecb MDL-41175 themes: Add/remove group members page broken on small screens. 2013-08-25 16:56:37 +01:00
Damyon Wiese
64450444c4 MDL-41149 assign: Group submission updates emailed to wrong person
grade_item_update was altering the userid in the submission record
instead of cloning it. This meant only the last member of a group
recieved all notifications meant for other students in the group.
2013-08-25 22:16:34 +08:00
Damyon Wiese
b5711fe527 MDL-41249 assign: Restore step missing gradingform mapping
Thanks to Matthieu Raggett for the report and the solution.
2013-08-25 21:20:53 +08:00
Matteo Scaramuccia
a94bc886bb MDL-41410 Caching: move comment to the appropriate place.
MDL-38162 fixes the issue about testing the connection to the memcached
daemon, which means testing once the connection to the pool of servers
and not to each of the servers while being added to the pool.
It misses to move the comment to that code too.
2013-08-25 14:00:47 +02:00
Nadav Kavalerchik
772b01f4a7 MDL-39682 Forms, File Picker, Themes: Fix alignment of Form's Labels and Input elements in RTL mode (theme/clean) 2013-08-25 01:18:42 +03:00
Gareth J Barnard
44877c48d0 MDL-40321 theme_bootstrapbase: Remove URL's from printed pages. 2013-08-24 22:50:13 +01:00
Petr Škoda
686d4ec921 MDL-41022 cleanup core_grade_scale_testcase 2013-08-24 16:21:09 +02:00
Petr Škoda
c952e0911d MDL-41022 cleanup core_grade_item_testcase 2013-08-24 16:21:01 +02:00
Petr Škoda
78953f03fd MDL-41022 cleanup core_grade_grade_testcase 2013-08-24 16:20:53 +02:00
Petr Škoda
59c50aff20 MDL-41022 cleanup core_grade_category_testcase 2013-08-24 16:19:25 +02:00
Petr Škoda
401c82d7a7 MDL-41022 cleanup core_test_generator_testcase 2013-08-24 16:18:19 +02:00