Meirza
e4b24bdd79
MDL-77299 question: Added class properties that are not declared.
...
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
Co-authored-by: Tim Hunt <t.j.Hunt@open.ac.uk>
2023-03-01 10:09:09 +07:00
Tim Hunt
4484757021
MDL-76843 quiz: fix statistics questions for missing questions
2023-02-22 14:30:23 +00:00
Tim Hunt
837d1cbf52
MDL-76843 questions behat: enhancements requried to test this issue
...
* New steps to set up certian sorts of broken test data.
* Fix qtype_essay_question::un_summarise_response().
2023-02-22 14:30:22 +00:00
Andrew Nicols
6b05cf75a8
Merge branch 'MDL-76582-master' of https://github.com/NashTechOpenUniversity/moodle
2023-02-16 11:25:11 +08:00
Andrew Nicols
ea1f5eba27
Merge branch 'MDL-76904-master' of https://github.com/NashTechOpenUniversity/moodle
2023-02-09 12:04:21 +08:00
Andrew Nicols
c7a1f4c748
Merge branch 'MDL-77018' of https://github.com/timhunt/moodle
2023-02-09 10:50:58 +08:00
Paul Holden
85bb12214d
Merge branch 'MDL-77090' of https://github.com/timhunt/moodle
2023-02-03 14:46:48 +00:00
Tim Hunt
484828957a
MDL-77090 questions: regrade of interactive attempts lose tries count
...
The behaviour-specific data was getting corrupted when the regrade
recreated the first step, because $oldstep->get_behaviour_data() was
stripping off the leading '-' characters from the names, and they were
not being added back.
2023-02-02 14:34:19 +00:00
hieuvu
1912982e95
MDL-76904 question: Keep question highlight in url
2023-01-31 16:33:32 +07:00
Tim Hunt
a344e7a3b4
MDL-77018 qbank_statistics: only load stats for contexts that exist
...
Also, pre-load the contexts for efficiency.
2023-01-27 20:51:05 +00:00
Andrew Nicols
7bf34d9982
Merge branch 'MDL-75978-master' of https://github.com/JBThong/moodle
2023-01-27 12:24:53 +08:00
Andrew Nicols
ecc2a8775a
Merge branch 'MDL-69164-master' of https://github.com/JBThong/moodle
2023-01-24 11:45:27 +08:00
Andrew Nicols
e76b1bcd5e
MDL-76362 qtype_numerical: Fix bug in phpdoc
2023-01-23 09:15:54 +08:00
Andrew Nicols
771b49c9ac
MDL-76362 qtype_calculated*: Address issues with null strings
2023-01-23 09:15:54 +08:00
Andrew Nicols
b7710dbaf4
MDL-76362 qtype: Update formatting of qtype_calculated* upgradelib
2023-01-23 09:15:54 +08:00
Andrew Nicols
b4103db72e
MDL-76362 qtype_numerical: Support empty units for apply_units
2023-01-23 09:15:54 +08:00
Andrew Nicols
913430f144
MDL-76362 qtype_numeric: Refactor answer tests
2023-01-23 09:15:54 +08:00
Andrew Nicols
32b45433bb
MDL-76362 question: Add test for number(null)
2023-01-23 09:15:54 +08:00
Andrew Nicols
5c2d98efcd
MDL-76362 question: Refactor question number unit tests
2023-01-23 09:15:54 +08:00
Marina Glancy
b0a83aa7bd
MDL-76362 various: Avoid passing nulls to functions that don't allow nulls
...
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
2023-01-23 09:15:54 +08:00
Ilya Tregubov
42a2b973ce
Merge branch 'MDL-76870-master' of https://github.com/lameze/moodle
2023-01-19 11:14:46 +08:00
Andrew Nicols
a3cc26f8bb
MDL-76583 core: Update uses of external_* classes
2023-01-19 07:34:09 +08:00
Tien Nguyen
5863659d79
MDL-69164 Question: Convert question/qengine.js to AMD modules
2023-01-18 11:24:38 +07:00
Simey Lameze
bb0aeafb25
MDL-76870 question: change assertion to assertEqualsCanonicalizing
...
By using that assertion the arrays will be sorted before comparison
preventing any Oracle sorting related failures.
Credits for the solution go to Tim Hunt!
2023-01-13 18:12:48 +08:00
Tim Hunt
3b23ff6fec
MDL-76810 redirect handling: ensure return URLs are properly sanitised
2023-01-11 11:42:28 +08:00
Andrew Nicols
6f1c9d3b53
Merge branch 'MDL-76614' of https://github.com/timhunt/moodle
2023-01-11 10:32:42 +08:00
Marina Glancy
b1c97381b4
MDL-76356 various: avoid implicit conversion to int
...
PHP before version 8.1 automatically converted to int if the function
parameter (or array key) is expected to be int. PHP 8.1 shows notice in
this case
2023-01-10 15:27:11 +01:00
hieuvu
2b6bf085af
MDL-76582 question: Allow response filearea to have different pattern
2023-01-09 09:26:52 +07:00
Tim Hunt
a9f8547599
MDL-76614 quiz: rename quiz => mod_quiz\quiz_settings
2023-01-06 14:35:54 +00:00
Tim Hunt
ae6a1c0391
MDL-76614 quiz: clean up the quiz_attempt class
2023-01-06 14:35:52 +00:00
Tim Hunt
5682c8c70e
MDL-76614 quiz: move class quiz_attempt => mod_quiz\quiz_attempt
...
I thought about renaming the class to just plain attempt, but I
acutally think quiz_attempt makes it clearer what this is. Also
not changing the name massively reduces the pain for everyone
updating their code (including me right now!)
2023-01-06 14:35:51 +00:00
Sara Arjona
4759dbe119
Merge branch 'MDL-76308-master' of https://github.com/BruceGoodGuy/moodle
2023-01-03 14:12:53 +01:00
Paul Holden
cd2fc29712
Merge branch 'MDL-53137-master' of https://github.com/lucisgit/moodle
2023-01-03 12:14:30 +00:00
Sara Arjona
ac023fbfb2
Merge branch 'MDL-76106-master' of https://github.com/NashTechOpenUniversity/moodle
2023-01-02 13:07:34 +01:00
Ilya Tregubov
e93d2b0cbe
Merge branch 'MDL-76399' of https://github.com/paulholden/moodle
2022-12-29 09:40:51 +07:00
Tony Butler
2970988674
MDL-53137 qtype_numerical: Swap geo tolerance limits for -ve answers
2022-12-22 15:31:12 +00:00
Paul Holden
a48f53ec1c
Merge branch 'MDL-75965-master' of https://github.com/HuongNV13/moodle
2022-12-22 12:24:57 +07:00
Thong Bui
4dc5d9e97f
MDL-75978 Quiz\D&D: on mobile, a moving line-wrap can bork the question
2022-12-22 10:08:29 +07:00
Huong Nguyen
fc7ecd4c73
MDL-75965 question_multichoice: Misalignment of feedback icons
2022-12-21 13:39:24 +07:00
Paul Holden
5be3686da6
Merge branch 'MDL-72906' of https://github.com/tdjones/moodle
2022-12-19 10:23:03 +00:00
Paul Holden
5185558105
MDL-76399 question: switch to appropriate Behat step for selects.
2022-12-16 13:08:56 +00:00
Paul Holden
d73a92ca4a
Merge branch 'MDL-76026' of https://github.com/AnupamaSarjoshi/moodle
2022-12-16 09:53:40 +00:00
Tim Hunt
8cbc6acb17
MDL-74923 quiz: move report base classes to local folder
2022-12-14 22:38:11 +00:00
Anupama Sarjoshi
89287ec744
MDL-76026 Question bank: Fix errors related to categories renaming
...
This part of the code in 'question_category_object.php' 'update_category' method was used before Moodle 4.0 version for renaming
the random questions in an updated category. For Moodle 4.0 and later versions, it is unnecessary as the details of
random questions are no more stored in 'question' table but in 'question_set_references' table.
The method call move_question_set_references handles the same.
2022-12-13 18:16:52 +00:00
hieuvu
0f5c8f020d
MDL-76106 qtype_ddmarker: fix the missing maker issue.
...
We will not calculate old maker position again and using old data.
This will make sure the position of makers is correct
when the background image is smaller than dropzone.
2022-12-12 20:32:43 +07:00
Khoa Nguyen Dang
315efa2db2
MDL-76308 Question\D&D: The draggable area is slim characters to select
2022-12-12 14:02:56 +07:00
Trevor Jones
c49806941c
MDL-72906 Quiz: Prevent scrollbar on multichoice
...
Remove negative margin from the "clear my choice" anchor.
With the negative margin, when the containing box height is calculated
the anchor's hidden style overflows beyond the boundary and triggers
the overflow:auto to add a scroll bar.
2022-12-07 10:24:34 -07:00
Anupama Sarjoshi
9e77d14a7b
MDL-76550 Quiz and qbank: Fix display of Category and question names
2022-12-05 11:48:43 +00:00
hieuvu
ff342087da
MDL-76106 qtype_ddmarker: Improve loading consistency.
...
Wait for the image to load completely before running the js.
2022-12-02 16:14:23 +07:00
Ilya Tregubov
05535e38df
Merge branch 'MDL-76497-master' of https://github.com/junpataleta/moodle
2022-12-01 08:56:09 +03:00