Commit graph

100913 commits

Author SHA1 Message Date
Tim Hunt
9216860b88 MDL-71009 question bank: escape idnumbers when displayed 2021-02-26 12:46:32 +00:00
Eloy Lafuente (stronk7)
08ae245926 MDL-70876 php80: 5th param removed from custom error handlers
It was deprecated in php72 and now it's gone.

Have used this regexp to find all the uses in core:

ag set_error_handler | uniq

And then checked all them manually, that parameter was not
being used in the 3 methods where we are removing it.
2021-02-26 13:08:27 +01:00
Eloy Lafuente (stronk7)
0dea9a80c8 MDL-68735 env: Moodle 3.8.x, 3.9.x and 3.10.x do not support PHP 8.0 2021-02-26 13:07:59 +01:00
Marina Glancy
a7553de7ad MDL-70877 php: remove final functions __clone and __wakeup
Implementing these functions as final does not prevent the object to be
cloned or serialized, so the comment to them was wrong.
However having these functions not public breaks in PHP 8.0.
It still does not make sense to clone or serialise file_system or external_settings classes
but there are a lot of classes in moodle that should not be cloned, no reason to have
a specific solution here.
2021-02-26 13:07:52 +01:00
Eloy Lafuente (stronk7)
599567977f MDL-70457 forms: php74 fix for the (not used in core) date element
Curly brackets to access by index to strings or arrays is
deprecated since php74.
2021-02-26 11:55:24 +01:00
Amaia Anabitarte
3feafb1a4c MDL-67119 core_analytics: Analyse users once per course
User's activity in a course should be analysed only once
no matter the number of enrolments the user has in that course.
2021-02-26 11:50:16 +01:00
David Matamoros
9b8c45e0d6 MDL-70941 contentbank: fix empty equality check when renaming content 2021-02-26 11:50:09 +01:00
Jun Pataleta
95dd305cc6 weekly release 4.0dev 2021-02-26 13:42:40 +08:00
Jun Pataleta
b80b050624 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2021-02-26 13:42:36 +08:00
Marina Glancy
465d1ef495 MDL-70921 repository: filter function can not accept argument by ref
PHP8.0 shows error that filter function accepts value by reference
The nested filtering was never working but also this function was never called on a tree with sub-levels,
so this logic is now removed
2021-02-25 18:24:52 +01:00
David Mudrák
0c9eaeff59 MDL-70964 lang: Use the fixed strings in tests 2021-02-25 16:20:58 +01:00
Helen Foster
422e70e308 MDL-70964 lang: Import fixed English strings (en_fix) 2021-02-25 16:18:57 +01:00
Jun Pataleta
2024a32283 Merge branch 'MDL-70169-master' of git://github.com/lameze/moodle 2021-02-25 12:30:22 +08:00
Jun Pataleta
e85b1f9c0f Merge branch 'MDL-70768-langpack-admin' of https://github.com/brendanheywood/moodle 2021-02-25 11:32:36 +08:00
AMOS bot
d6536d6fc1 Automatically generated installer lang files 2021-02-25 00:07:45 +00:00
Paul Holden
7aa234db32 MDL-69883 message: fix lazy loading of conversations.
Set max-height on each container section rather than the container
itself, so that each can respond to the scrollBottom event within
the lazy loading module (which handles the overflow itself).
2021-02-24 22:01:03 +00:00
Paul Holden
73bffed8f6 MDL-70995 user: format group names in course participants filter. 2021-02-24 19:22:21 +00:00
Iñigo Zendegi
df9eefacef MDL-69097 mod_forum: Apply filters to whole forum grading 2021-02-24 17:08:34 +01:00
Víctor Déniz
f86591b516 Merge branch 'MDL-51111-muc-reset' of https://github.com/brendanheywood/moodle 2021-02-24 14:07:33 +00:00
Shamim Rezaie
9317849257 MDL-70287 core_payment: Redirect user to the successurl after payment 2021-02-24 22:44:10 +11:00
Shamim Rezaie
51b73e431e MDL-70287 core_payment: Add get_success_url to service_provider 2021-02-24 22:44:10 +11:00
Shamim Rezaie
03b9d60b8e MDL-70287 core_payment: Improving existing and missing phpdocs 2021-02-24 22:42:03 +11:00
Eloy Lafuente (stronk7)
aa1c493a2a Merge branch 'MDL-70828-master' of git://github.com/abgreeve/moodle 2021-02-24 11:14:25 +01:00
Adrian Greeve
cb69d6389c MDL-70828 performance: Allow session locking issue to be turned off.
If a developer has debugging on then they will recieve all debugging
messages for locking whether wanted or not. We already have a setting
to display these messages.
2021-02-24 11:26:08 +08:00
Andrew Nicols
972e6ffe47 MDL-70987 core_form: Use correct id for elementid during validation
The id of the formid was being passed instead of the elementid.
2021-02-24 09:05:38 +08:00
Eloy Lafuente (stronk7)
6cf59943ca Merge branch 'MDL-52817' of git://github.com/paulholden/moodle 2021-02-23 19:07:56 +01:00
Eloy Lafuente (stronk7)
90f1c55191 MDL-70314 lib: Remove a few more hidden files and add instructions 2021-02-23 18:40:29 +01:00
Eloy Lafuente (stronk7)
e5c163a48b Merge branch 'MDL-70314' of https://github.com/Chocolate-lightning/moodle 2021-02-23 18:33:29 +01:00
Eloy Lafuente (stronk7)
a3bd2b3357 Merge branch 'MDL-70920-master' of git://github.com/marinaglancy/moodle 2021-02-23 17:43:32 +01:00
Sara Arjona
2ccd242538 MDL-67974 core_badges: Recovered expired stamp
Expired stamp icon displayed over the badge images has been added
again to CSS (it was lost at any point).
2021-02-23 15:26:25 +01:00
Sara Arjona
5b4204a584 MDL-67974 core_badges: Badge expiry date when hover
Text displayed for expired badges when the user hovers over the
warning (!) icon has been fixed in the "Issued badge information"
page.
2021-02-23 15:23:56 +01:00
Víctor Déniz
534eae88d7 Merge branch 'MDL-70038-master' of https://github.com/jpahullo/moodle 2021-02-23 11:14:14 +00:00
Jordi Pujol Ahulló
96557076a2 MDL-70038 assign: add suport for pdftoppm tool
pdftoppm (from poppler-utils package) is several orders of
magnitude quicker than ghostscript extracting PNG images
from PDF documents.

We add support for this tool and use it whenever set up,
or using gs as before if missing.

Revisited code with peer review comments. In particular:

1. Make default path for pdftoppm empty string.
2. Fix a typo on the method description for get_gs_command_for_image.
3. Added more information why is useful pdftoppm into string pathtopdftoppm_help.
4. Check that path for pdftoppm is executable to prevent errors. Otherwise, use gs.
2021-02-23 08:07:20 +01:00
Brendan Heywood
300213ee2e MDL-70424 auth: Avoid random changes to $CFG->auth 2021-02-23 11:40:57 +11:00
Eloy Lafuente (stronk7)
c79778bf9f Merge branch 'MDL-43697-master' of https://github.com/praxisdigital/moodle 2021-02-22 23:09:53 +01:00
Marina Glancy
ef99a587d3 MDL-70967 enrol_meta: fix error in unittest 2021-02-22 18:04:14 +01:00
Marina Glancy
b88f1a84bf MDL-70901 core: @ no longer masks errors in PHP 8.0 2021-02-22 16:18:46 +01:00
Marina Glancy
2d059d1657 MDL-70901 cache: @ no longer masks errors in unlink in php 8 2021-02-22 16:17:49 +01:00
Marina Glancy
a1a72f720e MDL-70901 core_files: @ does no mask errors in php8 anymore 2021-02-22 16:17:49 +01:00
Marina Glancy
3e076d8cff MDL-70901 backup: check handle before calling fclose()
@fclose no longer catches error in PHP 8.0 when handle is null
2021-02-22 16:17:49 +01:00
Sara Arjona
49c5b85eba MDL-63961 core_badges: Use high-resolution image
High-resolution image for a badge (f3) should be sent to external
backpacks through JSON and WS methods.
Besides, when a badge is cloned, the high-resolution image should be
used to avoid the copied looks blurry.
2021-02-22 12:43:06 +01:00
Mark Nelson
1b7236cbd5 MDL-70125 core_grade: do not change overridden status during regrading 2021-02-22 17:23:51 +08:00
Mathew May
9bd5c31d11 MDL-70314 lib: Change XLSX wrapper to no change the default styles
This is required due to changes in the base library see #1712
Summary is that if a column already has styling it can't be overpowered.
2021-02-22 15:32:09 +08:00
Mathew May
d41210cf0f MDL-70314 lib: Apply Moodle specific phpspreadsheet changes 2021-02-22 15:28:40 +08:00
Mathew May
1ee8dd7f6f MDL-70314 lib: Upgrade PhpSpreadsheet to 1.16.0 2021-02-22 15:28:40 +08:00
Andrew Nicols
cffeb4b797 MDL-69259 h5pactivity: Whitespace fix 2021-02-22 12:19:18 +08:00
Andrew Nicols
6b23a271b8 Merge branch 'MDL-69259-master' of git://github.com/ilyatregubov/moodle 2021-02-22 12:06:13 +08:00
AMOS bot
23c2130505 Automatically generated installer lang files 2021-02-22 00:07:44 +00:00
Andrew Nicols
175964fbf9 Merge branch 'MDL-70879' of https://github.com/stronk7/moodle 2021-02-22 07:49:54 +08:00
Marina Glancy
f4fb91aecb MDL-70920 core: prevent calls to call_user_fun_array() with assoc array 2021-02-21 22:22:21 +01:00