moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 09:26:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
69692 commits 37 branches 540 tags 1.3 GiB
Commit graph

248 commits

Author SHA1 Message Date
David Monllao
e9af3ed361 MDL-42013 behat: I should (not)? see checking visibility 
Only for non-Javascript tests. If the step
is named I should/should not see whatever
is makes sense that has to be visible.
 2013-10-10 18:40:29 +08:00
Damyon Wiese
869dd1fc6c Merge branch 'MDL-29663_alt' of https://github.com/merrill-oakland/moodle 2013-10-09 09:39:09 +08:00
Eric Merrill
bd8f5d459d MDL-29663 forum: Replace constant FORUM_TRACKING_ON with FORUM_TRACKING_FORCED 
Commit for MDL-29663 that renames the FORUM_TRACKING_ON constant
to FORUM_TRACKING_FORCED to allow easier and more consistant reading.

FORUM_TRACKING_ON retained but marked depreciated.
 2013-10-08 08:04:55 -04:00
Sam Hemelryk
8aa3aa3dfd MDL-31830 course: management behat tests corrected after fixes 2013-10-07 17:34:09 +13:00
Sam Hemelryk
5aff38e4d8 MDL-31830 course: renamed functions for consistency 
* course_move_by_one => course_change_sortorder_by_one
* course_move_after_course => course_move_after_course
* helper::action_course_move_after_course  => helper::action_course_change_sortorder_after_course
* helper::action_course_moveup 		   => helper::action_course_change_sortorder_up_one
* helper::action_course_movedown 	   => helper::action_course_change_sortorder_down_one
* helper::action_course_moveup_by_record   => helper::action_course_change_sortorder_up_one_by_record
* helper::action_course_movedown_by_record => helper::action_course_change_sortorder_down_one_by_record
* helper::action_category_movedown         => helper::action_category_change_sortorder_down_one
* helper::action_category_movedown_by_id   => helper::action_category_change_sortorder_down_one_by_id
* helper::action_category_moveup 	   => helper::action_category_change_sortorder_up_one
* helper::action_category_moveup_by_id     => helper::action_category_change_sortorder_up_one_by_id
* coursecat::move_by_one 	           => coursecat::change_sortorder_by_one
 2013-10-07 10:22:36 +13:00
Sam Hemelryk
67e1f26874 MDL-31830 course: several small code improvements 
* I can rebase this for you/the integrator before it goes in for sure no probs :)
* Fixed double phpdoc block of course_change_visibility
* Moved permission checks out of course_move_after_course and into helper function.
* Reviewed setType calls for editcategory_form.php.
* Reviewed all uses of can_resort and added more specific methods.
* Fixed method mentioned in exception for resort methods.
* Converted calls to fetch courses to call get_course.
* Exceptions now thrown when trying to move courses and problems arise.
* Fixed unnecessary namespace hinting in core_course_management_renderer.
* Abstracted common logic of can_resort_any and can_change_parent_any.
* Removed check for system level capability from has_manage_capability_on_any.
* Reviewed debugging calls I've introduced.
 2013-10-07 10:22:36 +13:00
Sam Hemelryk
a3b7439ff2 MDL-31830 course: added behat test of category creation 2013-10-07 10:22:36 +13:00
Sam Hemelryk
5dc361e16e MDL-31830 core_course: new course category management interface 
* Implemented a new course and category management page.
* Deprecated the old management interface.
* Unit tests to cover the new API and core functions.
* Behat tests to cover the new interface.
 2013-10-07 10:21:41 +13:00
rwijaya
faf6010b10 MDL-40829: courses heading: remove headerblock class from header and fix heading levels. 
Also, changing h3 classname from name to categoryname.
    Added note to theme/upgrade.txt to describe the heading level changes.
 2013-10-02 09:46:26 +13:00
Ankit Agarwal
b9b994c7d2 MDL-39959 events: Add unit tests for course module events 
test_course_module_created_event()
test_course_module_created_event_exceptions()
test_course_module_updated_event()
test_course_module_updated_event_exceptions()
test_course_module_deleted_event()
test_course_module_deleted_event_exceptions()
 2013-09-16 13:42:37 +08:00
Rajesh Taneja
3a11e2d2d6 MDL-41557 Events: Fixed event data snapshot to save valid data 2013-09-13 16:05:23 +08:00
Marina Glancy
e2e9cb6a14 MDL-37028 Fixed bug, orphaned modules are moved to the 0-section 2013-09-13 10:28:52 +10:00
Damyon Wiese
749ce98e63 MDL-37028 Integrity check for course modules and sections 
This commit reinstates:
commit 0bac49dc19
Author: Marina Glancy <marina@moodle.com>
Date:   Tue Sep 3 17:14:13 2013 +1000

    MDL-37028 Integrity check for course modules and sections

    If section mentioned in 'orphaned' module does not exist module is added to the first available section. Also corrected whitespaces

commit 1f0a9ce48b
Author: Marina Glancy <marina@moodle.com>
Date:   Mon Aug 12 14:06:48 2013 +1000

    MDL-37028 Integrity check for course modules and sections

    created function, unittest, build-in quick integrity check on each call to rebuild_course_cache()
    also added CLI script
 2013-09-11 10:47:49 +08:00
Eloy Lafuente (stronk7)
34ac96bf6d Merge branch 'wip-MDL-41508-master' of git://github.com/marinaglancy/moodle 2013-09-10 14:09:34 +02:00
Damyon Wiese
eceecb72f3 Revert "MDL-37028 Integrity check for course modules and sections" 
This is failing unit tests.

This reverts commit 0bac49dc19.
This reverts commit 1f0a9ce48b.
 2013-09-10 14:34:07 +08:00
Damyon Wiese
4fae13bb5e Merge branch 'wip-MDL-37028-master' of git://github.com/marinaglancy/moodle 2013-09-10 12:51:33 +08:00
Marina Glancy
4a3fb71c4f MDL-41436 Removing references to fields course.modinfo, sectioncache 
Also add the field cacherev to the lists of default fields in course retrieval functions
 2013-09-10 14:11:51 +10:00
Mark Nelson
c3bf6181aa MDL-41417 course: allow the use of duplicated idnumbers if they existed before fix 2013-09-06 15:18:23 +08:00
Francis Devine
5536a5617c MDL-41417 course: prevent duplicate idnumbers being used when updating a course 2013-09-06 11:34:04 +08:00
Eloy Lafuente (stronk7)
58c80b03a8 Merge branch 'MDL-40566_master' of git://github.com/dmonllao/moodle 2013-09-03 20:38:53 +02:00
Marina Glancy
0bac49dc19 MDL-37028 Integrity check for course modules and sections 
If section mentioned in 'orphaned' module does not exist module is added to the first available section. Also corrected whitespaces
 2013-09-03 17:14:13 +10:00
Dan Poltawski
2793260fc0 MDL-41256 course tests: improve robustness 
* Fail if an exception isn't recieved
* Don't allow the possibility of an undefined variable being tested
 2013-09-03 11:01:15 +08:00
Dan Poltawski
c6569641e7 Merge branch 'MDL-41256-master' of https://github.com/mackensen/moodle 2013-09-03 10:51:27 +08:00
David Monllao
fcc0b5b920 MDL-40566 behat: Update features using the new options 2013-09-03 10:31:57 +08:00
Marina Glancy
aec8fe2f9b MDL-41508 move_courses() bug fix and DB query improvement 2013-08-30 16:47:25 +10:00
Marina Glancy
1f0a9ce48b MDL-37028 Integrity check for course modules and sections 
created function, unittest, build-in quick integrity check on each call to rebuild_course_cache()
also added CLI script
 2013-08-30 16:41:13 +10:00
Marina Glancy
d55f05ef43 MDL-41181 function moveto_module does not modify properties of object 
instead it returns the new value for module visibility
 2013-08-27 15:36:40 +10:00
Marina Glancy
955d91c698 MDL-41181 No need to reset modinfo cache after moveto_module() 
it is already reset inside the function
 2013-08-27 15:36:21 +10:00
Charles Fulton
9930e4267c MDL-41256 course: improved debugging on course creation 2013-08-26 06:59:33 -07:00
Mark Nelson
9e2d9135f6 MDL-39957 course: added missing assertions for events 
This occurred when an add_to_log call, with no associated legacy event,
was replaced with a new event. We should still call assertEventLegacyData
even though there is no legacy event data to compare with, simply ensure
that the expected data was passed.
 2013-08-20 15:59:11 +08:00
Damyon Wiese
5a10d2a7ae Merge branch 'wip-mdl-40043' of git://github.com/rajeshtaneja/moodle 
Conflicts:
	course/tests/courselib_test.php
	lang/en/moodle.php
 2013-08-20 14:40:42 +08:00
Rajesh Taneja
ed29bf0f66 MDL-40043 Events API: Added course_section_updated event to replace add_to_log 2013-08-20 14:07:35 +08:00
Mark Nelson
e5959771b2 MDL-39957 course: added PHPUnit assertions for when a course_updated event is triggered by moving a course 2013-08-15 18:14:08 +08:00
Mark Nelson
02cbb621d6 MDL-39957 course: added PHPUnit test for the new course_restored event 2013-08-15 18:14:08 +08:00
Mark Nelson
7240cd92f9 MDL-39957 course: added PHPUnit test for the new course_category_deleted event 2013-08-15 18:14:08 +08:00
Mark Nelson
ec8f23de3b MDL-39957 course: added PHPUnit test for the new course_content_deleted event 2013-08-15 18:14:08 +08:00
Mark Nelson
bc3c5b222a MDL-39957 course: added PHPUnit test for the new course_deleted event 2013-08-15 18:14:07 +08:00
Mark Nelson
4fd391d515 MDL-39957 course: added PHPUnit test for the new course_updated event 2013-08-15 18:14:07 +08:00
Mark Nelson
35ad79e20d MDL-39957 course: added PHPUnit test for the new course_created event 2013-08-15 18:14:07 +08:00
Sam Hemelryk
615cf2d15a Merge branch 'MDL-41045-master' of git://github.com/sammarshallou/moodle 2013-08-13 10:19:34 +12:00
sam marshall
5523c34462 MDL-41045 course_add_cm_to_section should not test for sections unless necessary 2013-08-07 17:17:04 +01:00
Petr Škoda
8252b7c291 MDL-40901 standardise core test case class and file names 
This finally allows us to type only the class name when executing individual core test cases.
 2013-08-04 22:10:31 +02:00
Sam Hemelryk
ea5a01fbe5 MDL-39814 frontend: pre-integration fixes: 
* Fixed IE8 display of icons.
* Fixed blocks using course renderer.
* Fixed behat tests.
* codecheckers fixes
* Removed alt from icons with descriptive text
* Tweaked actionmenu initialisation for performance
 2013-07-30 16:15:58 +12:00
Sam Hemelryk
10fc156933 MDL-39814 frontend: added options to disable new action menus 
Also:
 * Tidied up patch as per peer-reviews
 2013-07-30 16:15:52 +12:00
Sam Hemelryk
e5de4933b0 MDL-39814 frontend: redeveloped overlay to correct tab-flow 
Also:
 * fixed zindex issue + spinner placement
 * added notes to course format and theme upgrade texts
 * fixed behat tests after action menu changes
 2013-07-30 16:15:19 +12:00
David Monllao
3897608152 MDL-39635 behat: XPath cleanups 
- Escaping steps arguments redirected to other steps
- Adding normalized-space() in all contains() assertions
- General xpaths review
- Convering provided xpath text strings to xpath literals
  to avoid problems with arguments containing both single
  quotes and double quotes
 2013-07-19 10:02:36 +02:00
David Monllao
dedb973878 MDL-39635 behat: Replacing hardcoded language strings 
Using get_string() instead.
 2013-07-19 10:02:10 +02:00
Dan Poltawski
e52c1ea65d MDL-40604 course: add test to cover course_delete_module 2013-07-17 14:11:10 +08:00
Dan Poltawski
fce10644a0 MDL-40536 course: unit tests for course_external::import_course 
Basic import operations and a specific test case which identifies
a bug.
 2013-07-12 16:39:41 +08:00
Damyon Wiese
7f198356ef MDL-38359 courselib: Fix unit tests 
The courselib tests have hardcoded test data sets for forum and assign
modules that need to be updated every time we add a new feature.
 2013-06-11 16:20:55 +08:00