Commit graph

97803 commits

Author SHA1 Message Date
Ferran Recio
9a4307dd7a MDL-67791 mod_h5pactivity: adding attempts reports 2020-05-14 15:01:26 +02:00
Sara Arjona
ccc7a30b3e Merge branch 'MDL-68200-master-take2' of git://github.com/rezaies/moodle 2020-05-14 13:10:01 +02:00
Sara Arjona
85e7049103 Merge branch 'MDL-68246-master-IR-squashed' of git://github.com/mickhawkins/moodle 2020-05-14 12:31:29 +02:00
Ferran Recio
ebec56dac0 MDL-67791 mod_h5pactivity: adding review attempts capability 2020-05-14 11:54:33 +02:00
Sara Arjona
0fd6b977b6 Merge branch 'MDL-68241-master' of git://github.com/ferranrecio/moodle 2020-05-14 09:55:35 +02:00
Andrew Nicols
d525ac4b8d MDL-68246 user: Add participants_search role & keyword unit tests
Created the participants_search unit testing file, including
tests for role, keywords, status and enroment method filtering.

Co-authored-by: Michael Hawkins <michaelh@moodle.com>
2020-05-14 15:47:34 +08:00
Michael Hawkins
86e71acc0c MDL-68246 user: Adding the participants_search class
This class introduces support for multiple values per filter to the
participants page.
2020-05-14 15:47:34 +08:00
Michael Hawkins
44e47eff9a MDL-68246 lib: Prepare for participants filter multiple groups support
These function updates are in preparation for the participants_search
class, which will be used to support multiple values per filter when
filtering the participants page.
2020-05-14 15:47:52 +08:00
Michael Hawkins
036b7cda10 MDL-68246 lib: Grouplib coding standards and consistency improvements 2020-05-14 15:47:34 +08:00
Ferran Recio
4d0241e488 MDL-68241 mod_h5pactivity: remove MOODLE_INTERNAL 2020-05-14 09:13:56 +02:00
Ferran Recio
e28b40695d MDL-68241 mod_h5pactivity: add grading attempts options 2020-05-14 09:13:56 +02:00
Adrian Greeve
b75a184312 Merge branch 'MDL-68498-master' of git://github.com/mihailges/moodle 2020-05-14 14:13:55 +08:00
Andrew Nicols
84d8b45fdf MDL-68677 core: Enable prefetching when cachejs is disabled
With the templaterev issue resolved we should enable the prefetch module
when cachejs is enabled to avoid a different experience when cachejs is
enabled vs. disabled.

Previously there was little point in doing this due to a range of other
bugs (string normalisation, and misuse of templaterev).

With these issues resolved we should enabel the caching.
2020-05-14 14:10:55 +08:00
Andrew Nicols
b9dec51ab4 MDL-68677 core: Correct usage of templaterev for caching templates
The M.cfg.templaterev variable should only be used to present persistent
caching, not caching of content within the same page load.

Preventing caching of same-page content makes it difficult to develop
for real user experiences as content is slow to load and does not give a
realistic and consistent loading experience.

This change affects the loading of partials specifically which notably
includes the loading spinner. Without this patch the loading icon is
often not seen at all because it does not load in a timely fashion and
the content being loaded is loaded first.
2020-05-14 14:10:55 +08:00
David Mudrák
866ce1fbe9 MDL-68645 output: Make other generators fail if they init the output too
Identically to what we've added to the module generators, let's raise a
coding exception if generating a block or a repository triggers the
theme and output initialisation.
2020-05-14 07:55:19 +02:00
Jun Pataleta
2a202f3b97 Merge branch 'MDL-68529' of https://github.com/Chocolate-lightning/moodle 2020-05-14 12:51:35 +08:00
Dmitrii Metelkin
142a02308d MDL-68656 quizaccess_seb: refactor test to use helper trait 2020-05-14 13:11:07 +10:00
Dmitrii Metelkin
355cf68893 MDL-68656 quizaccess_seb: remove incorrect namespace 2020-05-14 11:53:30 +10:00
Dmitrii Metelkin
43302afc56 MDL-68656 quizaccess_seb: move test files 2020-05-14 11:32:43 +10:00
Víctor Déniz Falcón
6b37b6a1ba Merge branch 'MDL-68227-master' of git://github.com/sarjona/moodle 2020-05-13 17:13:11 +01:00
Víctor Déniz Falcón
ca7127ed03 Merge branch 'MDL-68697-master' of git://github.com/andrewnicols/moodle 2020-05-13 16:53:16 +01:00
Paul Holden
9965b654f8 MDL-65796 message: improve content of contact request notifications. 2020-05-13 15:40:17 +01:00
Jun Pataleta
9c09ec41d6 Merge branch 'MDL-68483-master' of git://github.com/sarjona/moodle 2020-05-13 19:33:37 +08:00
Sara Arjona
f3126f84b4 MDL-68483 contentbank: remove unneeded MOODLE_INTERNAL
These improvements were suggested by Eloy when MDL-67795 and other
content bank issues (such as MDL-67790) were integrated.
2020-05-13 13:31:30 +02:00
Sara Arjona
54ce66bd76 MDL-68483 contentbank: improve search API
These improvements were suggested by Eloy when MDL-67797 was integrated.
2020-05-13 13:31:30 +02:00
Sara Arjona
7616fbfd8e MDL-68483 contentbank: order contents by name 2020-05-13 13:31:29 +02:00
Sara Arjona
f9b6849b85 MDL-68483 contentbank: filter contents by name
Credits to Bas and Rafa for helping us to improve the UX.
Also to Amaia with her help with Behat tests.
2020-05-13 13:31:29 +02:00
Eloy Lafuente (stronk7)
6a7146fc71 Merge branch 'MDL-68314-master' of git://github.com/aanabit/moodle 2020-05-13 13:15:17 +02:00
Ruslan Kabalin
a38e1d4968 MDL-67548 core_course: Add unittests covering category deletion hooks. 2020-05-13 10:24:33 +01:00
Andrew Nicols
0e809762d4 MDL-68697 core_h5p: Store missing translations as null 2020-05-13 16:35:41 +08:00
David Mudrák
87f9e88ddd MDL-68563 filters: Fix unit test regressions
Also incrementing the plugin versions to make sure the unit test
environment is reinitialised and the tests are reliable.

Minor correction of phpdocs @package tags included.
2020-05-13 16:28:24 +08:00
Simey Lameze
4044914d17 MDL-68563 editor_atto: display emoji picker on atto toolbar
As per enabling of emoticon filters enabling emoji picker is now visible
by default on the Atto editor toolbar.
2020-05-13 16:27:05 +08:00
Simey Lameze
2a9e5ba70a MDL-68563 filter_urltolink: enable filter uppon install
Every major system that people use these days turns URLs into links automatically.

This filter was turned off by default a decade ago because of performance concerns
that do not apply any more, specially on fresh new installations.

In order to improve user experience on text editing features, the urltolink filter
will be now enabled by default in new installations.
2020-05-13 16:24:53 +08:00
Simey Lameze
5f95ea83fd MDL-68563 filter_emoticon: enable filter uppon install
Every major system that people use these days turns smiles into emoticons automatically.

This filter was turned off by default a decade ago because of performance concerns
that do not apply any more, specially on fresh new installations.

In order to improve users experience on text editing features the emoticon filter
will be now enabled by default in new installations.
2020-05-13 16:24:12 +08:00
David Mudrák
005b00dd9b MDL-68645 output: Do not apply filters when creating calendar events
Applying filters on an activity module description when using it as a
new calendar event's description is bad m'kay? We need to store the raw
text and apply the filters only when we actually display the text. That
way, filters (such as multi-language content) may actually fully work
and we do not initialise the theme and output machinery.

Additionally, we need to explicitly set the format of the description
text to HTML (because we have converted it to it already). Otherwise it
defaults to the current user's preferred editor format.

This is still a pragmatic hot-fix solution. The proper solution would be
to pass the raw text, format and embedded files.
2020-05-13 10:03:01 +02:00
Tim Hunt
f883c681ff MDL-68645 output: Make module generators fail if they init the output
The coding exception hint should say it all. Creating an activity module
should not need any output function call. It turned out it can lead to
hard-to-debug bugs and unexpected behaviour. So better to explicitly
fail and let the developer fix the code.
2020-05-13 10:03:01 +02:00
Amaia Anabitarte
66489aea0f MDL-68314 core_contentbank: Backup and restore tests 2020-05-13 09:35:58 +02:00
Amaia Anabitarte
3449e22683 MDL-68314 core_contentbank: Course content bank backup and restore 2020-05-13 09:35:58 +02:00
Jun Pataleta
51939f6feb Merge branch 'MDL-68261-cli-config-log' of https://github.com/brendanheywood/moodle 2020-05-13 10:36:54 +08:00
Mihail Geshoski
f915dcbe1a MDL-68498 core: Fix content bank links in the navigation drawer 2020-05-13 09:26:18 +08:00
Jake Dallimore
1516b80752 Merge branch 'MDL-68631' of https://github.com/jonof/moodle 2020-05-13 09:24:30 +08:00
Mihail Geshoski
cd1a878774 MDL-68498 core: Display content bank icon in nav drawer in classic theme 2020-05-13 08:42:46 +08:00
Eloy Lafuente (stronk7)
47c5108234 Merge branch 'MDL-68614-master' of git://github.com/aanabit/moodle 2020-05-13 00:09:44 +02:00
Eloy Lafuente (stronk7)
de185f1c2b Merge branch 'MDL-68417-master' of git://github.com/lameze/moodle 2020-05-12 23:20:21 +02:00
Paul Holden
56b431c2f6 MDL-68084 blocks: check capability before getting content.
Some blocks (e.g. Calendar) load additional JS modules when returning
content. We need to make sure they aren't asked to generate content
unless the user can actually view the block, or the expected content
required by the JS will not exist in the DOM and can cause exceptions.
2020-05-12 19:23:36 +01:00
Eloy Lafuente (stronk7)
d2ecc75e2f MDL-52846 tasks: complete docs and move functions to deprecatedlib
- Add MDL codes to @deprecated.
- Add @todo tag for future 4.3 phase 2 deprecation.
- Deprecate global scope functions:
  - cron_execute_plugin_type().
  - cron_bc_hack_plugin_functions().
  (moving them to deprecatelib).
- Document it in main upgrade.txt
2020-05-12 17:41:13 +02:00
Ankit Agarwal
3bdb8f4584 MDL-52846 tasks: Display developer notice for legacy cron 2020-05-12 17:38:08 +02:00
Amaia Anabitarte
ce1fe72dbd MDL-68483 contentbank: adapt to existing behat generator 2020-05-12 16:50:46 +02:00
Sara Arjona
a42a9ad997 MDL-68227 core_h5p: localize H5P editor strings
H5P editor has a folder with all supported languages in JS files.
A mechanish has been added to let users to translate them using AMOS.
That's how the translations are managed (the order how they are processed):

- If there a JS file for a language, it's loaded.
- If a string has been translated in Moodle (they are placed in
h5plib_vXXX), it will override strings loaded from the JS file.
2020-05-12 16:39:42 +02:00
Simey Lameze
d717918c87 MDL-68417 core_table: add some css styling to loading icon 2020-05-12 21:44:42 +08:00