Commit graph

90808 commits

Author SHA1 Message Date
Amaia Anabitarte
f91e884d68 MDL-60518 core_competency: Set $USER global variable for tests 2018-12-14 10:27:41 +01:00
Frédéric Massart
7dcc1e721c MDL-60518 core_user: A user with ID 0 is never a real user 2018-12-14 10:27:41 +01:00
Mirko Otto
f32c2f7c47 MDL-62756 form: Remove any click handler first.
The handler has the old state variable. Remove any click handler first.
2018-12-14 10:22:11 +01:00
Jun Pataleta
808e7c80dc MDL-64285 core: Fix environment check test
* Looping the environment results and skipping some items mean that
if a test gets skipped, the rest of the environment results won't be
tested. It's better to use a data provider for this in order to
individually test each environment result.
2018-12-14 11:22:07 +08:00
Peter
bb13181338 MDL-59629 mod_block: Set the default region in add_region
Check and update default region in add_region if none set.
2018-12-14 10:29:55 +08:00
Peter
f13544412e MDL-63512 mod_lesson: Fix video links provided in feedback 2018-12-14 10:27:12 +08:00
Jake Dallimore
c8b4ee45a4 weekly release 3.5.3+ 2018-12-14 07:51:44 +08:00
Tony Butler
773e24cad4 MDL-61633 assignfeedback_editpdf: Scroll back to top when changing pages 2018-12-13 12:21:07 +00:00
Jake Dallimore
86eb5bb7e2 Merge branch 'MDL-62624-35' of git://github.com/mihailges/moodle into MOODLE_35_STABLE 2018-12-12 16:14:04 +08:00
Damyon Wiese
55a1e8b719 MDL-63916 backup: Do not display timestamp
Convert the date+time field to a userdate for display.
2018-12-12 12:20:18 +08:00
Jun Pataleta
76570e405a Merge branch 'MDL-41507-35' of git://github.com/rezaies/moodle into MOODLE_35_STABLE 2018-12-12 11:17:05 +08:00
Shamim Rezaie
eeb374e2e6 MDL-41507 core_group: Consistent default value for FEATURE_GROUPS 2018-12-12 14:05:01 +11:00
Jake Dallimore
b4999d92d9 MDL-63887 auth_ldap: fix unclean exit from sync when users not found
We should return, not exit, and we should clean up before we do.
2018-12-12 09:43:51 +08:00
Jake Dallimore
113c94cf9a Merge branch 'MDL-63887_35' of git://github.com/markn86/moodle into MOODLE_35_STABLE 2018-12-12 09:43:45 +08:00
Jake Dallimore
583799d5b9 Merge branch 'MDL-63150-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2018-12-12 08:32:55 +08:00
Jake Dallimore
7f0903200f Merge branch 'MDL-63145-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2018-12-12 08:30:20 +08:00
Jake Dallimore
061db30ef7 Merge branch 'MDL-63147-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2018-12-12 08:25:43 +08:00
Peter
91ef3d2e40 MDL-63145 mod_page: Accept userid param as override
Accept a userid as an override in the lib function instead of
relying on $USER
2018-12-12 07:31:59 +08:00
Peter
07baf8e940 MDL-63150 mod_url: Accept a userid override in event action
Accept a userid in the event action instead of depending on $USER
2018-12-12 07:18:28 +08:00
Peter
5362c6f185 MDL-63147 mod_resource: Accept userid in resource event_action 2018-12-12 07:08:13 +08:00
Tim Hunt
2a0ee3647f MDL-63260 qtype_random: orphaned random questions should be deleted
This fix is based on some original code written by Bo Pierce.
2018-12-11 14:09:22 +00:00
Jake Dallimore
2496dc283c Merge branch 'MDL-64357_35' of git://github.com/markn86/moodle into MOODLE_35_STABLE 2018-12-11 17:45:16 +08:00
Jake Dallimore
5b10127f11 Merge branch 'MDL-63485_35' of git://github.com/markn86/moodle into MOODLE_35_STABLE 2018-12-11 17:30:10 +08:00
Mark Nelson
551975b2ac MDL-64357 ltiservice_gradebookservices: updated unit tests 2018-12-11 17:03:26 +08:00
Claude Vervoort
111998407c MDL-64357 ltiservice_gradebookservices: fix cleanup deleting lineitems 2018-12-11 17:03:26 +08:00
Damyon Wiese
7afbae7e1a MDL-64313 assign: feedback viewed event
When a student views their submission, if it has feedback create an event.
2018-12-11 14:07:23 +08:00
Jake Dallimore
7fc84f65de Merge branch 'MDL-62922-35' of git://github.com/junpataleta/moodle into MOODLE_35_STABLE 2018-12-11 12:50:58 +08:00
Jun Pataleta
6cc427e025 Merge branch 'MDL-64280-35' of https://github.com/lucaboesch/moodle into MOODLE_35_STABLE 2018-12-11 09:53:20 +08:00
Luca Bösch
1188a6e41b MDL-64280 core_outcome: Add/remove outcome buttons style. 2018-12-10 17:56:03 +01:00
Sara Arjona
9cfb533e2d MDL-63485 core_user: Allow filtering by No groups on participants page
A new optional parameter $context has been added to the
core_group::groups_get_members_join() function.
Besides, some core_group methods now accept -1 (USERSWITHOUTHGROUP) for
the groupid field.

Backport of MDL-61967.
2018-12-10 20:29:04 +08:00
Jun Pataleta
2203bf4ad4 Merge branch 'MDL-62061-35' of git://github.com/abgreeve/moodle into MOODLE_35_STABLE 2018-12-10 14:46:30 +08:00
Mihail Geshoski
82f74c8e2b MDL-62624 lesson: Fix alignment in matching questions in boost 2018-12-10 13:47:48 +08:00
Jake Dallimore
2fbae51df0 weekly release 3.5.3+ 2018-12-10 08:10:18 +08:00
Jake Dallimore
f087b00ea6 Merge branch 'install_35_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_35_STABLE 2018-12-10 08:10:17 +08:00
AMOS bot
1bfa3f5697 Automatically generated installer lang files 2018-12-07 00:09:32 +00:00
Adrian Greeve
3692fe595c MDL-62061 core_privacy: Stop directories being created.
This stops directories being created in the root directory
while running unit tests.
2018-12-06 11:39:01 +01:00
papillon326
10097b1b61 MDL-63887 auth_ldap: avoid infinite loop when search limit is reached 2018-12-06 15:40:47 +08:00
papillon326
4c7af8f17b MDL-63887 auth_ldap: changed variable names to be conform to core 2018-12-06 15:40:47 +08:00
Jun Pataleta
864374faf2 Merge branch 'MDL-64283-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2018-12-06 14:57:25 +08:00
Jake Dallimore
f6b4c923ec Merge branch 'MDL-63710-MOODLE_35' of https://github.com/ilya-catalyst/moodle into MOODLE_35_STABLE 2018-12-06 11:45:04 +08:00
Jake Dallimore
a702f2b935 Merge branch 'MDL-46783_35' of https://github.com/timhunt/moodle into MOODLE_35_STABLE 2018-12-06 10:23:50 +08:00
Ilya Tregubov
daa7d65f34 MDL-63710 repository: Delete orphaned file records. 2018-12-06 12:38:25 +11:00
Jun Pataleta
b7e4fbb246 Merge branch 'MOODLE_35_STABLE-MDL-64290-imscc-restore-temp-dir' of https://github.com/mspall/moodle into MOODLE_35_STABLE 2018-12-06 08:56:44 +08:00
AMOS bot
4745892272 Automatically generated installer lang files 2018-12-06 00:08:01 +00:00
Michael Spall
559759aa4a MDL-64290 backup imscc: Use correct tempdir for imscc restore
Use configured temp directory $CFG->tempdir instead of hard coded
$CFG->dataroot . '/temp/backup/'
Remove unused variable, $CFG
2018-12-05 11:05:44 -07:00
Tim Hunt
edb89914d8 MDL-46783 accesslib: tests for MDL-63818
MDL-46783 and MDL-63818 were originally coded on the
assumption that MDL-46783 would get integrated first. However it wasn't.
Therefore, it was not easy to add unit tests for MDL-63818
at the time, but it is now, so here they are.
2018-12-05 16:41:42 +00:00
Jun Pataleta
c2e3ca2f6c MDL-62922 core_user: Check auth mechanism before validating password
* External authentication mechanisms (e.g. via oauth2, etc.) don't store
  password in the user table, so we shouldn't be requiring password in
  such case when creating users via the core_user_create_users WS
  function.
2018-12-05 15:33:33 +08:00
Jake Dallimore
c758547bd7 Merge branch 'MDL-64198-35' of https://github.com/lucaboesch/moodle into MOODLE_35_STABLE 2018-12-05 14:31:02 +08:00
Damyon Wiese
f20b808629 Merge branch 'MDL-60267-35' of https://github.com/rogerbaba/moodle into MOODLE_35_STABLE 2018-12-05 12:56:48 +08:00
Tim Hunt
6a58779607 MDL-46783 permissions: let some moodle/ caps be overriden in all mods
The capabilities changed ('contextlevel' => CONTEXT_COURSE changed to
'contextlevel' => CONTEXT_MODULE) are:

* moodle/site:accessallgroups
* moodle/site:viewfullnames
* moodle/site:trustcontent
* moodle/site:viewuseridentity

This list came from reviewing the _get_extra_capabilities functions in
all core activities. They were all somewhat inconsistent, but I think it
makes sense that these capabilities are consistently overridable in all
activities. E.g. moodle/site:accessallgroups affects conditional
availability even if there is no other user of groups, and
moodle/site:viewuseridentity and moodle/site:viewfullnames affect the
logs report, if nothing else.

As a result of this, several _get_extra_capabilities functions are no
longer needed, and all the rest have been simplified.
2018-12-04 18:01:29 +00:00