Commit graph

9790 commits

Author SHA1 Message Date
Tim Hunt
ea906bb45c quiz reports MDL-21111 Quiz duration is reported in years if Time Finish is before Time Start
Suppose you have two load-balanced servers with badly-synchronised clocks, and
a student does a really quick quiz attempt.

Then it is possible that quiz_attemtp.timestart is greater than quiz_attemtp.timefinish.
And these columns are unsigned (on MySQL) so timefinish - timestart is compulted as
a number close to 2^64, which is about 42 times the age of the universe.

Do the subtraction in PHP instead. (But we still need to compute a duration columnin PHP
because sometimes we sort on it.)
2010-08-05 12:43:13 +00:00
Sam Hemelryk
3db7b87807 forum MDL-23671 Fixed defaults for forum maxattachments 2010-08-05 07:40:53 +00:00
Andrew Davis
8e1e3c146d survey MDL-23324 fixed an SQL error for postgres 2010-08-05 06:34:51 +00:00
Andrew Davis
3ce4270a20 survey MDL-23324 reworked the downloading of survey results 2010-08-05 05:39:31 +00:00
Andrew Davis
b83bdae639 survey MDL-23324 refactored some code that had been left behind during prior refactoring 2010-08-05 05:38:15 +00:00
Andrew Davis
d04d8e96fd survey MDL-23324 made survey use user_picture::fields() 2010-08-05 05:36:43 +00:00
Tim Hunt
90c7912e93 quiz editing MDL-22371 with JS off, clicking add question, then cancel, did not work.
Also, other simpilar issues with other buttons.
And, finally fix the absolute URLs being passed as returnurl. Apache mod_security did not like that.
2010-08-04 19:44:59 +00:00
Tim Hunt
9f87e6aa15 quiz editing: MDL-22263 Editing UI messed up with JavaScript disabled.
Also, other minor layout improvements.
2010-08-04 19:43:26 +00:00
Tim Hunt
98a31ac119 quiz view NOBUG Table columns did not always line up. 2010-08-04 19:02:45 +00:00
Tim Hunt
f23f98dd63 question flags MDL-22643 Manually commenting should not reset the flag state. 2010-08-04 18:56:51 +00:00
Tim Hunt
f6c7f15883 quiz reports MDL-17388 tweak layout so more useful stuff fits on the first page.
In particular, I think you should be able to see at least the top of the table or results without scrolling, if your monitor is not too small.
2010-08-04 18:45:05 +00:00
Tim Hunt
5be2373649 quiz editing MDL-23572 Make it possible to delete empty pages of the quiz. 2010-08-04 16:47:57 +00:00
Tim Hunt
eb02301a36 mod_quiz / navigation MDL-20276 further polishing the quiz navigation structure. 2010-08-04 16:31:54 +00:00
Tim Hunt
7383c63398 quiz statistics report NOBUG remove debug code. Sorry. 2010-08-04 16:25:24 +00:00
Tim Hunt
ff065f96bc mod quiz + questions MDL-22370 convert JavaScript to YUI3 and modules.
Note, quiz editing JS has not been done yet.
2010-08-04 15:22:04 +00:00
Tim Hunt
24f17d7588 quiz responses report MDL-23377 responses report needs to be fixed in HEAD as well as overview. 2010-08-04 15:05:31 +00:00
Andreas Grabs
2986ddb431 Numeric answers was print out as string in the detailed xls-sheet 2010-08-04 14:06:27 +00:00
Andreas Grabs
a82633f401 Numeric answers was print out as string in the detailed xls-sheet 2010-08-04 13:53:07 +00:00
Petr Skoda
611b0a0c9b MDL-23628 removed more log_display upgrade leftovers 2010-08-04 09:48:04 +00:00
Aparup Banerjee
ac3d779195 lesson MDL-23525 passed in a missing object to remove notices seen. 2010-08-04 08:52:59 +00:00
Sam Hemelryk
cba87c36ea mod-data MDL-23618 Converted preset page to make use of mforms and new file picker element 2010-08-04 08:23:52 +00:00
Andrew Davis
9b8b9b7379 survey MDL-23324 made use of user_picture::fields() 2010-08-04 03:37:18 +00:00
Aparup Banerjee
ef4ba975f9 lesson MDL-23525 changed attempts retrieval from db to intuitional (code assumes it too) first->last attempt order 2010-08-04 02:26:46 +00:00
Jordi Piguillem
f6e56f2890 [MDL-23556]
Fixing this issue at wiki creation.
2010-08-03 17:28:17 +00:00
Jordi Piguillem
becf81c736 [MDL-23432]
Fixing problems at comments
2010-08-03 17:05:59 +00:00
Eloy Lafuente
113065d2fa MDL-23479 backup - lesson revised & old code deleted (but restore logs) 2010-08-03 15:38:25 +00:00
Helen Foster
9aba73563d MDL-23598 rewording help strings thanks to Joseph Rezeau 2010-08-03 14:14:05 +00:00
Tim Hunt
f05fedc84d quiz overview report MDL-23377 can't delete attempts when there are no students.
Actually, reviewing this, I noticed some other security checks were missing, for
example we should ensure the users can only delete attempts belonging to this quiz!
2010-08-03 13:15:27 +00:00
Tim Hunt
07a2b2f0f0 quiz overview MDL-23377 whitespace cleanup, before doing the real fix. 2010-08-03 12:54:23 +00:00
Jordi Piguillem
9bf1b7166f [MDL-23432]
Fixing this issue and some other problems with comments interface and capabilities.
2010-08-03 11:30:54 +00:00
Tim Hunt
b0e4fa419e quiz statistics NOBUG code cleanup. 2010-08-03 11:10:57 +00:00
Tim Hunt
2a8a78c320 quiz MDL-22691 error when editing a block's config on the quiz view page. 2010-08-03 11:10:38 +00:00
Tim Hunt
e10367a4cf quiz NOBUG Attempt {$a} was appearing on the view page. Need a new lang string. 2010-08-03 10:55:22 +00:00
Petr Skoda
f3b2189178 MDL-23598 fixed display problem related to review option - credit goes to Joseph Rzeau 2010-08-03 10:32:27 +00:00
Petr Skoda
847400a741 MDL-23628 adding ugprade info 2010-08-03 10:08:25 +00:00
Petr Skoda
c6d75bffa5 MDL-23628 improved log action support - now similar to handling of capabilities 2010-08-03 10:07:18 +00:00
Aparup Banerjee
37f796eae5 database MDL-22558 minor- improved alignment in database fields display. 2010-08-03 07:24:10 +00:00
Andrew Davis
7bac377763 gradebook MDL-23543 made gradebook not display items with gradetype of no grade 2010-08-03 07:22:27 +00:00
Aparup Banerjee
19edef1b7f database MDL-22558 minor- improved alignment in database fields display. 2010-08-03 05:57:28 +00:00
Eloy Lafuente
d68c337f5b MDL-23479 backup - various fixes in feedback backup & restore + delete old code (but logs restore) 2010-08-02 23:31:29 +00:00
Eloy Lafuente
59c9d381ae MDL-23479 backup - chat revised & old code deleted (but non-existing restore logs) 2010-08-02 21:09:38 +00:00
David Mudrak
c768af3dc5 MDL-21695 Removing legacy question formats help, details moved to wiki docs 2010-08-02 21:03:00 +00:00
David Mudrak
7292c11f51 MDL-21695 quiz: deprecated setHelpButton() and old_help_icon() replaced with new calls
Some help icons dropped without replacement as suggested by Helen, the
Help Writer. Some strings moved to core_question.

AMOS BEGIN
 HLP quiz/timelimit.html,[timelimit_help,mod_quiz]
 HLP quiz/grademethod.html,[grademethod_help,mod_quiz]
 HLP quiz/questionsperpage.html,[newpage_help,mod_quiz]
 HLP quiz/shufflewithin.html,[shufflewithin_help,mod_quiz]
 HLP quiz/penaltyscheme.html,[penaltyscheme_help,mod_quiz]
 HLP quiz/repeatattempts.html,[eachattemptbuildsonthelast_help,mod_quiz]
 HLP quiz/reviewoptions.html,[reviewoptionsheading_help,mod_quiz]
 HLP quiz/showuserpicture.html,[showuserpicture_help,mod_quiz]
 HLP quiz/decimalpoints.html,[decimalplaces_help,mod_quiz]
 HLP quiz/decimalplacesquestion.html,[decimalplacesquestion_help,mod_quiz]
 HLP quiz/requirepassword.html,[requirepassword_help,mod_quiz]
 HLP quiz/requiresubnet.html,[requiresubnet_help,mod_quiz]
 HLP quiz/timedelay1.html,[delay1st2nd_help,mod_quiz]
 HLP quiz/timedelay2.html,[delaylater_help,mod_quiz]
 HLP quiz/overallfeedback.html,[overallfeedback_help,mod_quiz]
 HLP quiz_statistics/negcovar.html,[negcovar_help,quiz_statistics]
 MOV [penaltyfactor,mod_quiz],[penaltyfactor,core_question]
 MOV [penaltyfactor_help,mod_quiz],[penaltyfactor_help,core_question]
 HLP quiz/penalty.html,[penaltyfactor_help,core_question]
AMOS END
2010-08-02 20:56:15 +00:00
Eloy Lafuente
1737d4dee9 MDL-23479 backup - resource (file) revised and working (but restore logs) 2010-08-02 19:11:29 +00:00
Eloy Lafuente
e6c9df4ead MDL-23479 backup - restore of imscp resources (supporting "archived" versions) 2010-08-02 17:12:34 +00:00
Petr Skoda
c6fb49100c MDL-22315 fixed fatal error 2010-08-02 15:12:47 +00:00
Helen Foster
b55ff60378 MDL-21695 adding help string 2010-08-02 15:04:33 +00:00
Eloy Lafuente
ea7c398e55 MDL-23479 backup - survey revised & old code deleted (but restore logs) 2010-08-02 14:10:43 +00:00
Eloy Lafuente
e00d996247 MDL-23479 backup - wiki revised & old code deleted (but restore logs) 2010-08-02 12:17:36 +00:00
Eloy Lafuente
07f7954d1e MDL-23479 backup - fix files/tags/comments/links backup & restore
(thanks Pigui for adapting module core so quickly)
2010-08-02 12:16:16 +00:00