Commit graph

116701 commits

Author SHA1 Message Date
Andrew Nicols
eb2301a76b
MDL-83468 cachestore_redis: Skip tests if Redis extension not available 2025-01-20 16:47:56 +01:00
Andrew Nicols
175cfd8f1e
MDL-83468 tool_policy: Test tidyups 2025-01-20 16:47:56 +01:00
Andrew Nicols
d4314266f1
MDL-83468 phpunit: Remove erroneously located test
This has been in two testsuites since 2014.
2025-01-20 16:47:56 +01:00
Andrew Nicols
41249b16f3
MDL-83468 phpunit: Test names are not optional 2025-01-20 16:47:56 +01:00
Andrew Nicols
3b1118cfd4
MDL-83468 phpunit: assertEqualsCanonicalizing now compares keys too
In previous versions of PHPUnit, the `assertEqualsCanonicalizing()`
method compared values only, ignoring the keys entirely. Since PHPUnit
10 the method now checks keys where they are non-numeric.

To solve this we call `array_values()`.
2025-01-20 16:47:56 +01:00
Andrew Nicols
bdb5309dfb
MDL-83468 phpunit: Replace uses of setMethods with onlyMethods
The PHPUnit MockBuilder `setMethods()` method has been deprecated in
favour of the more accurately defined `onlyMethods()` method.

This was previously addressed in MDL-71036 for Moodle 3.11, but these
cases have crept back in.
2025-01-20 16:47:56 +01:00
Andrew Nicols
9536ca738e
MDL-83468 phpunit: Do not throw exception in mocked destructor
PHPUnit removed the ability to mock a destructor, but our lock system
throws an exception if a lock has not been explicitly released in its
destructor.

Normally thhis is fine because the lock is released, and if not then we
want to know about it.

However, where we are mocking the lock, we do not actually obtain the
lock, and we may expect the test to fail.

This change moves the release and notification to a separate, reusable
public method, which is called from the destructor. This allows it to be
mocked at the appropriate time.
2025-01-20 16:47:56 +01:00
Andrew Nicols
118b3ccf46
MDL-83468 phpunit: Skip tests instead of data providers
Empty data providers are invalid and do not represent the state of the
test. Rather than commenting them out we should instead skip them.
2025-01-20 16:47:55 +01:00
Andrew Nicols
cb63d29ace
MDL-83468 phpunit: Add back deprecated assertTag 2025-01-20 16:47:55 +01:00
Andrew Nicols
bd01a91ae0
MDL-83468 phpunit: Add back getName to testcase
In some situations we use the name of the test so we must keep
`getName()` for backwards compatibility.
2025-01-20 16:47:55 +01:00
Andrew Nicols
d6aabc8b2e
MDL-83468 phpunit: Add back isInIsolation to testcase
This helper has been deprecated in PHPUnit, but we still need it in
Moodle.
2025-01-20 16:47:55 +01:00
Andrew Nicols
bc75ef8bbc
MDL-83468 phpunit: Fix various tests after phpunit 10 2025-01-20 16:47:55 +01:00
Andrew Nicols
b95a8c6ecc
MDL-83468 phpunit: Fix data provider param names 2025-01-20 16:47:55 +01:00
Andrew Nicols
b8591dc935
MDL-83468 phpunit: Dependency bump 2025-01-20 16:47:55 +01:00
Mark Johnson
ed51c39314
MDL-82237 mod_quiz: Include all filters in "See questions" link
The "See questions" link for random questions was still using the old
format the filter conditions, so was only applying the category filter
on the list of questions displayed. This means that if a tag filter (or
any other filter) was set on the random question set, it was not applied
when viewing the list of questions.

This change takes all the filter conditions applied in random question's
slot and passes them to the question bank in the "See questions" link.
2025-01-20 12:47:22 +00:00
danghieu1407
4d3c8595cf MDL-83850 report_progress: Add 'Completed' heading in the csv 2025-01-20 18:51:31 +07:00
Conn Warwicker
5107b5bcfc
MDL-84193 qbank_bulkmove: Disable bulkmove on history page.
This removes the option to bulk move questions from the question
history page.
2025-01-20 10:07:41 +00:00
Simey Lameze
c1182446d9 MDL-84249 behat: remove unnecessary javascript tag
This commit also make the repeated scenario names unique.
2025-01-20 13:59:29 +08:00
Jun Pataleta
7a48612bc2
Merge branch 'MDL-83750-main' of https://github.com/raortegar/moodle 2025-01-20 10:24:09 +08:00
Jun Pataleta
5feb937e87
Merge branch 'MDL-84202' of https://github.com/paulholden/moodle 2025-01-20 10:02:06 +08:00
Jun Pataleta
7941e283d2
Merge branch 'MDL-83814-main' of https://github.com/andrewnicols/moodle 2025-01-20 09:58:03 +08:00
Mark Johnson
9600744e44
MDL-83861 qbank: Add question idnumber filter 2025-01-17 10:23:10 +00:00
Conn Warwicker
91a196d961
MDL-83877 mod_quiz: Fix quiz question overflow CSS issues. 2025-01-17 10:00:38 +00:00
Jun Pataleta
cd56cc1f5a
Merge branch 'MDL-83341-main' of https://github.com/HuongNV13/moodle 2025-01-17 17:01:02 +08:00
Luca Bösch
47921f801f MDL-84138 mod_qbank: Add title to the page. 2025-01-17 09:48:17 +01:00
Huong Nguyen
d9b97aaeaf
MDL-81043 gradereport_grader: Improve gradereport_grader/collapse
- This will helps `nodesUpdate` handle asynchronous updates better
 - This also helps to fix Random Behat failure
2025-01-17 15:12:27 +07:00
Luca Bösch
bad3de017c MDL-84111 qtype_ddimageortext: keep item type, file and text together. 2025-01-17 08:53:38 +01:00
Matt Porritt
eabd31c5d3 MDL-82977 AI: Provider instances
Add a new admin setting that allows rendering of a template.
This means templated content can be rendered as part of
admin forms, giving more flexibility to forms and their actions.
2025-01-17 16:13:05 +11:00
Jun Pataleta
3000896f20
MDL-81780 tool_task: Minor ad-hoc tasks renderer refinements
* Ensure new strings are added alphabetically
* Fix rendering of delete button's aria-label
* Remove unused `deletetask` lang string
2025-01-17 11:53:58 +08:00
Jun Pataleta
0b8526e6d3
Merge branch 'MDL-81780-Adhoc-task-improvements' of https://github.com/waleedhassan5/moodle 2025-01-17 11:53:28 +08:00
AMOS bot
ad36375460 Automatically generated installer lang files 2025-01-17 00:08:00 +00:00
Paul Holden
2bb8b013e7
MDL-83751 check: remove non-functional result class method. 2025-01-16 17:40:01 +00:00
Huong Nguyen
a2653cc924
weekly release 5.0dev 2025-01-16 23:46:14 +07:00
Huong Nguyen
1b5e5d0870
NOBUG: Add upgrade notes 2025-01-16 23:46:14 +07:00
Huong Nguyen
6089e52765
Merge branch 'install_main' of https://git.in.moodle.com/amosbot/moodle-install 2025-01-16 23:45:55 +07:00
waleedhassan
c0572a0423 MDL-81780 tool_task : Adhoc task improvements
Added fail delay column in the adhock task table on the admin page,
Added a new column for a delete action for the adhoc tasks on and
Wrote delete_adhoctask.php for delete functionality of adhoc tasks.
Wrote behat test for the delete functionality. Also there was a
logical error in the previous code where it was checking if the task
is due or not and it was just showing Never or ASAP instead of
actual time so fixed that as well.
2025-01-16 12:16:04 +00:00
Conn Warwicker
86d37cd476
MDL-84191 qbank_viewquestiontext: Add filter for question text.
This covers both question text and general feedback text.
2025-01-16 09:17:32 +00:00
Jun Pataleta
4a2e2086a4
Merge branch 'MDL-80468-factorpage-m' of https://github.com/bwalkerl/moodle 2025-01-16 12:25:44 +08:00
David Woloszyn
1afbe03ec8 MDL-82944 message: Notify user about unsent messages 2025-01-16 13:46:21 +11:00
Jun Pataleta
3cd1c53182
Merge branch 'MDL-83826-main' of https://github.com/lameze/moodle 2025-01-16 10:21:58 +08:00
Conn Warwicker
ea26351c78
MDL-82772 mod_quiz: Update context when random question is updated. 2025-01-15 13:15:52 +00:00
Jun Pataleta
d0a31f104a
Merge branch 'MDL-83172-main' of https://github.com/meirzamoodle/moodle 2025-01-15 17:02:12 +08:00
Laurent David
b0c19ef4a8 MDL-81790 report_log: Log report page per activities
* When clicking on the More / Logs menu in an activity we
should stay on the activity page and not go on the course
report log
2025-01-15 09:41:08 +01:00
Sara Arjona
e46858963c
Merge branch 'MDL-83995' of https://github.com/paulholden/moodle 2025-01-15 08:26:51 +01:00
Angelia Dela Cruz
0745d3416b MDL-83826 core_admin: Behat coverage for plugins overview for admins 2025-01-15 14:02:28 +08:00
Huong Nguyen
7dbf73a4df
Merge branch 'MDL-83673-main' of https://github.com/ferranrecio/moodle 2025-01-15 09:28:36 +07:00
Sara Arjona
7c9bfaa0f0
Merge branch 'MDL-84072' of https://github.com/paulholden/moodle 2025-01-14 14:43:47 +01:00
Sara Arjona
8d429bc55b
Merge branch 'MDL-82866-main' of https://github.com/lameze/moodle 2025-01-14 14:22:20 +01:00
Simey Lameze
fc5c0ad3e5 MDL-82866 behat: deprecate the old lp step and class 2025-01-14 19:20:00 +08:00
Sara Arjona
95b434cb4a
Merge branch 'MDL-83630' of https://github.com/paulholden/moodle 2025-01-14 11:53:24 +01:00