Commit graph

97820 commits

Author SHA1 Message Date
Neill Magill
7289f5c0c1 MDL-64427 category: Stop error when another user deleting courses
If you try to visit a category where another user is deleting a
course the coursecat cache may not be fresh. This is because there
is a breif time where the course record will have been deleted,
while it is deleting other course information, before the event that
triggers the coursecat cache to be purged is fired.
2020-05-20 08:27:52 +01:00
Neill Magill
236a52c4de MDL-64427 category: Test getting category courses during deletion
Adding a unit test for the situation where a course is partially
deleted when a list of courses in a category is retrived.
2020-05-20 08:27:52 +01:00
Sara Arjona
630a19ebd5 MDL-68746 core_badges: remove Issuer details from badges form
When OBv2.0 support was added, the issuername and issuercontact
fields were changed to static.
In order to avoid confusion for the user, these fields shouldn't
be displayed for OBv2.0 or higher.
2020-05-20 08:51:52 +02:00
Brendan Heywood
8eab4f77cc MDL-68577 session: Fine tune the redis lock polling 2020-05-20 15:54:10 +10:00
Adrian Greeve
1c1fd15b18 Merge branch 'MDL-68333-master' of git://github.com/marinaglancy/moodle 2020-05-20 13:17:58 +08:00
Andrew Nicols
db5be3a31c MDL-68778 user: Fetch select from selected option
It seems that the HTMLSelectElement behaves slightly different on Linux
vs MacOS.

On Linux with Firefox 47 when selecting an option the
HTMLOptionElement is returned, whereas on MavOS the HTMLSelectElement
that the Option belongs to is returned.

We need to normalise the value here before resetting the currently
selected item.
2020-05-20 13:17:50 +08:00
Jun Pataleta
0763480b33 MDL-68783 core_grades: Fix outcome page's add/remove button styles
* Applied proper styles of btn-secondary.
* Added some vertical spacing between the buttons by enclosing them in
divs with 'm-y-1' class instead of just a br tag.
2020-05-20 13:12:58 +08:00
Nathan Nguyen
a9c139c8d4 MDL-39571 repository_recent: query improvement 2020-05-20 13:11:51 +10:00
Nathan Nguyen
1529fc7954 MDL-39571 repository_recent: add unit test 2020-05-20 12:48:17 +10:00
Jun Pataleta
3728866a5f MDL-52578 core_course: Peer review fixes
* Fetch parent category only when necessary.
* Fix outdated variable names in original patch.
* Fix variable scope for $outcomeexists.
2020-05-20 10:29:46 +08:00
Dan Marsden
fe96a5528c MDL-68054 lib: viewhiddenactivities should be set as captype:read 2020-05-20 14:00:48 +12:00
Adrian Greeve
59d0090fda Merge branch 'MDL-67548-master' of https://github.com/kabalin/moodle 2020-05-20 08:35:18 +08:00
AMOS bot
1ec1cfff2d Automatically generated installer lang files 2020-05-20 00:07:22 +00:00
Andrew Nicols
6754ceae3a MDL-68464 user: Remove legacy selectall 2020-05-20 07:38:26 +08:00
Eloy Lafuente (stronk7)
31ffacb020 Merge branch 'MDL-68464-master-final' of git://github.com/andrewnicols/moodle 2020-05-20 00:17:53 +02:00
Tim Hunt
64207dab65 MDL-67183 questions: get_question & get_behaviour only init if required
This reviews all the code code, and sets $requirequestioninitialised
whenever possible in these calls, which should improve performance.
2020-05-19 20:52:07 +01:00
Tim Hunt
9cbbb779eb MDL-67183 question engine: allow lazy-init of question_attempts
That is, we don't call apply_attempt_state as soon as a
the data is loaded from the database. Instead, we wait
and only call it if really needed.

This should (especially after the next commit) be a performance win
during quizzes, particularly for people using advanced question
types liks STACK, or people making extensive use of the
'Try another question like this one' feature.
2020-05-19 20:49:33 +01:00
Víctor Déniz Falcón
676b8b8217 Merge branch 'MDL-68299-master' of git://github.com/bmbrands/moodle 2020-05-19 20:43:46 +01:00
Paul Holden
be60a5d096 MDL-66471 user: fix user_selector debug about extra identity fields. 2020-05-19 19:12:35 +01:00
Steve Bader
604fb8c2a2 MDL-52578 core_course: Activity weight set to 0 on creation 2020-05-20 01:28:59 +08:00
Marina Glancy
5b529aca15 MDL-68333 testing: trigger user_created event in user generator 2020-05-19 19:11:54 +02:00
Marina Glancy
d268c5bac3 MDL-58866 core_calendar: separate color for other events, icons 2020-05-19 19:04:15 +02:00
Marina Glancy
6f92c731e7 MDL-58866 block_timeline: do not display course if abscent 2020-05-19 19:04:15 +02:00
Marina Glancy
1a972b06f1 MDL-58866 core_calendar: allow component events 2020-05-19 19:04:13 +02:00
Sara Arjona
1afe68f382 weekly release 3.9dev+ 2020-05-19 17:54:25 +02:00
Sara Arjona
a0caddb696 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2020-05-19 17:54:22 +02:00
Andrew Nicols
7f22867502 MDL-68463 core_user: Correct Show all link details 2020-05-19 14:16:25 +02:00
Juan Leyva
82d5547b8f MDL-68294 tool_mobile: Fix custom strings and limits calculation 2020-05-19 12:19:37 +02:00
Andrew Nicols
fec9e9cce5 Merge branch 'srdjan-slave-conn' of https://github.com/srdjan-catalyst/moodle 2020-05-19 16:13:48 +08:00
Bas Brands
92bc86e429 MDL-68299 theme_boost: theme updates for accessible zoom
The Moodle UI should be functional in a viewport of 320px by 256px to
meet WCAG 1.4.10

this patch contains improvements to:
-prevent horizontal scrolling
-better wrapping of page header
-message drawer funtional on tiny screens
-remove indenting on courses
-prevent elements overlapping on quiz editing
-better navigation tabs
-fix colour picker
-quiz editing
2020-05-19 10:13:20 +02:00
Srdjan
317432cacc MDL-19711 dml: call mysqli::real_connect() with @ 2020-05-19 18:09:14 +10:00
Juan Leyva
509a4c5865 MDL-68294 tool_mobile: Fix key and default apps values 2020-05-19 09:24:26 +02:00
Srdjan
3612d0b8b9 MDL-19711 dml: Fix undefined $dberr
In mysqli_native_moodle_database::raw_connect()
2020-05-19 17:02:05 +10:00
Ferran Recio
99374e7e14 MDL-67700 message: correcting conversation timer reset 2020-05-19 08:38:26 +02:00
Andrew Nicols
abc83c40b5 MDL-68464 enrol_manual: Comment out buggy behat line
This is commented out because auto-hidden toasts currently call `hide()`
and trigger the `bs.toast.hide` event immediately, and _then_ apply the
autohide delay.

Since we automatically add M.util.pending_js calls when we _start_ to
hide, and resolve them when the hide _finishes_, this means that we do:
- addToast called
- trigger `bs.toast.show` event
- add to pending_js
- [pending_js queue not empty - behat waits]
- message is shown in UI
- `hide()` called
- trigger `bs.toast.hide` event
- add to pending_js
- [pending_js queue not empty - behat waits]
- start autohide delay
- [pending_js queue not empty - behat waits]
- [pending_js queue not empty - behat waits]
- [pending_js queue not empty - behat waits]
- [pending_js queue not empty - behat waits]
- end autohide delay
- remove message (no longer present in DOM)
- trigger `bs.toast.hidden` event
- resolve pending_js
- [pending_js queue empty - behat stops waiting]
- Behat runs next step: And I should see "1 enrolled users"
-- Step fails beacuse the message has been shown, and has then been removed

The conversation should have been:
- addToast called
- trigger `bs.toast.show` event
- add to pending_js
- [pending_js queue not empty - behat waits]
- message is shown in UI
- start autohide delay
- trigger `bs.toast.shown` event
- resolve pending_js
- [pending_js queue empty - behat stops waiting]
- Behat runs next step: And I should see "1 enrolled users"
-- Step passes
- autohide delay ends and calls `hide()`
- trigger bs.toast.hide event
- add to pending_js
- [behat waits]
- end autohide delay
- remove message (no longer present in DOM)
- trigger `bs.toast.hidden` event
- resolve pending_js
- [pending_js queue empty - behat stops waiting]
- Behat run continues

See MDL-67386 for futher information.
2020-05-19 12:37:21 +08:00
Andrew Nicols
e0e7b19f9c MDL-68464 enrol_manual: Reload participants table after enroling 2020-05-19 12:37:21 +08:00
Andrew Nicols
c50f5af248 MDL-68464 enrol_manual: Rewrite quickenrolment to use ES6 2020-05-19 12:33:40 +08:00
Andrew Nicols
ab6ca1d5c9 Merge branch 'srdjan-slave-conn' of https://github.com/srdjan-catalyst/moodle 2020-05-19 12:29:20 +08:00
Jun Pataleta
f46b5f5f28 Merge branch 'MDL-68463-master-3' of git://github.com/andrewnicols/moodle 2020-05-19 12:24:14 +08:00
Andrew Nicols
50ba817fda MDL-68463 user: Show count link should always exist in DOM 2020-05-19 12:18:15 +08:00
Jun Pataleta
b81c2a3475 Merge branch 'MDL-68528-master' of git://github.com/andrewnicols/moodle 2020-05-19 11:46:39 +08:00
Andrew Nicols
bc9426c879 MDL-68528 js: Normalise core component for template strings 2020-05-19 11:40:44 +08:00
Andrew Nicols
ed0328397a MDL-68528 js: Normalise empty component to "core" for string 2020-05-19 11:37:55 +08:00
Srdjan
46cfde3d95 MDL-19711 dml: Enable use of readonly slave database handles
Implemented with moodle_read_slave_trait

Functionality is triggered by supplying config dboption['readonly'].
See config-dist.php for more info on supported dboptions.

pgsql and mysqli drivers are using this feature. Also added support for
connection timeout for these two drivers.
2020-05-19 11:50:42 +10:00
AMOS bot
df35cf110e Automatically generated installer lang files 2020-05-19 00:07:17 +00:00
Eloy Lafuente (stronk7)
4c6a9740f7 Merge branch 'MDL-68656-master' of https://github.com/catalyst/moodle 2020-05-19 01:13:22 +02:00
Tim Hunt
89c8a076b2 MDL-68733 quiz editing: behat test for altering random question tags 2020-05-18 23:20:10 +01:00
Bence Molnar
9024289626 MDL-68733 quiz editing: be more careful deleting random question tags 2020-05-18 22:56:33 +01:00
Tim Hunt
c689726d3f MDL-68733 question behat: question tag generator and use in quiz test 2020-05-18 22:56:33 +01:00
Tim Hunt
4a45b7112c MDL-68757 questions: don't do output in low-level functions 2020-05-18 20:54:27 +01:00