Commit graph

22952 commits

Author SHA1 Message Date
Shamim Rezaie
4ddc9fe0f4 MDL-71410 core: Prevent recursively calling getters 2021-04-27 14:32:26 +10:00
Shamim Rezaie
796e82124f MDL-71410 mod_quiz: implement activity_dates for the quiz module 2021-04-27 14:32:26 +10:00
Shamim Rezaie
ec519a6488 MDL-71410 mod_quiz: Cache quiz times in modinfo for performance
We update the dates with user/group overrides. The calculation of
the override in the quiz module is different from the assignment
module as the quiz_overrides table des not have a sortorder column.
See quiz_update_effective_access().
2021-04-27 14:32:26 +10:00
Shamim Rezaie
d61f18433f MDL-71410 mod_quiz: Cache user and group overrides 2021-04-27 14:32:26 +10:00
Shamim Rezaie
660f7c08c5 MDL-71410 mod_lesson: implement activity_dates for the lesson module 2021-04-27 14:32:26 +10:00
Shamim Rezaie
8a308c498c MDL-71410 mod_lesson: Cache lesson times in modinfo for performance
We update the dates with user/group overrides. The calculation of
the override in the lesson module is different from the assignment
module as the lesson_overrides table des not have a sortorder column.
See lesson::update_effective_access().
2021-04-27 14:01:49 +10:00
Shamim Rezaie
47fcfa0af8 MDL-71410 mod_lesson: Cache user and group overrides 2021-04-27 14:01:45 +10:00
Shamim Rezaie
18efd91d2f MDL-71410 mod_assign: implement activity_dates for the assignment module 2021-04-27 14:00:06 +10:00
Shamim Rezaie
4532d3f8b7 MDL-71410 mod_assign: Cache assign times in modinfo for performance
We update the dates with user/group overrides
2021-04-27 14:00:06 +10:00
Shamim Rezaie
8e50d64baf MDL-71410 mod_assign: Cache user and group overrides 2021-04-27 14:00:02 +10:00
Sara Arjona
7046626952 Merge branch 'MDL-71392' of git://github.com/paulholden/moodle 2021-04-26 11:52:46 +02:00
Jun Pataleta
3dd247e869 Merge branch 'MDL-71252-master' of git://github.com/HuongNV13/moodle 2021-04-26 17:02:46 +08:00
Huong Nguyen
bda8e0fb2a MDL-71252 completion: Behat failure 2021-04-26 15:58:12 +07:00
Jun Pataleta
93ab8c089e Merge branch 'MDL-71252-master' of git://github.com/HuongNV13/moodle 2021-04-26 15:55:11 +08:00
Huong Nguyen
3f9035b989 MDL-71252 completion: Avoid showing the 'Mark as done' button
The following activites will be applied:
 - Label
 - File (Force download/Open/In pop-up)
 - URL (Open/In pop-up)
2021-04-26 14:24:41 +07:00
Paul Holden
5e5181497e MDL-71434 mod_data: add form control class to template textarea. 2021-04-25 18:29:22 +01:00
Tim Schroeder
a7e1f4ebc0 MDL-70110 assign: fixed ws get_submissions for groups 2021-04-24 12:08:14 +02:00
Sara Arjona
12f64a02c9 Merge branch 'MDL-71144-master' of git://github.com/rezaies/moodle 2021-04-23 13:16:01 +02:00
Marina Glancy
4d2c96861d MDL-71397 mod_glossary: empty category is the same as all categories
In PHP8 empty string is not equal to zero
2021-04-23 11:46:01 +02:00
abgreeve
ea362206a3 Merge branch 'MDL-70818-master-4' of git://github.com/rezaies/moodle 2021-04-23 12:19:51 +08:00
Andrew Nicols
1a34066129 Merge branch 'master-MDL-71376' of https://github.com/rjnl/moodle 2021-04-23 11:52:21 +08:00
Shamim Rezaie
ac2b200a6e MDL-70818 mod_workshop: implement activity_dates for the workshop module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
0b64b10eb9 MDL-70818 mod_workshop: cache workshop times in modinfo for performance 2021-04-23 13:46:28 +10:00
Shamim Rezaie
2ad16d8d9e MDL-70818 mod_scorm: implement activity_dates for the scorm module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
31288bd1a6 MDL-70818 mod_forum: implement activity_dates for the forum module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
b284e9e705 MDL-70818 mod_forum: cache forum times in modinfo for performance 2021-04-23 13:46:28 +10:00
Shamim Rezaie
b3b7c3f95a MDL-70818 mod_feedback: implement activity_dates for the feedback module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
6b243c62e6 MDL-70818 mod_data: implement activity_dates for the database module 2021-04-23 13:46:28 +10:00
Andrew Nicols
b124832fe6 Merge branch 'MDL-70970' of git://github.com/paulholden/moodle 2021-04-23 11:26:53 +08:00
Sara Arjona
c9c18da021 Merge branch 'MDL-71400-master' of git://github.com/mihailges/moodle 2021-04-22 13:16:23 +02:00
Shamim Rezaie
0ca7548443 MDL-71144 mod_scorm: Deprecate scorm_get_completion_state() 2021-04-22 21:11:43 +10:00
Shamim Rezaie
7d102bb67d MDL-71144 mod_quiz: custom_completion should not use deprecated function
This commit also removes an unnecessary DB query.
2021-04-22 21:11:43 +10:00
Shamim Rezaie
d9d0ae01d3 MDL-71144 mod_quiz: Deprecate quiz_get_completion_state() 2021-04-22 21:02:02 +10:00
Paul Holden
4264f85063 MDL-71200 mod_folder: ensure "Download folder" option is backed up. 2021-04-22 10:29:25 +01:00
Paul Holden
0de5ab4b43 MDL-71392 mod_quiz: don't display grade to pass if not set. 2021-04-22 09:53:24 +01:00
Mihail Geshoski
4e714cebae MDL-71400 assignfeedback_offline: Fix message after worksheet upload 2021-04-22 13:08:15 +08:00
abgreeve
8a53fe7f6b Merge branch 'MDL-28452-master' of git://github.com/bmbrands/moodle 2021-04-22 09:38:50 +08:00
Shamim Rezaie
a2bf666a0c MDL-71144 mod_lesson: Deprecate lesson_get_completion_state() 2021-04-22 10:08:11 +10:00
Shamim Rezaie
b4c8f0f8a6 MDL-71144 mod_survey: Deprecate survey_get_completion_state() 2021-04-22 10:08:11 +10:00
Shamim Rezaie
5f9aa4d35f MDL-71144 mod_glossary: Deprecate glossary_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
c9fa4f9cd7 MDL-71144 mod_forum: Deprecate forum_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
c10dfd7583 MDL-71144 mod_feedback: Deprecate feedback_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
08fb6a71b7 MDL-71144 mod_data: Deprecate data_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
17c3c4dc75 MDL-71144 mod_choice: Deprecate choice_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
d484b3e371 MDL-71144 mod_assign: Deprecate assign_get_completion_state() 2021-04-22 10:08:04 +10:00
Sara Arjona
49dbf2c130 Merge branch 'MDL-64336' of https://github.com/NeillM/moodle 2021-04-21 17:13:57 +02:00
Neill Magill
bce4c28577 MDL-64336 assign: Add missing PHP doc 2021-04-21 15:14:15 +01:00
Neill Magill
06a69802d6 MDL-64336 assign: Teachers should be able to see all submissions
Before this change a teacher would be able to see users listed if:

* They have an active enrolment and can submit
* They have an an inactive enrolment for a role that can submit

After this change they will additonally be able to see users listed:

* That have an active enrolment and have submitted
* That have an inactive enrolment and have submitted

This means that if an assignment has it's context frozen all users
that have made some form of submission will still be listed.

It will also apply if the submission capability is removed from a
user.

If a user's enrolment is deleted they will not be listed.

The submission and grading counts have also been updated so
they will reflect the new rules.
2021-04-21 15:14:14 +01:00
Neill Magill
1f55fff393 MDL-64336 assign: Submissions should be visible while frozen
Before this change if a student visited an assignment that is
frozen they would only see the title and description even if
they had made a submission to it.

After the change they will be able to see the status of their
submission and any feedback and grades they have recived.

It will also make the Moodle app recognise that submission
should not happen because the assignment is frozen.

Tests based on ones created by Andrew Nicols
2021-04-21 15:14:14 +01:00
Marina Glancy
263c39ba21 MDL-71389 various: changes to unittests due to php8 changes:
- some engine error messages changed
- some warning levels changed
- the carriage return symbol randomly appears
- one phpunit assertion fails and not really representative of anything
2021-04-21 12:38:46 +02:00