Commit graph

60238 commits

Author SHA1 Message Date
Marina Glancy
15d50fffd8 MDL-38147 Performance improvements to coursecat class:
- Retrieve and cache only often-used fields of course category
- Removed function coursecat::get_all_visible() as potentially causing performance issues
- removed function coursecat::get_all_parents() as ineffective and unnecessary, replaced with get_parents()
- retrieve all fields from course_categories when unretrieved field is accessed

Also some code improvements:
- rename functions starting with _ , rename arguments, etc.
2013-03-25 13:23:14 +11:00
Marina Glancy
e1d54562ce MDL-38147 deprecated get_categories(), change usage to coursecat 2013-03-25 13:23:06 +11:00
Marina Glancy
8db5dcb7cd MDL-38147 deprecated get_child_categories(), change usage to coursecat 2013-03-25 13:22:56 +11:00
Marina Glancy
bc81b0065c MDL-38147 deprecated get_all_subcategories() 2013-03-25 13:22:38 +11:00
Marina Glancy
9bad61dbfe MDL-38147 deprecated create_course_category(), change usage to coursecat. Also avoid direct DB update of table course_categories
changed to usage of
- coursecat::create()
- coursecat::update()
2013-03-25 13:22:26 +11:00
Marina Glancy
2d8a275bab MDL-38147 deprecated get_course_category(), change usage to coursecat 2013-03-25 13:21:20 +11:00
Marina Glancy
6e1d1ee0e7 MDL-38147 deprecated move_category(), course_category_hide(), course_category_show(), change usage to coursecat
All usages in core replaced with:
- coursecat::change_parent()
- coursecat::hide()
- coursecat::show()
2013-03-25 13:21:09 +11:00
Marina Glancy
deb65cedc4 MDL-38147 deprecated category_delete_move(), category_delete_full(), change usage to coursecat 2013-03-25 13:21:04 +11:00
Marina Glancy
4e0b6025ad MDL-38147 deprecated make_categories_list(), change usage to coursecat 2013-03-25 13:20:46 +11:00
Marina Glancy
b28bb7e8c7 MDL-38147 Added coursecatlib_test.php, changed other tests to use coursecat::create() for creating category 2013-03-25 13:20:39 +11:00
Marina Glancy
b33389d228 MDL-38147 Created class coursecat, added cache definition and lang strings 2013-03-25 13:20:33 +11:00
Damyon Wiese
adfcc976f6 Merge branch 'MDL-31681' of https://github.com/Lightwork-Marking/moodle 2013-03-25 10:15:38 +08:00
Dan Poltawski
b716cd2b70 MDL-34311 mod_url: Missing setType on the external url 2013-03-25 09:39:30 +08:00
Dan Poltawski
9f9dde40ee MDL-34311 course: add missing type on cm idnumber
We must use PARAM_RAW for idnumbers because external systems could use
any characters and this is a linking field for external systems.
2013-03-25 09:30:52 +08:00
Dan Poltawski
e994754d31 MDL-34311 course: prevent course edit form warnings
There is a placeholder element.
2013-03-25 09:30:51 +08:00
Dan Poltawski
b45ba7f6fa MDL-34311 formslib: warn when no param type set
Params without a type set will not be getting cleaned, so if developers
really do not want cleaning, they should set it explicitly.
2013-03-25 09:30:51 +08:00
Damyon Wiese
81409525b9 MDL-37033 Environment - Fix indenting in XML 2013-03-25 09:20:53 +08:00
David Monllao
970c5f3849 MDL-38483 behat: New test
According to MDLQA-89
2013-03-25 09:19:40 +08:00
David Monllao
b4e94458c7 MDL-38484 behat: New test
According to MDLQA-4597
2013-03-25 09:19:14 +08:00
Damyon Wiese
3bdb3e1605 Merge branch 'MDL-37033' of git://github.com/stronk7/moodle 2013-03-25 09:13:50 +08:00
Frederic Massart
41d020b35e MDL-38645 form: Added margin between checkbox/radio and label 2013-03-25 08:30:31 +08:00
Frederic Massart
207c737dc0 MDL-38569 form: No advanced settings in Common module settings 2013-03-25 08:29:05 +08:00
Frederic Massart
619fe67e32 MDL-38598 form: Prevent flickering due to advanced fields 2013-03-25 08:28:32 +08:00
Frederic Massart
8819a83601 MDL-26644 course: Remove useless setting completionstartonenrol
This commit removes any trace of the setting 'Completion tracking
begins on enrolment' as it does not appear to do anything.
2013-03-25 08:28:01 +08:00
Frederic Massart
5c5317aedc MDL-38612 url: Reformat module settings form 2013-03-25 08:17:59 +08:00
Eloy Lafuente (stronk7)
5214f9ef96 Merge branch 'MDL-38658-m' of git://github.com/andrewnicols/moodle 2013-03-24 23:40:50 +01:00
Eloy Lafuente (stronk7)
943e317cb4 Merge branch 'MDL-36927-master' of git://github.com/ankitagarwal/moodle 2013-03-24 23:39:07 +01:00
Eloy Lafuente (stronk7)
22ddcdef89 Merge branch 'w13_MDL-38581_m25_forumtests' of git://github.com/skodak/moodle 2013-03-24 23:26:55 +01:00
Petr Škoda
c7289da7eb MDL-38654 add full $CFG->gdversion backwards compatibility for now 2013-03-24 22:18:49 +01:00
Paul Charsley
3f0ea6d8a7 MDL-31681 added core_grade_get_definitions web service function 2013-03-25 08:38:05 +13:00
Andrew Robert Nicols
5e8dddc167 MDL-38666 JavaScript: Migrate moodle-calendar-evantmanager to use Shifter 2013-03-24 18:42:38 +00:00
Andrew Robert Nicols
a94dd7d2b8 MDL-38517 JavaScript: Migrate moodle-core-blocks to use Shifter 2013-03-24 18:39:57 +00:00
Petr Škoda
e5f4ba84ab MDL-38675 import tcpdf 5.9.209 2013-03-24 18:59:33 +01:00
Petr Škoda
83cca3da87 MDL-38673 import flash based FlowPlayer 3.2.16 2013-03-24 18:35:09 +01:00
Andrew Robert Nicols
096065e6c0 MDL-38674 JavaScript: Migrate moodle-filter_glossary-autolink to use Shifter 2013-03-24 17:26:23 +00:00
Petr Škoda
510d190382 MDL-38672 import HTML Purifier 4.5.0 2013-03-24 18:00:44 +01:00
Petr Škoda
9f7b1c7f95 MDL-38671 add adodb 5.18 2013-03-24 17:48:11 +01:00
Petr Škoda
fe95fb5322 MDL-37782 reset DB after each failed database test 2013-03-24 14:16:28 +01:00
Petr Škoda
77a5c09354 MDL-37742 simplify dirty one-space oracle hack 2013-03-24 13:43:18 +01:00
Matteo Scaramuccia
724dc929c7 MDL-38336 SCORM: incorrect TOC bulding when 'Display course structure' is on 2013-03-24 11:02:41 +01:00
Eloy Lafuente (stronk7)
dbd349ab09 MDL-38668 timezones: update to tzdata 2013b 2013-03-24 10:42:28 +01:00
Andrew Robert Nicols
f0e79573cf MDL-38667 JavaScript: Correct loading of Shifted CSS 2013-03-24 01:29:00 +00:00
Gareth J Barnard
d46e26f682 MDL-34917 course: Jump to section navigation for 'One section per page'. 2013-03-23 17:01:32 +00:00
Matteo Scaramuccia
2aecb84d01 MDL-38468 Files API: fixed the support for MTHML (MIME HTML: web page archive) files 2013-03-23 10:21:51 +01:00
Jonathon Fowler
8bcefa699d MDL-38390 qformat_blackboard_six: use pool title as category name
If the category title is empty, generate a sequentially-numbered
title to use instead.
2013-03-23 17:35:16 +10:00
Petr Škoda
15bac12e9d MDL-37783 add some useful information to any phpunit output 2013-03-23 00:06:39 +01:00
Petr Škoda
de8056c871 MDL-38589 improve missing PHPUnit library hint 2013-03-22 22:47:08 +01:00
Andrew Robert Nicols
3f53437109 MDL-38658 JavaScript: Correct fullpath for dndupload definition 2013-03-22 17:29:56 +00:00
Petr Škoda
689096bc26 MDL-38654 do not test $CFG->gdversion
GD PHP extension is now required. Add-ons need to remove $CFG->gdversion tests. The worst case regression is that add-on will think GD is not available.
2013-03-22 16:57:55 +01:00
Eloy Lafuente (stronk7)
40b5cb2d71 MDL-37033 environment: add 2.5 brach details 2013-03-22 16:41:15 +01:00