moodle/mod/resource/filter.php
martinlanghoff 9aa9080756 Auto-linking filters: fix serious caching bug in forum mailouts
Autolinking of glossaries, activity, resources and wiki names were using a
trivial single-entry cache implemented with static vars. The cache was _not_
keyed on course.

This bug was visible during forum_cron() which walks many courses. The cache
would get "stuck" on the first course that had something to put in the cache.
All mailouts from there onwards would autolink to stuff in the wrong course.
2007-03-19 06:33:45 +00:00

60 lines
2 KiB
PHP

<?php // $Id$
//This function provides automatic linking to
//resources when its name (title) is found inside every Moodle text
//Williams, Stronk7, Martin D
function resource_filter($courseid, $text) {
global $CFG;
// Trivial-cache - keyed on $cachedcourseid
static $nothingtodo;
static $resourcelist;
static $cachedcourseid;
// if we don't have a courseid, we can't run the query, so
if (empty($courseid)) {
return $text;
}
// Initialise/invalidate our trivial cache if dealing with a different course
if (!isset($cachedcourseid) || $cachedcourseid !== (int)$courseid) {
$resourcelist = array();
$nothingtodo = false;
}
$cachedcourseid = (int)$courseid;
if ($nothingtodo === true) {
return $text;
}
/// Create a list of all the resources to search for. It may be cached already.
if (empty($resourcelist)) {
/// The resources are sorted from long to short so longer ones can be linked first.
if (!$resources = get_records('resource', 'course', $courseid, 'CHAR_LENGTH(name) DESC', 'id,name')) {
$nothingtodo = true;
return $text;
}
$resourcelist = array();
foreach ($resources as $resource) {
$currentname = trim($resource->name);
$strippedname = strip_tags($currentname);
/// Avoid empty or unlinkable resource names
if (!empty($strippedname)) {
$resourcelist[] = new filterobject($currentname,
'<a class="resource autolink" title="'.$strippedname.'" href="'.
$CFG->wwwroot.'/mod/resource/view.php?r='.$resource->id.'" '.$CFG->frametarget.'>',
'</a>', false, true);
}
}
}
return filter_phrases($text, $resourcelist); // Look for all these links in the text
}
?>