mirror of
https://github.com/moodle/moodle.git
synced 2025-08-06 01:16:44 +02:00
106c64ac24
With PHPUnit 8 a good number of assertions, all them related with operations on non-public attributes have been deprecated. And will be removed with PHPUnit 9. The main point is that unit tests shouldn't be testing non-public APIs (good practice) and those assertions were an error originally. See https://github.com/sebastianbergmann/phpunit/issues/3338 for the complete list and other details. When possible (the attributes being checked are public), the change is simple, just switching to normal assertions. When the attributes are not public we need to find a workaround to be able to test the same using public APIs, or use Reflection, or remove the tests. For the records, this is the regexp used to find all the cases: ag '>(assertAttribute|attribute\(|readAttributte|getStaticAttribute| \ getObjectAttribute)' -G "test.php" |
||
|---|---|---|
| .. | ||
| amd | ||
| classes | ||
| output | ||
| templates | ||
| tests | ||
| defaultoutputs.php | ||
| edit.php | ||
| externallib.php | ||
| index.php | ||
| lib.php | ||
| module.js | ||
| notificationpreferences.php | ||
| pendingcontactrequests.php | ||
| renderer.php | ||
| upgrade.txt | ||