mirror of
https://github.com/moodle/moodle.git
synced 2025-08-08 02:16:41 +02:00
c96c9601af
Feedback code was doing the following, which is incompatible with the sec-patched quickforms lib: - appending '[0]' to non-group element names, meaning type checks in getCleanType() were falling back to PARAM_RAW instead of PARAM_INT, and meaning _findValue() was comparing elements it thought to be arrays with scalar submit values (worked with eval() implementation as the 0th element of a string was the character, but not working when patched). - external unit tests incorrectly testing multichoice questions in the process_page tests - patched lib highlighted failures. It was also doing the following: - actively setting null as default element values instead of 0 for radio buttons and dropdowns (for 'not selected'). This is incompatible with more recent quickforms lib (see MDL-63070). - creating groups using addElement instead of addGroup - not recommended This patch addresses the above. |
||
|---|---|---|
| .. | ||
| analytics/indicator | ||
| event | ||
| external | ||
| output | ||
| privacy | ||
| search | ||
| complete_form.php | ||
| completion.php | ||
| course_map_form.php | ||
| course_select_form.php | ||
| external.php | ||
| observer.php | ||
| responses_anon_table.php | ||
| responses_table.php | ||
| structure.php | ||
| templates_table.php | ||