mirror of
https://github.com/moodle/moodle.git
synced 2025-08-05 00:46:50 +02:00
cffc41c27c
Before this change a teacher would be able to see users listed if: * They have an active enrolment and can submit * They have an an inactive enrolment for a role that can submit After this change they will additonally be able to see users listed: * That have an active enrolment and have submitted * That have an inactive enrolment and have submitted This means that if an assignment has it's context frozen all users that have made some form of submission will still be listed. It will also apply if the submission capability is removed from a user. If a user's enrolment is deleted they will not be listed. The submission and grading counts have also been updated so they will reflect the new rules.
177 lines
7.5 KiB
PHP
177 lines
7.5 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* Unit tests for (some of) mod/assign/locallib.php.
|
|
*
|
|
* @package mod_assign
|
|
* @category phpunit
|
|
* @copyright 1999 onwards Martin Dougiamas {@link http://moodle.com}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
global $CFG;
|
|
require_once(__DIR__ . '/../locallib.php');
|
|
require_once($CFG->dirroot . '/mod/assign/tests/generator.php');
|
|
|
|
class mod_assign_locallib_participants extends advanced_testcase {
|
|
use mod_assign_test_generator;
|
|
|
|
public function test_list_participants_blind_marking() {
|
|
global $DB;
|
|
$this->resetAfterTest(true);
|
|
|
|
$course = $this->getDataGenerator()->create_course();
|
|
|
|
$roles = $DB->get_records('role', null, '', 'shortname, id');
|
|
$teacher = $this->getDataGenerator()->create_user();
|
|
|
|
$this->getDataGenerator()->enrol_user($teacher->id,
|
|
$course->id,
|
|
$roles['teacher']->id);
|
|
|
|
$this->setUser($teacher);
|
|
|
|
// Enrol two students.
|
|
$students = [];
|
|
for ($i = 0; $i < 2; $i++) {
|
|
$student = $this->getDataGenerator()->create_user();
|
|
$this->getDataGenerator()->enrol_user($student->id,
|
|
$course->id,
|
|
$roles['student']->id);
|
|
$students[$student->id] = $student;
|
|
}
|
|
|
|
$generator = $this->getDataGenerator()->get_plugin_generator('mod_assign');
|
|
$instance = $generator->create_instance(['course' => $course->id, 'blindmarking' => 1]);
|
|
$cm = get_coursemodule_from_instance('assign', $instance->id);
|
|
$context = context_module::instance($cm->id);
|
|
$assign = new assign($context, $cm, $course);
|
|
|
|
// Allocate IDs now.
|
|
// We're testing whether the IDs are correct after allocation.
|
|
assign::allocate_unique_ids($assign->get_instance()->id);
|
|
|
|
$participants = $assign->list_participants(null, false);
|
|
|
|
// There should be exactly two participants and they should be the students.
|
|
$this->assertCount(2, $participants);
|
|
foreach ($participants as $participant) {
|
|
$this->assertArrayHasKey($participant->id, $students);
|
|
}
|
|
|
|
$keys = array_keys($participants);
|
|
|
|
// Create a grading table, and query the DB This should have the same order.
|
|
$table = new assign_grading_table($assign, 10, '', 0, false);
|
|
$table->setup();
|
|
$table->query_db(10);
|
|
$this->assertEquals($keys, array_keys($table->rawdata));
|
|
|
|
// Submit a file for the second student.
|
|
$data = new stdClass();
|
|
$data->onlinetext_editor = array('itemid'=>file_get_unused_draft_itemid(),
|
|
'text'=>'Submission text',
|
|
'format'=>FORMAT_MOODLE);
|
|
static::helper_add_submission($assign, $participants[$keys[1]], $data, 'onlinetext');
|
|
|
|
// Assign has a private cache. The easiest way to clear this is to create a new instance.
|
|
$assign = new assign($context, $cm, $course);
|
|
|
|
$newparticipants = $assign->list_participants(null, false);
|
|
|
|
// There should be exactly two participants and they should be the students.
|
|
$this->assertCount(2, $newparticipants);
|
|
foreach ($newparticipants as $participant) {
|
|
$this->assertArrayHasKey($participant->id, $students);
|
|
}
|
|
$newkeys = array_keys($newparticipants);
|
|
|
|
// The user who submitted first should now be listed first.
|
|
$this->assertEquals($participants[$keys[1]]->id, $newparticipants[$newkeys[0]]->id);
|
|
$this->assertEquals($participants[$keys[0]]->id, $newparticipants[$newkeys[1]]->id);
|
|
|
|
// Submit for the other student.
|
|
static::helper_add_submission($assign, $participants[$keys[0]], $data, 'onlinetext');
|
|
$assign = new assign($context, $cm, $course);
|
|
$newparticipants = $assign->list_participants(null, false);
|
|
|
|
// The users should still be listed in order of the first submission
|
|
$this->assertEquals($participants[$keys[1]]->id, $newparticipants[$newkeys[0]]->id);
|
|
$this->assertEquals($participants[$keys[0]]->id, $newparticipants[$newkeys[1]]->id);
|
|
|
|
// The updated grading table should have the same order as the updated participant list.
|
|
$table->query_db(10);
|
|
$this->assertEquals($newkeys, array_keys($table->rawdata));
|
|
}
|
|
|
|
/**
|
|
* Tests that users who have a submission, but can no longer submit are listed.
|
|
*/
|
|
public function test_list_participants_can_no_longer_submit() {
|
|
global $DB;
|
|
$this->resetAfterTest(true);
|
|
// Create a role that will prevent users submitting.
|
|
$role = self::getDataGenerator()->create_role();
|
|
assign_capability('mod/assign:submit', CAP_PROHIBIT, $role, context_system::instance());
|
|
// Create the test data.
|
|
$course = self::getDataGenerator()->create_course();
|
|
$coursecontext = context_course::instance($course->id);
|
|
$assign = $this->create_instance($course);
|
|
self::getDataGenerator()->create_and_enrol($course, 'teacher');
|
|
$student1 = self::getDataGenerator()->create_and_enrol($course, 'student');
|
|
$student2 = self::getDataGenerator()->create_and_enrol($course, 'student');
|
|
$cannotsubmit1 = self::getDataGenerator()->create_and_enrol($course, 'student');
|
|
$cannotsubmit2 = self::getDataGenerator()->create_and_enrol($course, 'student');
|
|
// Create submissions for some users.
|
|
$this->add_submission($student1, $assign);
|
|
$this->submit_for_grading($student1, $assign);
|
|
$this->add_submission($cannotsubmit1, $assign);
|
|
$this->submit_for_grading($cannotsubmit1, $assign);
|
|
// Remove the capability to submit from some users.
|
|
role_assign($role, $cannotsubmit1->id, $coursecontext);
|
|
role_assign($role, $cannotsubmit2->id, $coursecontext);
|
|
// Everything is setup for the test now.
|
|
$participants = $assign->list_participants(null, true);
|
|
self::assertCount(3, $participants);
|
|
self::assertArrayHasKey($student1->id, $participants);
|
|
self::assertArrayHasKey($student2->id, $participants);
|
|
self::assertArrayHasKey($cannotsubmit1->id, $participants);
|
|
}
|
|
|
|
public function helper_add_submission($assign, $user, $data, $type) {
|
|
global $USER;
|
|
|
|
$previoususer = $USER;
|
|
|
|
$this->setUser($user);
|
|
$submission = $assign->get_user_submission($user->id, true);
|
|
$submission->status = ASSIGN_SUBMISSION_STATUS_SUBMITTED;
|
|
|
|
$rc = new ReflectionClass('assign');
|
|
$rcm = $rc->getMethod('update_submission');
|
|
$rcm->setAccessible(true);
|
|
$rcm->invokeArgs($assign, [$submission, $user->id, true, false]);
|
|
|
|
$plugin = $assign->get_submission_plugin_by_type($type);
|
|
$plugin->save($submission, $data);
|
|
|
|
$this->setUser($previoususer);
|
|
}
|
|
}
|