moodle/group
Eloy Lafuente (stronk7) 3dd26fe334 MDL-71036 phpunit: assertContains() now performs strict comparison
The methods assertContains() and assertNotContains() now perform
strict (type and value) comparison, pretty much like assertSame()
does.

A couple of new assertContainsEquals() and assertNotContainsEquals()
methods have been created to provide old (non-strict) behavior, pretty
much like assertEquals() do.

Apart from replacing the calls needing a relaxed comparison to those
new methods, there are also a couple of alternative, about how to
fix this, depending of every case:

- If the test is making any array_values() conversion, then it's better
  to remove that conversion and use assertArrayHasKey(), that is not
  strict.
- Sometimes if may be also possible to, simply, cast the expectation
  to the exact type coming in the array. I've not applied this technique
  to any of the cases in core.

Link: https://github.com/sebastianbergmann/phpunit/issues/3426
2021-03-11 23:07:31 +01:00
..
classes MDL-48269 group: Remove additional occurrences of hidepicture 2021-02-16 12:53:34 +08:00
templates MDL-67735 theme_boost: remove bs2 and bs4alpha compatibility css 2020-08-19 08:29:50 +08:00
tests MDL-71036 phpunit: assertContains() now performs strict comparison 2021-03-11 23:07:31 +01:00
assign.php MDL-63354 Group: Rollover text on long group names is not consistent 2018-09-14 09:41:06 +07:00
autogroup.php MDL-45242 Lib: Replace calls to deprecated functions 2021-03-10 10:58:09 +00:00
autogroup_form.php MDL-63620 group: Option for group messaging when auto-creating groups 2019-01-14 13:29:42 +08:00
clientlib.js MDL-54589 group: ensure loader is available before remobing 2016-06-20 09:43:08 +08:00
delete.php MDL-41693 group: Use standard layout for group related pages 2014-01-10 12:26:50 +01:00
externallib.php MDL-67245 group: observe viewfullnames capability. 2020-01-17 12:42:17 +00:00
group.php MDL-42317 output: reviewed standard/base layouts and converted where a better option was available 2014-04-06 15:57:32 +12:00
group_form.php MDL-48269 group: Remove the option to hide the picture of a group 2021-02-16 12:53:30 +08:00
grouping.php MDL-42317 output: reviewed standard/base layouts and converted where a better option was available 2014-04-06 15:57:32 +12:00
grouping_form.php MDL-41305 group: Form improvements for group/grouping creation 2013-09-03 18:31:21 +08:00
groupings.php MDL-32151 group: Use appropriate error langstring error key 2017-06-23 10:27:37 +08:00
import.php MDL-26401 group: change import to use csv_import_reader class 2020-08-19 08:51:32 +08:00
import_form.php MDL-26401 group: add delimiter and encoding fields to import 2020-08-19 11:11:14 +08:00
index.php MDL-45242 Lib: Replace calls to deprecated functions 2021-03-10 10:58:09 +00:00
lib.php MDL-45242 Lib: Replace calls to deprecated functions 2021-03-10 10:58:09 +00:00
members.php MDL-60515 groups: Display group information on the participants page. 2017-10-30 16:43:18 +08:00
module.js MDL-48970 groups: Fix hover description on groups overview page 2015-07-01 21:26:48 +01:00
overview.php MDL-45242 Lib: Replace calls to deprecated functions 2021-03-10 10:58:09 +00:00
tabs.php MDL-38309 Substitute usage of print_tabs() with renderable tabtree 2013-04-15 12:13:13 +10:00
upgrade.txt MDL-48269 group: Remove the option to hide the picture of a group 2021-02-16 12:53:30 +08:00