mirror of
https://github.com/moodle/moodle.git
synced 2025-08-09 10:56:56 +02:00

In order to use the overall feedback in assessments of example submissions and in the assessment form preview, significant improvements in the rendering machinery were done. Workshop class provides two new methods overall_feedback_content_options() and overall_feedback_attachment_options() as they are needed at various scripts and libraries. Overall feedback is displayed as a part of the workshop_assessment_form only if the form is in editable mode (not frozen). If the form is displayed in read-only (frozen) mode, the caller is expected to render the overall feedback and list of attachments (the editor and filemanager elements do not support frozen mode). To do so, the renderable workshop_assessment now loads overall feedback data and provides two new methods get_overall_feedback_content() and get_overall_feedback_attachments() to be used by the renderer. Renderable workshop_submission, workshop_assessment and related classes now accept the workshop instance as the first parameter in their constructors. This way, these renderable classes have access to the workshop API. In the future, the rendering of submission files should be improved in the same way as is done in this patch (i.e. moving the logic and data preparation out of the renderer into the renderable classes).
196 lines
8.4 KiB
PHP
196 lines
8.4 KiB
PHP
<?php
|
|
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* Assess an example submission
|
|
*
|
|
* @package mod
|
|
* @subpackage workshop
|
|
* @copyright 2009 David Mudrak <david.mudrak@gmail.com>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
|
|
require_once(dirname(__FILE__).'/locallib.php');
|
|
|
|
$asid = required_param('asid', PARAM_INT); // assessment id
|
|
$assessment = $DB->get_record('workshop_assessments', array('id' => $asid), '*', MUST_EXIST);
|
|
$example = $DB->get_record('workshop_submissions', array('id' => $assessment->submissionid, 'example' => 1), '*', MUST_EXIST);
|
|
$workshop = $DB->get_record('workshop', array('id' => $example->workshopid), '*', MUST_EXIST);
|
|
$course = $DB->get_record('course', array('id' => $workshop->course), '*', MUST_EXIST);
|
|
$cm = get_coursemodule_from_instance('workshop', $workshop->id, $course->id, false, MUST_EXIST);
|
|
|
|
require_login($course, false, $cm);
|
|
if (isguestuser()) {
|
|
print_error('guestsarenotallowed');
|
|
}
|
|
$workshop = new workshop($workshop, $cm, $course);
|
|
|
|
$PAGE->set_url($workshop->exassess_url($assessment->id));
|
|
$PAGE->set_title($workshop->name);
|
|
$PAGE->set_heading($course->fullname);
|
|
$PAGE->navbar->add(get_string('assessingexample', 'workshop'));
|
|
$currenttab = 'assessment';
|
|
|
|
$canmanage = has_capability('mod/workshop:manageexamples', $workshop->context);
|
|
$isreviewer = ($USER->id == $assessment->reviewerid);
|
|
|
|
if ($isreviewer or $canmanage) {
|
|
// such a user can continue
|
|
} else {
|
|
print_error('nopermissions', 'error', $workshop->view_url(), 'assess example submission');
|
|
}
|
|
|
|
// only the reviewer is allowed to modify the assessment
|
|
if (($canmanage and $assessment->weight == 1) or ($isreviewer and $workshop->assessing_examples_allowed())) {
|
|
$assessmenteditable = true;
|
|
} else {
|
|
$assessmenteditable = false;
|
|
}
|
|
|
|
// load the grading strategy logic
|
|
$strategy = $workshop->grading_strategy_instance();
|
|
|
|
// load the assessment form and process the submitted data eventually
|
|
$mform = $strategy->get_assessment_form($PAGE->url, 'assessment', $assessment, $assessmenteditable);
|
|
|
|
// Set data managed by the workshop core, subplugins set their own data themselves.
|
|
$currentdata = (object)array(
|
|
'feedbackauthor' => $assessment->feedbackauthor,
|
|
'feedbackauthorformat' => $assessment->feedbackauthorformat,
|
|
);
|
|
if ($assessmenteditable and $workshop->overallfeedbackmode) {
|
|
$currentdata = file_prepare_standard_editor($currentdata, 'feedbackauthor', $workshop->overall_feedback_content_options(),
|
|
$workshop->context, 'mod_workshop', 'overallfeedback_content', $assessment->id);
|
|
if ($workshop->overallfeedbackfiles) {
|
|
$currentdata = file_prepare_standard_filemanager($currentdata, 'feedbackauthorattachment',
|
|
$workshop->overall_feedback_attachment_options(), $workshop->context, 'mod_workshop', 'overallfeedback_attachment',
|
|
$assessment->id);
|
|
}
|
|
}
|
|
$mform->set_data($currentdata);
|
|
|
|
if ($mform->is_cancelled()) {
|
|
redirect($workshop->view_url());
|
|
} elseif ($assessmenteditable and ($data = $mform->get_data())) {
|
|
if ($canmanage) {
|
|
if (is_null($assessment->grade)) {
|
|
$workshop->log('add reference assessment', $workshop->exassess_url($assessment->id), $assessment->submissionid);
|
|
} else {
|
|
$workshop->log('update reference assessment', $workshop->exassess_url($assessment->id), $assessment->submissionid);
|
|
}
|
|
} else {
|
|
if (is_null($assessment->grade)) {
|
|
$workshop->log('add example assessment', $workshop->exassess_url($assessment->id), $assessment->submissionid);
|
|
} else {
|
|
$workshop->log('update example assessment', $workshop->exassess_url($assessment->id), $assessment->submissionid);
|
|
}
|
|
}
|
|
|
|
// Let the grading strategy subplugin save its data.
|
|
$rawgrade = $strategy->save_assessment($assessment, $data);
|
|
|
|
// Store the data managed by the workshop core.
|
|
$coredata = (object)array('id' => $assessment->id);
|
|
if (isset($data->feedbackauthor_editor)) {
|
|
$coredata->feedbackauthor_editor = $data->feedbackauthor_editor;
|
|
$coredata = file_postupdate_standard_editor($coredata, 'feedbackauthor', $workshop->overall_feedback_content_options(),
|
|
$workshop->context, 'mod_workshop', 'overallfeedback_content', $assessment->id);
|
|
unset($coredata->feedbackauthor_editor);
|
|
}
|
|
if (isset($data->feedbackauthorattachment_filemanager)) {
|
|
$coredata->feedbackauthorattachment_filemanager = $data->feedbackauthorattachment_filemanager;
|
|
$coredata = file_postupdate_standard_filemanager($coredata, 'feedbackauthorattachment',
|
|
$workshop->overall_feedback_attachment_options(), $workshop->context, 'mod_workshop', 'overallfeedback_attachment',
|
|
$assessment->id);
|
|
unset($coredata->feedbackauthorattachment_filemanager);
|
|
if (empty($coredata->feedbackauthorattachment)) {
|
|
$coredata->feedbackauthorattachment = 0;
|
|
}
|
|
}
|
|
if ($canmanage) {
|
|
// Remember the last one who edited the reference assessment.
|
|
$coredata->reviewerid = $USER->id;
|
|
}
|
|
$DB->update_record('workshop_assessments', $coredata);
|
|
|
|
if (!is_null($rawgrade) and isset($data->saveandclose)) {
|
|
if ($canmanage) {
|
|
redirect($workshop->view_url());
|
|
} else {
|
|
redirect($workshop->excompare_url($example->id, $assessment->id));
|
|
}
|
|
} else {
|
|
// either it is not possible to calculate the $rawgrade
|
|
// or the reviewer has chosen "Save and continue"
|
|
redirect($PAGE->url);
|
|
}
|
|
}
|
|
|
|
// output starts here
|
|
$output = $PAGE->get_renderer('mod_workshop'); // workshop renderer
|
|
echo $output->header();
|
|
echo $output->heading(get_string('assessedexample', 'workshop'), 2);
|
|
|
|
$example = $workshop->get_example_by_id($example->id); // reload so can be passed to the renderer
|
|
echo $output->render($workshop->prepare_example_submission(($example)));
|
|
|
|
// show instructions for assessing as thay may contain important information
|
|
// for evaluating the assessment
|
|
if (trim($workshop->instructreviewers)) {
|
|
$instructions = file_rewrite_pluginfile_urls($workshop->instructreviewers, 'pluginfile.php', $PAGE->context->id,
|
|
'mod_workshop', 'instructreviewers', 0, workshop::instruction_editors_options($PAGE->context));
|
|
print_collapsible_region_start('', 'workshop-viewlet-instructreviewers', get_string('instructreviewers', 'workshop'));
|
|
echo $output->box(format_text($instructions, $workshop->instructreviewersformat, array('overflowdiv'=>true)), array('generalbox', 'instructions'));
|
|
print_collapsible_region_end();
|
|
}
|
|
|
|
// extend the current assessment record with user details
|
|
$assessment = $workshop->get_assessment_by_id($assessment->id);
|
|
|
|
if ($canmanage and $assessment->weight == 1) {
|
|
$options = array(
|
|
'showreviewer' => false,
|
|
'showauthor' => false,
|
|
'showform' => true,
|
|
);
|
|
$assessment = $workshop->prepare_example_reference_assessment($assessment, $mform, $options);
|
|
$assessment->title = get_string('assessmentreference', 'workshop');
|
|
echo $output->render($assessment);
|
|
|
|
} else if ($isreviewer) {
|
|
$options = array(
|
|
'showreviewer' => true,
|
|
'showauthor' => false,
|
|
'showform' => true,
|
|
);
|
|
$assessment = $workshop->prepare_example_assessment($assessment, $mform, $options);
|
|
$assessment->title = get_string('assessmentbyyourself', 'workshop');
|
|
echo $output->render($assessment);
|
|
|
|
} else if ($canmanage) {
|
|
$options = array(
|
|
'showreviewer' => true,
|
|
'showauthor' => false,
|
|
'showform' => true,
|
|
'showweight' => false,
|
|
);
|
|
$assessment = $workshop->prepare_example_assessment($assessment, $mform, $options);
|
|
echo $output->render($assessment);
|
|
}
|
|
|
|
echo $output->footer();
|