mirror of
https://github.com/moodle/moodle.git
synced 2025-08-04 16:36:37 +02:00
135 lines
5.2 KiB
PHP
135 lines
5.2 KiB
PHP
<?php
|
|
/**
|
|
* Moodle_Sniffs_Functions_FunctionCallArgumentSpacingSniff.
|
|
*
|
|
* PHP version 5
|
|
*
|
|
* @category PHP
|
|
* @package PHP_CodeSniffer
|
|
* @author Nicolas Connault <nicolasconnault@gmail.com>
|
|
*
|
|
* @copyright 2009 Nicolas Connault
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
* @version CVS: $Id$
|
|
* @link http://pear.php.net/package/PHP_CodeSniffer
|
|
*/
|
|
|
|
/**
|
|
* Moodle_Sniffs_Functions_FunctionCallArgumentSpacingSniff.
|
|
*
|
|
* Checks that calls to methods and functions are spaced correctly.
|
|
*
|
|
* @category PHP
|
|
* @package PHP_CodeSniffer
|
|
* @author Nicolas Connault <nicolasconnault@gmail.com>
|
|
*
|
|
* @copyright 2009 Nicolas Connault
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
* @version Release: 1.1.0
|
|
* @link http://pear.php.net/package/PHP_CodeSniffer
|
|
*/
|
|
class Moodle_Sniffs_Functions_FunctionCallArgumentSpacingSniff implements PHP_CodeSniffer_Sniff
|
|
{
|
|
|
|
|
|
/**
|
|
* Returns an array of tokens this test wants to listen for.
|
|
*
|
|
* @return array
|
|
*/
|
|
public function register()
|
|
{
|
|
return array(T_STRING);
|
|
|
|
}//end register()
|
|
|
|
|
|
/**
|
|
* Processes this test, when one of its tokens is encountered.
|
|
*
|
|
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
|
* @param int $stackPtr The position of the current token in the
|
|
* stack passed in $tokens.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
|
|
{
|
|
$tokens = $phpcsFile->getTokens();
|
|
|
|
// Skip tokens that are the names of functions or classes
|
|
// within their definitions. For example:
|
|
// function myFunction...
|
|
// "myFunction" is T_STRING but we should skip because it is not a
|
|
// function or method *call*.
|
|
$functionName = $stackPtr;
|
|
$functionKeyword = $phpcsFile->findPrevious(PHP_CodeSniffer_Tokens::$emptyTokens, ($stackPtr - 1), null, true);
|
|
if ($tokens[$functionKeyword]['code'] === T_FUNCTION || $tokens[$functionKeyword]['code'] === T_CLASS) {
|
|
return;
|
|
}
|
|
|
|
// If the next non-whitespace token after the function or method call
|
|
// is not an opening parenthesis then it cant really be a *call*.
|
|
$openBracket = $phpcsFile->findNext(PHP_CodeSniffer_Tokens::$emptyTokens, ($functionName + 1), null, true);
|
|
if ($tokens[$openBracket]['code'] !== T_OPEN_PARENTHESIS) {
|
|
return;
|
|
}
|
|
|
|
$closeBracket = $tokens[$openBracket]['parenthesis_closer'];
|
|
|
|
$nextSeperator = $openBracket;
|
|
while (($nextSeperator = $phpcsFile->findNext(array(T_COMMA, T_VARIABLE), ($nextSeperator + 1), $closeBracket)) !== false) {
|
|
// Make sure the comma or variable belongs directly to this function call,
|
|
// and is not inside a nested function call or array.
|
|
$brackets = $tokens[$nextSeperator]['nested_parenthesis'];
|
|
$lastBracket = array_pop($brackets);
|
|
if ($lastBracket !== $closeBracket) {
|
|
continue;
|
|
}
|
|
|
|
if ($tokens[$nextSeperator]['code'] === T_COMMA) {
|
|
if ($tokens[($nextSeperator - 1)]['code'] === T_WHITESPACE) {
|
|
$error = 'Space found before comma in function call';
|
|
$phpcsFile->addWarning($error, $stackPtr);
|
|
}
|
|
|
|
if ($tokens[($nextSeperator + 1)]['code'] !== T_WHITESPACE) {
|
|
$error = 'No space found after comma in function call';
|
|
$phpcsFile->addWarning($error, $stackPtr);
|
|
} else {
|
|
// If there is a newline in the space, then the must be formatting
|
|
// each argument on a newline, which is valid, so ignore it.
|
|
if (strpos($tokens[($nextSeperator + 1)]['content'], $phpcsFile->eolChar) === false) {
|
|
$space = strlen($tokens[($nextSeperator + 1)]['content']);
|
|
if ($space > 1) {
|
|
$error = 'Expected 1 space after comma in function call; ';
|
|
$error .= $space.' found';
|
|
$phpcsFile->addWarning($error, $stackPtr);
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
// Token is a variable.
|
|
$nextToken = $phpcsFile->findNext(PHP_CodeSniffer_Tokens::$emptyTokens, ($nextSeperator + 1), $closeBracket, true);
|
|
if ($nextToken !== false) {
|
|
if ($tokens[$nextToken]['code'] === T_EQUAL) {
|
|
if (($tokens[($nextToken - 1)]['code']) !== T_WHITESPACE) {
|
|
$error = 'Expected 1 space before = sign of default value';
|
|
$phpcsFile->addWarning($error, $stackPtr);
|
|
}
|
|
|
|
if ($tokens[($nextToken + 1)]['code'] !== T_WHITESPACE) {
|
|
$error = 'Expected 1 space after = sign of default value';
|
|
$phpcsFile->addWarning($error, $stackPtr);
|
|
}
|
|
}
|
|
}
|
|
}//end if
|
|
}//end while
|
|
|
|
}//end process()
|
|
|
|
|
|
}//end class
|
|
|
|
?>
|