mirror of
https://github.com/moodle/moodle.git
synced 2025-08-10 03:16:42 +02:00
85f47bae7f
Namely:
- 3rd param of assertEquals() cannot be null.
- Some incorrect uses of assertNotEmpty().
- Comparing 2 strings now uses strict (===) evaluation.
Link: https://github.com/sebastianbergmann/phpunit/issues/3185
Solution here is one of:
a) Return to the previous situation, making the comparison
softer. That can achieved by forcing different types, so
float == string works.
b) Changing APIs (both forms and database return strings) to
perform some conversion to floats. That would make float
comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.
|
||
|---|---|---|
| .. | ||
| amd | ||
| backup/moodle2 | ||
| classes | ||
| db | ||
| feedback | ||
| lang/en | ||
| pix | ||
| submission | ||
| templates | ||
| tests | ||
| yui | ||
| adminlib.php | ||
| adminmanageplugins.php | ||
| assignmentplugin.php | ||
| batchsetallocatedmarkerform.php | ||
| batchsetmarkingworkflowstateform.php | ||
| extensionform.php | ||
| externallib.php | ||
| feedbackplugin.php | ||
| gradeform.php | ||
| gradingbatchoperationsform.php | ||
| gradingoptionsform.php | ||
| gradingtable.php | ||
| index.php | ||
| lib.php | ||
| locallib.php | ||
| mod_form.php | ||
| module.js | ||
| override_form.php | ||
| overridedelete.php | ||
| overrideedit.php | ||
| overrides.php | ||
| quickgradingform.php | ||
| renderable.php | ||
| renderer.php | ||
| settings.php | ||
| styles.css | ||
| submission_form.php | ||
| submissionconfirmform.php | ||
| submissionplugin.php | ||
| upgrade.txt | ||
| upgradelib.php | ||
| version.php | ||
| view.php | ||