Commit graph

100101 commits

Author SHA1 Message Date
Andrew Nicols
e631b8c5e1 MDL-66979 behat: Set script timeout with timeout factor 2021-01-28 15:27:49 +08:00
Andrew Nicols
ec9bb74405 MDL-66979 behat: Correct selenium2 reference in config-dist 2021-01-28 15:08:10 +08:00
Andrew Nicols
7cff15dc4d MDL-66979 behat: Handle driver stop failure properly
An case was found where the webdriver stop() call could fail in an
AfterScenario hook, leading to a complete rerun if no other errors were
experienced.
2021-01-28 15:07:52 +08:00
Jun Pataleta
67ddc3a9a2 Merge branch 'MDL-70444-dashboard-reset-progress-311' of https://github.com/Peterburnett/moodle into MOODLE_311_STABLE 2021-01-28 09:53:56 +08:00
Andrew Nicols
0911cc0b1e Merge branch 'MDL-70048-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2021-01-28 08:04:22 +08:00
Peter Dias
384d1874ac MDL-70048 dropbox: Augmented unit tests to account for additional params 2021-01-28 07:32:20 +08:00
Peter Dias
0cc373fca6 MDL-70048 dropbox: Update the dropbox search URL.
- Update fetch_dropbox_data to allow different result nodes and version
- Update search to the new URL with new params
- Update the get entities function to account for the change in structure.
2021-01-28 07:32:20 +08:00
Víctor Déniz
40f7439381 Merge branch 'MDL-69816-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-27 18:23:12 +00:00
Sara Arjona
8c696c7f95 MDL-70725 oauth2: move expectException to separate method 2021-01-27 17:54:08 +01:00
Víctor Déniz
c1f4d038d4 Merge branch 'MDL-70585-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-27 10:21:00 +00:00
hiendinh
6972d1a9d8 MDL-70439 Profile: Indicate user email address settings on own profile 2021-01-27 13:40:19 +07:00
Mihail Geshoski
f752cd1a71 MDL-70316 core: Update the emoji categories in the emoji picker 2021-01-27 13:37:47 +08:00
Mihail Geshoski
ef03523704 MDL-70316 core: Document emoji-data upgrade and update version in core 2021-01-27 13:37:47 +08:00
Mihail Geshoski
ea2fac7ca2 MDL-70316 core: Upgrade emoji-data to 6.0.0 2021-01-27 13:37:47 +08:00
Mihail Geshoski
0dd59085a5 MDL-70316 core: Update the categories in the emoji data generator script
The emoji categories were modified in the newer versions of the
emoji-data library. Therefore, the category list in $categorysortorder
needs to be updated with the correct category names in order to properly
sort the categories in the generated emoji data file.
2021-01-27 13:37:47 +08:00
Mihail Geshoski
d63aa867d6 MDL-70316 core: Detect category name changes in the emoji data generator
The emoji data generator script is enabled to detect inconsistencies
between the emoji category names used in the emoji-data library and the
ones used in Moodle. These inconsistencies should be fixed, as soon as
they are detected upon library upgrade.
2021-01-27 13:37:47 +08:00
John Yao
1a013d3fee MDL-65390 accessibility: correct focus after "Show more" clicked 2021-01-27 11:21:52 +11:00
AMOS bot
8194b3151c Automatically generated installer lang files 2021-01-27 00:07:30 +00:00
Eloy Lafuente (stronk7)
cdb14d91f7 Merge branch 'MDL-66979-311-7' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE 2021-01-26 22:44:11 +01:00
Víctor Déniz
d3e82b7640 Merge branch 'MDL-70528-311' of git://github.com/ilyatregubov/moodle into MOODLE_311_STABLE 2021-01-26 14:05:22 +00:00
Ilya Tregubov
f283de3d3e MDL-70528 h5pactivity: Fix block can't be added to h5pactivity page. 2021-01-26 15:44:26 +02:00
Ferran Recio
269449644d MDL-68736 h5pactivity: remove legacy log method 2021-01-26 11:16:14 +01:00
Paul Holden
1fc46d1583 MDL-70163 core: fix attachment validation when localrequestdir absent.
Switch the order of operations performed when collating list of paths
from which a user can include attachments.

First collect all normalised/absolute paths then filter empty entries,
which fixes an issue where $CFG->localrequestdir could be defined but
not exist. This would lead to an empty string being passed to strpos
which triggered a PHP warning.

Co-authored-by: Peter Burnett <peterburnett@catalyst-au.net>
2021-01-25 19:53:41 +00:00
Tim Hunt
c68beeeedf MDL-68970 quiz: prevent page caching during attempts
This ensures that the page reloads if the student uses
the Back or Forwards buttons within an attempt. This
avoids questions being in a stale state, or
the timer showing the wrong time.

Thanks to Jake Dallimore and Russell Boyatt for suggestions
which lead to this fix.
2021-01-25 18:34:24 +00:00
Víctor Déniz
88bb658169 Merge branch 'MDL-65135-311' of https://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-25 15:06:00 +00:00
Ferran Recio
68e1dd3c0b MDL-70634 h5p: minimizing height glitch 2021-01-25 13:54:40 +01:00
Peter Dias
9c08b2b8aa MDL-70339 mod_lti: Use the convenience function to get the right img 2021-01-25 13:39:02 +08:00
Peter Dias
4a6dfb94f2 MDL-68958 mod_imscp: Return manifestfilename as default response. 2021-01-25 13:23:15 +08:00
Peter Burnett
81b25fc274 MDL-70444 my: Improved robustness of bulk dashboard reset 2021-01-25 13:55:41 +10:00
Peter Dias
76f3835477 MDL-56772 core: Update the picker styles for rtl langs 2021-01-25 11:36:32 +08:00
Adrian Greeve
54b81d0f32 Merge branch 'MOODLE_311_MDL-69631-v3' of https://github.com/golenkovm/moodle into MOODLE_311_STABLE 2021-01-25 08:14:43 +08:00
Andrew Nicols
0bac7faf90 MDL-66979 behat: Warn about old behat.yml file location 2021-01-23 20:44:23 +08:00
AMOS bot
6dd97088db Automatically generated installer lang files 2021-01-23 00:07:28 +00:00
Ferran Recio
e134a42963 MDL-70309 libraries: upgrade mongodb integration files 2021-01-22 14:44:29 +01:00
Ferran Recio
e941b105ac MDL-70309 libraries: upgrade mongodb to version 1.8.0 2021-01-22 14:44:29 +01:00
Paul Holden
4b01d3bea0 MDL-70585 course: deeper clean of path names in course export.
This fixes an issue on those systems that don't fully support unicode
characters within zip structures, which subsequently led to broken
links when browsing downloaded course content.
2021-01-22 08:15:25 +00:00
Ilya Tregubov
9874857540 MDL-64866 message: Remove message/defaultoutputs.php
and final deprecation of admin_page_defaultmessageoutputs class.
2021-01-22 09:45:54 +02:00
Andrew Nicols
19db0c4b44 MDL-66979 behat: Rename and warn on old config 2021-01-22 14:52:19 +08:00
Andrew Nicols
dd4693ac0c MDL-66979 behat: Uncomment step disabled for old firefox 2021-01-22 14:52:18 +08:00
Andrew Nicols
6704b2b5a4 MDL-66979 behat: Pad messaging drawer
This works around an issue highlighted by MDL-70411 whereby some of the
messaging links are covered by the scrollbar in Firefox on MacOS.
2021-01-22 14:52:18 +08:00
Andrew Nicols
d467f87bd7 MDL-66979 behat: Work around weird gradebook focus behaviour
I can't expand this one in a sane fashion but the older JS is doing some
weird and wonderful things with focus.

The only way I could get this to behave correctly was to move away from
the field, move back to it, and then move away again. Other combinations
failed in different browsers for different reasons.
2021-01-22 14:52:18 +08:00
Andrew Nicols
0bd971ebc0 MDL-66979 behat: availability field extends textarea
The availability behat field extends the textarea type, and therefore
needs to include this type.
2021-01-22 14:52:18 +08:00
Andrew Nicols
13c2654eb1 MDL-66979 behat: Improve chromeOptions configuration
Simplify the chromeOptions configuration to improve readability.
2021-01-22 14:52:18 +08:00
Andrew Nicols
a85f7f83b9 MDL-66979 question: Improve behat test reliability
Expand all fieldsets rather than individual fieldsets.

This can fail in some situations where the page moves as the first
fieldset opens and HTML transitions take effect. This causes subsequent
fieldsets to move after WebDriver has calculated the click target.
2021-01-22 14:52:18 +08:00
Andrew Nicols
c501f5fa25 MDL-66979 mod_assign: Stop clicking the user filters
Remove the documented hack which was re-opening a popup because it
"closes for some reason". It no longer randomly closes.
2021-01-22 14:52:18 +08:00
Andrew Nicols
3ab052e70d MDL-66979 behat: Switch to generators
These steps were creating content manually in an unnecessary fashion. I
had to debug some issues with features in these areas so took the time
to update them to make use of data generators, which are significantly
faster.
2021-01-22 14:52:18 +08:00
Andrew Nicols
f60b5ea4db MDL-66979 behat: Remove unused var 2021-01-22 14:52:18 +08:00
Andrew Nicols
ac88e330a6 MDL-66979 behat: Whitespace fix 2021-01-22 14:52:18 +08:00
Andrew Nicols
be9e3ebd34 MDL-66979 behat: Remove manually triggered events
Behat should not trigger Synthetic browser events. It is incorrect to do
so as the UI should be used to trigger events correctly.

The W3C WebDriver specification explicitly states when and where these
events will be triggered from (the browser) and therefore there is no
ambiguity and no need to synthetically trigger them from Behat.
2021-01-22 14:52:18 +08:00
Andrew Nicols
74a156c3d0 MDL-66979 group: Replace direct element interaction with steps
The W3C WebDriver leads to faster operation of individual steps which
highlights where WebDriver is moving to a new step faster than the
browser can process it.

The solution here is to use the `execute` function to interact with the
browsers as this makes use of the various wait and check steps.
2021-01-22 14:52:17 +08:00