Commit graph

100101 commits

Author SHA1 Message Date
Andrew Nicols
2c967d8d07 MDL-66979 behat: Remove unnecessary steps which fail
These steps were completely pointless and were failing with the W3C
Webdriver becuase focus was never on the Update Profile button in the
first place.

At a minimum we should remove the Focus change step as it not valid, but
the following step is also pointless.
2021-01-22 14:52:17 +08:00
Andrew Nicols
d2ceac9d3d MDL-66979 scorm: Increase behat window size
On Firefox there can be some issues with ensuring that all nodes are
visible in order to click them.

This is likely an upstream geckodriver bug and not one that can be
easily addressed across all of Moodle.

In this instance the "Next" button is just outside the Visible Window,
but it is in an iFrame which is fully visible. In this situation
Firefox is unable to click the button but does not error.
2021-01-22 14:52:17 +08:00
Andrew Nicols
45b0f89d87 MDL-66979 behat: Scroll nodes into view before hover
The W3C Specification does not require that a NodeElement be in the
current viewport before triggering a mouseOver. As a result the
mouseOver will generate an Exception because the element is not in the
viewport, and the X/Y co-ordinates are invalid.

To handle this the node is scrolled into view.
2021-01-22 14:52:17 +08:00
Andrew Nicols
a6512819b3 MDL-66979 behat: Fix window switching
Normalise switching of window contexts by setting the main window name
to a null.

Where the window has no name (null/empty), then the root context is
selected.
2021-01-22 14:52:17 +08:00
Andrew Nicols
740c2e80d8 MDL-66979 behat: Use tab to blur current focus
The focus should be on something, rather than removed.

The way in which focus removal works can lead to side effects.
2021-01-22 14:52:17 +08:00
Andrew Nicols
44d9f77cae MDL-66979 behat: Update passwordunmask form field control
Update the passwordunmask form field type for behat to interact with the
form element as a human would rather than via synthetic event triggers.
2021-01-22 14:52:17 +08:00
Andrew Nicols
076ec2766f MDL-66979 behat: iFrames must have a name for switchTo
The W3C WebDriver protocol supports switching of contexts using a named
context, and not the class asscoiated with that context.
2021-01-22 14:52:17 +08:00
Andrew Nicols
eb03e5c7b7 MDL-66979 mod_data: Improve behat chart data step
Charts data visibility is more reliable when checked via the
aria-expanded attribute.

The isVisible attribute can cause some failures under Firefox.
2021-01-22 14:52:17 +08:00
Andrew Nicols
d196e8093b MDL-66979 behat: Handle JS on elements better
This change introduces a new function to execute Javascript directly on
a node.

This should not, ordinarily, be used directly by steps, but may be
required in other parts of the Behat interaction.
2021-01-22 14:52:17 +08:00
Andrew Nicols
2d68b303f9 MDL-66979 behat: Rename selenium config to webdriver
The PHP WebDriver Mink Driver does not necessarily require Selenium. It
supports Selenium 3 upwards, and can be used directly with ChromeDriver,
EdgeDriver, SafariDriver, GeckoDriver, and others.

It therefore uses a slightly different configuraitno path.
2021-01-22 14:52:17 +08:00
Andrew Nicols
c5d25f9017 MDL-66979 behat: Core updates for W3C WebDriver
This commit updates core Behat features to make use of the
php-webdriver/webdriver library instead of the legacy Instaclick
library.

Most of these changes relate to use of features of WebDriver which we
are required to use directly rather than through the Mink Driver.
2021-01-22 14:52:16 +08:00
Andrew Nicols
675ff118f2 MDL-66979 behat: Switch to new W3C Behat driver
This commit updates the composer dependencies to make use of the updated
version of moodlehq/moodle-behat-extension which depends upon the
php-webdriver/webdriver and relevant Mink WebDriver.
2021-01-22 14:52:16 +08:00
Jake Dallimore
500bee1af0 weekly release 3.11dev 2021-01-22 11:30:46 +08:00
Jake Dallimore
b9896f4a8e NOBUG: Fixed file access permissions 2021-01-22 11:30:46 +08:00
Jake Dallimore
6db835f666 Merge branch 'install_311_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_311_STABLE 2021-01-22 11:30:43 +08:00
Tim Hunt
0dedf60a9a MDL-46256 count_words: fix handling of paragraphs 2021-01-21 09:54:01 +00:00
Tim Hunt
063dce507a MDL-46256 count_letters: an unit tests and fix HTML editity handling 2021-01-21 09:54:01 +00:00
Tim Hunt
b4fd86591d MDL-46256 word count: Convert existing tests to a data provider 2021-01-21 09:54:01 +00:00
Paul Holden
b19e413368 MDL-70315 libraries: upgrade Javascript polyfills.
* mdn-polyfills@5.20.0
 * url-polyfill@1.1.12
2021-01-21 08:58:46 +00:00
Jun Pataleta
a10a3f94c7 Merge branch 'MDL-70297-311' of git://github.com/ilyatregubov/moodle into MOODLE_311_STABLE 2021-01-21 12:19:04 +08:00
Adrian Greeve
23baaf8f61 Merge branch 'MDL-57020-311-allow_delete_unused_scale' of https://github.com/sharidas/moodle into MOODLE_311_STABLE 2021-01-21 12:02:10 +08:00
Sujith Haridasan
1215070d8d MDL-57020 scales: Allow deletion of unused scales in forum
Allow deletion of unused scales used in a
forum for the course.

Signed-off-by: Sujith Haridasan <sujith@moodle.com>
2021-01-21 09:16:46 +05:30
Mikhail Golenkov
04298671e5 MDL-69631 assign: Add 'Draft' filter for grading table 2021-01-21 14:41:36 +11:00
Jun Pataleta
84922dc4fc Merge branch 'MDL-70301-311' of https://github.com/Chocolate-lightning/moodle into MOODLE_311_STABLE 2021-01-21 11:33:35 +08:00
Mathew May
ec4d3aa389 MDL-70301 lib: Update thirdpartylibs scssphp 2021-01-21 10:35:24 +08:00
Mathew May
9a3e290efb MDL-70301 lib: Upgrade scssphp to 1.4.1 2021-01-21 10:35:10 +08:00
Adrian Greeve
1263d09396 Merge branch 'MDL-70302-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2021-01-21 09:48:34 +08:00
Peter Dias
c60b950b87 MDL-70302 core: Update the lib's readme, xml and upgrade files 2021-01-21 09:34:33 +08:00
Eloy Lafuente (stronk7)
b390eebb7a Merge branch 'MDL-70317-311' of git://github.com/lucaboesch/moodle into MOODLE_311_STABLE 2021-01-20 23:27:11 +01:00
Eloy Lafuente (stronk7)
85ae2babde Merge branch 'MDL-70134_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-01-20 22:47:30 +01:00
Luca Bösch
beec305005 MDL-70317 filter_mathjaxloader: update default CDN to 2.7.9 2021-01-20 22:02:09 +01:00
Eloy Lafuente (stronk7)
2236ac67b0 Merge branch 'MDL-70055-MOODLE_311_STABLE' of https://github.com/kabalin/moodle into MOODLE_311_STABLE 2021-01-20 19:44:56 +01:00
Eloy Lafuente (stronk7)
e24754693a Merge branch 'MDL-70291-311-1' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2021-01-20 19:18:07 +01:00
Sara Arjona
e49ad9eeb6 MDL-70438 contentbank: fix behat issue with classic 2021-01-20 19:02:19 +01:00
Eloy Lafuente (stronk7)
c5dd5a6fe1 Merge branch 'MDL-70296-311-1' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2021-01-20 17:19:40 +01:00
Jun Pataleta
e4527dc68f Merge branch 'MDL-70319-311' of git://github.com/ilyatregubov/moodle into MOODLE_311_STABLE 2021-01-20 22:40:35 +08:00
Jun Pataleta
93ae28874e Merge branch 'MDL-70300-311' of https://github.com/Chocolate-lightning/moodle into MOODLE_311_STABLE 2021-01-20 17:13:37 +08:00
Mathew May
95fa1e387e MDL-70300 core_lib: Update thirdpartylibs php-css-parser 2021-01-20 15:53:10 +08:00
Nadav Kavalerchik
99b1551e54 MDL-66932 theme/boost: Use LTR directionality to display user % grades 2021-01-20 09:29:38 +02:00
Jun Pataleta
7627763dfe Merge branch 'MDL-70562-311' of git://github.com/lucaboesch/moodle into MOODLE_311_STABLE 2021-01-20 15:01:27 +08:00
Jake Dallimore
eebb226156 Merge branch 'MDL-69333-fingerprint-checks-MOODLE_311_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_311_STABLE 2021-01-20 11:24:42 +08:00
Adrian Greeve
b2bad0b648 Merge branch 'MDL-70438-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE 2021-01-20 09:51:06 +08:00
Simey Lameze
3e2de0c6c9 MDL-70648 calendar: upgrade step to delete wrong cat events 2021-01-20 09:32:09 +08:00
Simey Lameze
b0aa55a75a MDL-70648 calendar: add form validation for category events 2021-01-20 09:26:33 +08:00
Brendan Heywood
6f60d650d3 MDL-69333 report_security: Add checks for many public & private urls 2021-01-20 11:20:31 +11:00
Brendan Heywood
63e7f2a64f MDL-69333 error: Allow explicit http error codes in web server config
eg in Apache you could capture 403 errors and funnel them to this
error handler script and also transform them to 404s:

ErrorDocument 403 /error/index.php?code=404
2021-01-20 11:20:31 +11:00
Eloy Lafuente (stronk7)
4c698ab3d3 Merge branch 'MDL-70159-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-01-19 23:44:54 +01:00
Jun Pataleta
dbd55e05ae Merge branch 'MDL-70292-311' of git://github.com/ilyatregubov/moodle into MOODLE_311_STABLE 2021-01-20 00:12:11 +08:00
Sara Arjona
8510e9d881 Merge branch 'MDL-70303-311' of git://github.com/ferranrecio/moodle into MOODLE_311_STABLE 2021-01-19 16:50:09 +01:00
Ferran Recio
8408a82960 MDL-70303 libraries: upgrade GeoIP to 2.11.0 and MaxMind DB to 1.9.0 2021-01-19 16:35:39 +01:00