Commit graph

2661 commits

Author SHA1 Message Date
Damyon Wiese
284babb0d7 MDL-64524 assign: Styles editpdf comments
Properly display the list of comments, but limiting their size (use title to indicate the full comments).
When there are too many comments, show a scrollbar in the menu.
2019-04-01 12:17:27 +08:00
Mark Nelson
2a0b517257 MDL-65173 message_email: removed bogus logic
This reverts commit 0f38e62970.
2019-03-25 17:12:53 +08:00
Jun Pataleta
f2ad613278 MDL-61537 assignfeedback_editpdf: Check for existence of old test images
Since error suppression was removed with the call to unlink() to make
sure that there are no previous test image files before testing for the
gs path, make sure that it exists first before deleting to prevent it
from throwing any errors.
2019-03-21 22:38:05 +08:00
Adrian Greeve
004a16f9ad Merge branch 'MDL-61537-Master' of https://github.com/tuanngocnguyen/moodle 2019-03-21 08:57:02 +08:00
sam marshall
05a5d547b3 MDL-64979 Behat: Add option to increase timeouts 2019-03-19 17:17:55 +00:00
Nathan Nguyen
9432553b1c MDL-61537 assignfeedback_editpdf: Rotate PDF page
Add page rotation feature.
2019-03-15 15:02:33 +11:00
Jun Pataleta
02d6bfaf98 Merge branch 'MDL-62465-master' of git://github.com/damyon/moodle 2019-03-05 15:30:31 +08:00
Damyon Wiese
f88c613135 MDL-62465 assign: Remove behat step
We don't need to open the menu to choose the "Grade" item, we can just click the button.
2019-03-05 14:41:25 +08:00
Damyon Wiese
a0e3d29fcf MDL-64678 assign: More ios touch
Only disable touch scrolling when the touch event is within the drawing region of the canvas.
2019-03-05 08:42:31 +08:00
Eloy Lafuente (stronk7)
3c1bb2334d Merge branch 'MDL-64444-master' of git://github.com/jleyva/moodle 2019-02-28 01:19:13 +01:00
Eloy Lafuente (stronk7)
daf358f0cd Merge branch 'MDL-64878-master' of git://github.com/damyon/moodle 2019-02-27 18:58:26 +01:00
Sara Arjona
a0e20ce87c Merge branch 'MDL-64761-master' of git://github.com/dpalou/moodle 2019-02-27 15:36:18 +01:00
Damyon Wiese
40fe153816 MDL-64878 grades: Update delete_instance
When grades are deleted, it needs to know the context so any files
in the gradebook can be deleted. This means module delete_instance
functions must delete the grade_item before they delete the module record.
2019-02-27 10:37:54 +08:00
Sara Arjona
44d5c25469 Merge branch 'MDL-58428-master' of git://github.com/sarjona/moodle 2019-02-26 13:25:54 +01:00
Mathew May
cce298035d MDL-58428 theme: Move templates from mod/assign 2019-02-26 12:56:14 +01:00
Simey Lameze
c3781ebeb3 MDL-64879 mod_assign: deprecate legacy assign_cron() function 2019-02-26 11:25:58 +08:00
Simey Lameze
b0218089d9 MDL-64879 mod_assign: convert cron to scheduled task 2019-02-25 10:41:31 +08:00
David Monllaó
4f3f8fba67 Merge branch 'MDL-45151-master' of git://github.com/damyon/moodle 2019-02-19 06:39:24 +01:00
Damyon Wiese
7a5669557c MDL-64377 assign: Behat test fix
The behat assumed that after editing a submission, the next page would be the assignment
front page even though we were previously on the "view all submissions" page. The extra
step to go back to the "view all submissions" page is no longer needed so has been removed.
2019-02-07 09:33:52 +08:00
Damyon Wiese
74f6a5d482 MDL-64507 assign: Behat test "Hide grader identity"
Test that you can't see the identity of the grader even on previous attempts.
2019-02-07 12:16:46 +13:00
Dan Marsden
5600faa466 MDL-64507 mod_assign: check grader visibility for previous submissions. 2019-02-07 12:14:56 +13:00
Jun Pataleta
933f48b4a3 Merge branch 'MDL-61405-master' of git://github.com/damyon/moodle 2019-02-06 13:12:49 +08:00
Damyon Wiese
77f31a47dd MDL-61405 assign: Multiple pdfs are expected
In the same page it is normal (expected) to have multiple links to different annotated pdfs.

In the grading page, we also abort pending ajax progress when the current user is changed.
2019-02-06 09:38:59 +08:00
Sara Arjona
34c6d98fd7 Merge branch 'MDL-62893_master' of https://github.com/mfabriczy/moodle 2019-02-05 20:06:21 +01:00
Eloy Lafuente (stronk7)
e6d28cbb40 Merge branch 'MDL-64377-master' of git://github.com/damyon/moodle 2019-02-05 12:46:01 +01:00
Marcus Fabriczy
f5d1dbb37f MDL-62893 mod: Grade visibility bug in the Outline/Complete reports
Grades that have been hidden will appear in the outline/complete
report - even if the user is a student.

The modules that have been fixed are:
* mod_assign
* mod_data
* mod_forum
* mod_glossary
* mod_lesson
* mod_scorm
* mod_workshop
2019-02-05 20:01:32 +10:30
Damyon Wiese
37fc47f17d MDL-64377 assign: Allow remove submission
Calls each submission plugin to remove the data for a submission.
2019-02-05 11:54:49 +08:00
Dani Palou
468ee73bba MDL-64761 assign: Add tests for hidden grader in WS 2019-02-04 15:29:47 +01:00
Dani Palou
208e1376be MDL-64761 assign: Return grader -1 when hidden in get_submission_status 2019-02-04 15:29:47 +01:00
Eloy Lafuente (stronk7)
9ee3b3d1df Merge branch 'MDL-63975-master' of git://github.com/damyon/moodle 2019-02-04 13:21:37 +01:00
Sara Arjona
2f2b0bfc61 Merge branch 'MDL-63578-master' of git://github.com/damyon/moodle 2019-02-01 13:31:31 +01:00
Damyon Wiese
5ac7838e3c MDL-45151 assign: Add anonymous flag to events if blindmarking 2019-02-01 09:12:48 +08:00
Damyon Wiese
13543706a5 MDL-63975 assign: Fix error when there is no grader 2019-01-31 13:09:06 +08:00
Damyon Wiese
ff9a0f8289 MDL-63578 assign: Better page titles
Use the context function get_context_name() to set the page title. This will
change it from "Assignment" to "C1: Important foods to eat".

The get_context_name() for activity modules is updated to include the course short name (not the
name of the activity type).
2019-01-31 10:47:24 +08:00
Juan Leyva
cf0cad920c MDL-64444 mod_assign: Use correct permissions for context locking
Some WebServices does not use the correct permissions.
This mean that when a context is locked, they don't behave as expected.
2019-01-30 15:07:58 +01:00
Sara Arjona
d067783f2b Merge branch 'MDL-64313-master' of git://github.com/damyon/moodle 2019-01-29 12:35:31 +01:00
Sara Arjona
91f514eafa Merge branch 'MDL-56604-master' of git://github.com/damyon/moodle 2019-01-28 13:32:38 +01:00
Damyon Wiese
3c4fd88193 MDL-56604 assign: Group submission status
On the page listing all assignments for the course,
show the status of the group submission if teamsubmissions is enabled
for the assignment.
2019-01-24 14:33:54 +08:00
Sara Arjona
7d4a9008fa Merge branch 'MDL-63628-master' of git://github.com/damyon/moodle 2019-01-22 12:19:41 +01:00
Damyon Wiese
2fbd00cb22 MDL-63628 accessibility: Trigger file links with keyboard 2019-01-22 08:39:49 +08:00
Luca Bösch
df0a2e21dd MDL-64360 mod_assign: Add help icon to notify students checkbox. 2019-01-18 00:02:49 +01:00
Sara Arjona
0f1377cc31 Merge branch 'MDL-60082-master' of git://github.com/damyon/moodle 2019-01-14 12:03:06 +01:00
Jake Dallimore
111dfd2db5 Merge branch 'MDL-64375-master' of git://github.com/damyon/moodle 2019-01-09 15:33:09 +08:00
Andrew Nicols
8feef7308a Merge branch 'MDL-64400-master' of git://github.com/aanabit/moodle 2019-01-08 08:27:06 +08:00
Damyon Wiese
9a4c6a245c MDL-64375 gradingform_rubric: Styles for overflow
Allow people to define lots of levels, and make the scroll region just the rubric table,
not the entire content region.
2019-01-04 08:44:10 +08:00
Eloy Lafuente (stronk7)
a12207be25 MDL-63276 upgrade: clean < 3.2.0 upgrade steps
3.7 (min PHP 7.1) requires 3.2 (first version supporting PHP 7.1)

This just deletes all the upgrade steps previous to 3.2.0. Some
small adjustments, like adding missing MOODLE_INTERNAL or tweaking
globals can also be applied when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2016120500 (v3.2.0) as anti-cheating measure.

Next commit will get rid of/deprecate all the upgradelib functions
not used anymore in codebase. (note there isn't any this time).
2019-01-03 01:17:17 +01:00
Amaia Anabitarte
0f38e62970 MDL-64400 core_messages: Mark notifications sent via email as read 2018-12-27 09:15:53 +01:00
Andrew Nicols
bf197c166c Merge branch 'MDL-62223-master' of git://github.com/Kathrin84/moodle 2018-12-20 11:32:50 +08:00
Jun Pataleta
e63084ec1b Merge branch 'MDL-60474-master' of git://github.com/damyon/moodle 2018-12-19 10:14:13 +08:00
Damyon Wiese
064f15033f MDL-60474 assign: Consistent user filters
Use the current filters and sorting on the user grading table in the single
page grading app when it is possible.

This replaces the popover used to configure the filters to one that closely matches the
one from the grading table. It supports standard filters, workflow filters and allocated marker filters.

It will also support group filtering and suspended user filtering but we don't show the controls for those in
the single grading page.
2018-12-19 10:10:23 +08:00