moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 01:16:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
107422 commits 37 branches 540 tags 1.3 GiB
Commit graph

2661 commits

Author SHA1 Message Date
Mark Nelson
66b5036805 MDL-27520 assignfeedback_comments: fix Behat failures 2018-10-18 18:32:59 +08:00
David Monllao
a9bbbd7a50 Merge branch 'MDL-27520_master' of git://github.com/markn86/moodle 2018-10-17 15:42:55 +02:00
Mark Nelson
464a9dc556 MDL-27520 assignfeedback_comments: is_feedback_modified considers files 2018-10-17 15:57:27 +08:00
Mark Nelson
b7a9b6f872 MDL-27520 assignfeedback_comments: updated privacy provider 2018-10-17 15:57:27 +08:00
Mark Nelson
0e732f5d33 MDL-27520 assignfeedback_comments: added backup/restore of files 2018-10-17 13:15:49 +08:00
Mark Nelson
3672775931 MDL-27520 assignfeedback_comments: copy files to feedback 
This respects the setting 'Comment inline' where the content
of a submission is copied into the feedback form.
 2018-10-17 13:15:49 +08:00
Mark Nelson
ea241998e6 MDL-27520 assignfeedback_comments: allow files in the comments feedback 
Also use new API to add files to gradebook.
 2018-10-16 13:06:58 +08:00
Mark Nelson
faa438bad6 MDL-27520 mod_assign: added API for feedback plugins 2018-10-16 13:06:58 +08:00
Eloy Lafuente (stronk7)
bbfda3b9db Merge branch 'MDL-62319-master' of git://github.com/damyon/moodle 2018-10-15 23:54:51 +02:00
Damyon Wiese
a0b009115e MDL-62319 assignfeedback_editpdf: Disable touch scrolling 
Assignment editpdf canvas provides it's own scroll tool and the native browser one breaks
the rest of the tools for the canvas. Turn it off.
 2018-10-11 13:28:01 +08:00
Nathan Nguyen
923641f71c MDL-62319 Assign: Grading interface is broken when using iOS 11.3 devices 2018-10-11 13:27:56 +08:00
Eloy Lafuente (stronk7)
89957b6c34 Merge branch 'MDL-63439-master' of git://github.com/damyon/moodle 2018-10-10 00:47:40 +02:00
Damyon Wiese
490e48a4df MDL-63439 assign: Unicode charsets for pdf 
Prefer to use freesans font for generated pdfs as it has the biggest charset support.
 2018-10-09 09:28:06 +08:00
Adrian Greeve
812c409203 MDL-62491 mod_assign: Fill in the rewrite plugin urls properly. 2018-10-08 09:00:08 +08:00
Eloy Lafuente (stronk7)
682357004f Merge branch 'MDL-60685-master' of git://github.com/damyon/moodle 2018-10-03 00:23:10 +02:00
Eloy Lafuente (stronk7)
51181541ab Merge branch 'MDL-62279-master' of git://github.com/damyon/moodle 2018-09-25 23:25:10 +02:00
Eloy Lafuente (stronk7)
fc008d6769 MDL-57610 assignfeedback_editpdf: add missing UK to install.xml 2018-09-25 15:21:42 +02:00
Adam Olley
1afbb97b6b MDL-57610 assignfeedback_editpdf: integration cleanup 
* Add a note to upgrade.php to notify devs/admins of the new setting.
* Replace update_record with set_field.
* Add missing phpdoc.
 2018-09-25 09:54:39 +09:30
Adam Olley
bc32547da9 MDL-57610 assignfeedback_editpdf: Add test coverage for conversion task 
Without this, we have no coverage of the convert_submissions task. This test
validates it both works normally, and that it also skips queued items that have
exceeded the conversion attempt limit introduced in this improvement.
 2018-09-18 14:14:24 +09:30
Adam Olley
b722a457ad MDL-57610 assignfeedback_editpdf: remove queued jobs that keep failing 
Without this, its possible to get a document in the editpdf conversion queue
that keeps failing - and in some cases completely crashing the PHP script
despite exception handling - which ends up blocking the processing of the queue
entirely.

This change allows for a configurable number of attempts the conversion
task will perform before removing the item from the queue.
 2018-09-17 09:30:43 +09:30
David Monllao
ffc4cc9a25 Merge branch 'MDL-62944' of https://github.com/NeillM/moodle 2018-09-04 12:15:36 +02:00
David Monllao
adb8eb9c9c Merge branch 'MDL-55993-master' of https://github.com/albertolarah/moodle 2018-09-04 10:51:28 +02:00
David Monllao
dfc6f782e1 Merge branch 'MDL-38301-master' of git://github.com/junpataleta/moodle 2018-09-03 12:44:50 +02:00
Alberto Lara Hernández
96a037f755 MDL-55993 mod_assign: web services don´t set a URL. 2018-09-03 12:18:41 +02:00
Neill Magill
bbf1fde412 MDL-62944 activities: Activities should not require capability 
Activities should not require the user manipulating them to have
calendar capabilities for their events to be added to the Moodle
calendar
 2018-08-31 10:15:37 +01:00
Neill Magill
196aa50489 MDL-62944 activities: Test adding activities with no calendar capability 2018-08-31 10:15:36 +01:00
Eloy Lafuente (stronk7)
cf76059eda Merge branch 'MDL-62535-master' of git://github.com/abgreeve/moodle 2018-08-30 01:19:57 +02:00
Andrew Nicols
75ad50cba0 Merge branch 'MDL-62782-master' of git://github.com/damyon/moodle 2018-08-28 07:06:22 +08:00
Andrew Nicols
fdab90a7d4 Merge branch 'MDL-53024-master' of git://github.com/damyon/moodle 2018-08-27 15:45:57 +08:00
Zig Tan
8f7d07fa7d MDL-38301 mod_assign: Fix date validation logic & message consistency 2018-08-27 15:26:22 +08:00
Damyon Wiese
334db37769 MDL-53024 assign: Remove incorrect logic in query 
We are simplifying this query so it will return grades if the attempt matches
the submission attempt, or there is no submission. The case where there is a grade
but no submission can happen only for group assignments.
 2018-08-22 12:59:10 +08:00
Víctor Déniz Falcón
02fda279ed MDL-57281 behat: deprecated step definition I navigate to node in 
Definition step deprecated and affected tests modified.
 2018-08-20 12:53:26 +01:00
Adrian Greeve
620dbfbe89 MDL-62535 mod_assign: Update to providers to include adv grading. 2018-08-20 11:32:01 +08:00
Eloy Lafuente (stronk7)
9c1c0de78c Merge branch 'MDL-61650-master' of git://github.com/damyon/moodle 2018-08-14 16:49:44 +02:00
Andrew Nicols
bc51085174 Merge branch 'MDL-62643-master' of git://github.com/damyon/moodle 2018-08-14 09:04:17 +08:00
Eloy Lafuente (stronk7)
521ebb76b0 Merge branch 'MDL-61870-master' of git://github.com/damyon/moodle 2018-08-07 23:48:31 +02:00
Damyon Wiese
8cee90e3bf MDL-61650 assign: More consistent empty text 
Consistently check for empty submissions with count_words(trim($text)).
 2018-08-03 16:52:31 +08:00
Damyon Wiese
cc9384f121 MDL-62279 assign: Properly set the defaults 
Before an assignment has been created, we need to use the site defaults,
not the per instance defaults for the settings.
 2018-08-03 15:03:53 +08:00
Damyon Wiese
851b5c7f2a MDL-60685 assign: Do not falsely use admin user 
When an assign_grades record is automatically populated, do not use the admin user as the default grader.

This would generate false information on the assignment summary screen and send false notifications from
the admin user.
 2018-08-02 14:19:34 +08:00
Damyon Wiese
192e48bb90 MDL-61870 mod_assign: Conditionally backup groups 
When group info is not backed up, do not backup assignment submissions or overrides that related to a specific group.
We are already correctly not restoring them, but it is more robust not to include them in the backup file at all.
 2018-08-02 12:55:13 +08:00
Zig Tan
8ea4df50c9 MDL-61870 mod_assign: Fix/clean up imported group override duedates 
Applying patch supplied from Damyon Wiese to address the root-cause
of this issue in the backup/restore logic.
 2018-08-02 12:55:13 +08:00
Zig Tan
6bcc6f877a MDL-61870 mod_assign: Fix/clean up imported group override duedates 
- Prevent group override duedate events from being imported when groups are excluded
- Clean up any existing group override duedate events when editing assignment in upgradelib.php
- Updated lib.php unit tests
 2018-08-02 12:55:12 +08:00
David Monllao
f3e240e7e0 Merge branch 'MDL-59611-master' of git://github.com/damyon/moodle 2018-07-31 13:30:41 +02:00
Jun Pataleta
77b6d458e5 Merge branch 'MDL-58768-master-2' of git://github.com/rezaies/moodle 2018-07-31 16:18:44 +08:00
Adrian Greeve
5454e72c21 MDL-55188 events: First deprecation of eventslib.php 2018-07-30 09:23:54 +08:00
Shamim Rezaie
fda4374a67 MDL-58768 mod_assign: Added userid param to calendar callbacks 
The mod_assign_core_calendar_is_event_visible and mod_assign_core_calendar_provide_event_action
functions now accept a new parameter ($userid) so they are not always dependet to the logged in user.
 2018-07-28 07:51:33 +10:00
Shamim Rezaie
faa5d173cc MDL-58768 mod_assign: Add $user param to assign::can_grade 2018-07-28 07:51:32 +10:00
Tony Butler
9ed5b0c1f6 MDL-59611 mod_assign: Move help icons for subplugin types out of labels 2018-07-25 12:23:08 +08:00
Mihail Geshoski
10bd37fabd MDL-54742 general: Remove strings deprecated in 3.2 2018-07-23 14:25:14 +08:00
Neill Magill
650779d609 MDL-49025 assign: Submissions of an empty directory should not save 
Before this change if only a folder was submitted the submission_is_empty
check would return true. This meant that the draft area would be saved.
The is_empty check would then be called which would return false. This
caused the submission form to indicate to the user that the submission
had failed.

Now is_empty and submission_is_empty should both return false if only
folders are submitted.
 2018-07-13 14:03:42 +01:00